Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b48f2218c0a13273f9976aa082ebb67c3e3d5e75.camel@maquefel.me>
Subject: Re: [PATCH v1 26/43] pata: cirrus: add DT support for Cirrus EP93xx
From:   Nikita Shubin <nikita.shubin@maquefel.me>
To:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Damien Le Moal <dlemoal@kernel.org>
Cc:     Michael Peters <mpeters@embeddedTS.com>,
        Kris Bahnsen <kris@embeddedTS.com>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Sun, 04 Jun 2023 22:29:35 +0300
In-Reply-To: <32a041b0-d02d-4353-4794-094b96271e3a@omp.ru>
References: <20230424123522.18302-1-nikita.shubin@maquefel.me>
         <20230601054549.10843-8-nikita.shubin@maquefel.me>
         <32a041b0-d02d-4353-4794-094b96271e3a@omp.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: bulk

Hello Sergey!

On Fri, 2023-06-02 at 23:03 +0300, Sergey Shtylyov wrote:
> Hello!
>=20
> On 6/1/23 8:45 AM, Nikita Shubin wrote:
>=20
> > - find register range from the device tree
> > - get interrupts from device tree
>=20
> =C2=A0=C2=A0 Hm... I'm not seeing such changes in your patch?

I meant that from now on it will take irq's and register from device
tree:
https://elixir.bootlin.com/linux/v6.4-rc4/source/drivers/ata/pata_ep93xx.c#=
L928

If CONFIG_OF_IRQ is enabled.

You are right

> > get interrupts from device tree

Is confusing.


>=20
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > ---
> >=20
> > Notes:
> > =C2=A0=C2=A0=C2=A0 v0 -> v1:
> > =C2=A0=C2=A0=C2=A0=20
> > =C2=A0=C2=A0=C2=A0 - fixed headers
> > =C2=A0=C2=A0=C2=A0 - dropped coma in id table
> >=20
> > =C2=A0drivers/ata/pata_ep93xx.c | 8 ++++++++
> > =C2=A01 file changed, 8 insertions(+)
> >=20
> > diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
> > index c6e043e05d43..8d363bc71342 100644
> > --- a/drivers/ata/pata_ep93xx.c
> > +++ b/drivers/ata/pata_ep93xx.c
> > @@ -40,6 +40,7 @@
> > =C2=A0#include <linux/ata.h>
> > =C2=A0#include <linux/libata.h>
> > =C2=A0#include <linux/platform_device.h>
> > +#include <linux/mod_devicetable.h>
> > =C2=A0#include <linux/delay.h>
> > =C2=A0#include <linux/dmaengine.h>
> > =C2=A0#include <linux/ktime.h>
> > @@ -1016,9 +1017,16 @@ static int ep93xx_pata_remove(struct
> > platform_device *pdev)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 0;
> > =C2=A0}
> > =C2=A0
> > +static const struct of_device_id ep93xx_pata_of_ids[] =3D {
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ .compatible =3D "cirrus,ep=
9312-pata" },
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ /* sentinel */ }
> > +};
> > +MODULE_DEVICE_TABLE(of, ep93xx_pata_of_ids);
> > +
> > =C2=A0static struct platform_driver ep93xx_pata_platform_driver =3D {
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.driver =3D {
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0.name =3D DRV_NAME,
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0.of_match_table =3D ep93xx_pata_of_ids,
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0},
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.probe =3D ep93xx_pata_=
probe,
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.remove =3D ep93xx_pata=
_remove,
>=20
> MBR, Sergey