Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3df4489939a5285f1e9d923d43bf0e656750a74d.camel@maquefel.me>
Subject: Re: [PATCH v1 25/43] dt-bindings: ata: Add Cirrus EP93xx
From:   Nikita Shubin <nikita.shubin@maquefel.me>
To:     Damien Le Moal <dlemoal@kernel.org>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     Michael Peters <mpeters@embeddedTS.com>,
        Kris Bahnsen <kris@embeddedTS.com>, linux-ide@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Sun, 04 Jun 2023 22:24:45 +0300
In-Reply-To: <fe8bfbfc-0ce5-d4ea-a2a8-8608fe4e2f97@kernel.org>
References: <20230424123522.18302-1-nikita.shubin@maquefel.me>
         <20230601054549.10843-7-nikita.shubin@maquefel.me>
         <fe8bfbfc-0ce5-d4ea-a2a8-8608fe4e2f97@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: bulk

Hello Damien!

On Fri, 2023-06-02 at 08:57 +0900, Damien Le Moal wrote:
> On 6/1/23 14:45, Nikita Shubin wrote:
> > Add YAML bindings for ep93xx SoC PATA.
> >=20
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > ---
> >=20
> > Notes:
> > =C2=A0=C2=A0=C2=A0 v0 -> v1:
> > =C2=A0=C2=A0=C2=A0=20
> > =C2=A0=C2=A0=C2=A0 - renamed file to ep9312-pata
>=20
> Looks OK to me but given that this is both for the cirrus,ep9315-pata
> and
> cirrus,ep9312-pata, wouldn't it be better to name the file
> cirrus,ep931x-pata.yaml ?

I was advised against using wildcards by Arnd and Krzysztof.

See=C2=A0
https://lore.kernel.org/all/c981e048-8925-deba-6916-9199844976b9@linaro.org=
/

As i understood we should have at least one fallback, in out case it's
"cirrus,ep9312-pata" and one for each SoC variant that supports it.

All other comments acknowledged and agreed.

I will also change=20

```
>> +	if (!drv_data)
>> +		return -ENXIO;
```

To ENOMEM, as a part of dt conversion patch in v2.


>=20
>=20
> > =C2=A0=C2=A0=C2=A0 - changed email to dlemoal@kernel.org
> > =C2=A0=C2=A0=C2=A0 - dropped label
> > =C2=A0=C2=A0=C2=A0 - fixed ident
> >=20
> > =C2=A0.../bindings/ata/cirrus,ep9312-pata.yaml=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 | 44
> > +++++++++++++++++++
> > =C2=A01 file changed, 44 insertions(+)
> > =C2=A0create mode 100644
> > Documentation/devicetree/bindings/ata/cirrus,ep9312-pata.yaml
> >=20
> > diff --git a/Documentation/devicetree/bindings/ata/cirrus,ep9312-
> > pata.yaml b/Documentation/devicetree/bindings/ata/cirrus,ep9312-
> > pata.yaml
> > new file mode 100644
> > index 000000000000..3489be55a6fe
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ata/cirrus,ep9312-pata.yaml
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/ata/cirrus,ep9312-pata.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Cirrus Logic EP9312 PATA controller
> > +
> > +maintainers:
> > +=C2=A0 - Damien Le Moal <dlemoal@kernel.org>
> > +
> > +properties:
> > +=C2=A0 compatible:
> > +=C2=A0=C2=A0=C2=A0 oneOf:
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - const: cirrus,ep9312-pata
>=20
> I am not a DT specialist, but isn't this line superfluous since it is
> listed in
> the items ?
>=20
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - items:
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - const: cirrus=
,ep9315-pata
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - const: cirrus=
,ep9312-pata
> > +
> > +=C2=A0 reg:
> > +=C2=A0=C2=A0=C2=A0 maxItems: 1
> > +
> > +=C2=A0 interrupts:
> > +=C2=A0=C2=A0=C2=A0 maxItems: 1
> > +
> > +required:
> > +=C2=A0 - compatible
> > +=C2=A0 - reg
> > +=C2=A0 - interrupts
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +=C2=A0 - |
> > +=C2=A0=C2=A0=C2=A0 ide@800a0000 {
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible =3D "cirrus,ep9312-pata";
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reg =3D <0x800a0000 0x38>;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 interrupt-parent =3D <&vic1>;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 interrupts =3D <8>;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pinctrl-names =3D "default";
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pinctrl-0 =3D <&ide_default_pins>;
> > +=C2=A0=C2=A0=C2=A0 };
> > +
> > +...
>=20