Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-447-ge2460e13b3-fm-20230525.001-ge2460e13
Mime-Version: 1.0
Message-Id: <44c969a1-8dda-425b-acf3-9a80dfa60e79@app.fastmail.com>
In-Reply-To: <ZHudRkB1YcMD_DaQ@surfacebook>
References: <20230424123522.18302-1-nikita.shubin@maquefel.me>
 <20230601053546.9574-10-nikita.shubin@maquefel.me>
 <ZHudRkB1YcMD_DaQ@surfacebook>
Date:   Sun, 04 Jun 2023 19:19:22 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Andy Shevchenko" <andy.shevchenko@gmail.com>,
        "Nikita Shubin" <nikita.shubin@maquefel.me>
Cc:     "Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        "Daniel Lezcano" <daniel.lezcano@linaro.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Michael Peters" <mpeters@embeddedts.com>,
        "Kris Bahnsen" <kris@embeddedts.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 09/43] clocksource: ep93xx: Add driver for Cirrus Logic EP93xx
Content-Type: text/plain
Precedence: bulk

On Sat, Jun 3, 2023, at 22:06, andy.shevchenko@gmail.com wrote:
> Thu, Jun 01, 2023 at 08:34:00AM +0300, Nikita Shubin kirjoitti:
>> This us a rewrite of EP93xx timer driver in
>> arch/arm/mach-ep93xx/timer-ep93xx.c trying to do everything
>> the device tree way:
>> 
>> - Make every IO-access relative to a base address and dynamic
>>   so we can do a dynamic ioremap and get going.
>> - Find register range and interrupt from the device tree.
>
> ...
>
>> +config EP93XX_TIMER
>> +	bool "Cirrus Logic ep93xx timer driver" if COMPILE_TEST
>
> This is strange. What do you gain with this "if COMPILE_TEST"?

This ensures the driver is compiled in an x86 allmodconfig,
like most other clocksource drivers, but it's hidden on
all other configs without EP93xx support.

As long as the platform selects it, this is the normal
way to add a clocksource driver.

     Arnd