Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <871qiqiw44.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Alvin =?ISO-8859-2?Q?=A9ipraga?= <alvin@pqrs.dk>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Alvin =?ISO-8859-2?Q?=A9ipraga?= <alsi@bang-olufsen.dk>,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ASoC: audio-graph-card2: parse symmetric-clock-roles property
In-Reply-To: <20230602090322.1876359-4-alvin@pqrs.dk>
References: <20230602090322.1876359-1-alvin@pqrs.dk>
        <20230602090322.1876359-4-alvin@pqrs.dk>
User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date:   Mon, 5 Jun 2023 00:35:56 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+CFDqa3RZdcB9IDsfmV4I6LDDxflYTV+4+2GaqH8ULOk5peCqX+U7U8Eg3Ec?=
 =?us-ascii?Q?7jKnPtBxl3c6ZMZhRclv54bw8HytSYTijQU6o3f9Q+w5tgpzFZ4brx4LgHnq?=
 =?us-ascii?Q?2TIQJYkU20wMMagcMVgBaqZ2hETsL7M/M+tHvw2aleVbXxz4NOP2jOTFeeAa?=
 =?us-ascii?Q?Z+OWAbvbGavzgMg4POQwgGSW+ekmHbxvshp0ago39vBrk4Uf/Zy+XSlWlLoi?=
 =?us-ascii?Q?SsFDhRfix8rjMyR24npG+i7Ocq2CACV7vkACFSfbRWP8YZvFk4EQP/73LlxZ?=
 =?us-ascii?Q?ewEsgPtQNeyjuhImGZgjFVvq84qXwb4RdNGTSMhqXz1WPDBqfnc8SaNqSdjz?=
 =?us-ascii?Q?BDmbuu0s2v1IjqqhviL0B6T0b3V4cbyPtZ0a/4GjLeTlODTKhQfLPQNnQ9Kk?=
 =?us-ascii?Q?ATINLmhEag/3ZGx/9wuJiyJ0iZzJYQMu+b1AX0NlkTvz8J0p9dsHaKIEiQg4?=
 =?us-ascii?Q?oXQkbfa84eI/qFRD3Ai+nXCRfQz2nSTq3smlo5w29w4Ty+vbY4PAah7IOkgU?=
 =?us-ascii?Q?gARmsflS/pQUmZnnuuoph5TT1AH2jiyR/+Q60bDGZQaYS46SIs+/fjJXpAAd?=
 =?us-ascii?Q?tVxm5h5BM0q0k/oYnjhhDmLq21t0in2dS+jF+Q4ZUudfb/jqEbFY23iZg6TK?=
 =?us-ascii?Q?CPkoIoZUwFsKbLm+teys/oYHCVJ2Vsx3CZeXhlhQUmh7R/6y0gKjMnYECnaq?=
 =?us-ascii?Q?OqNaQIPzknH0lrBMMrEA74eGSZ3voMykiTi5lVfjU7H5Ejn+JvZI04xh2dWc?=
 =?us-ascii?Q?a+asQdt+cl0VkqG0Nz04WO66V7z+JltS1M/NfROayNiUX1GTr2vnwPLJdIao?=
 =?us-ascii?Q?xqCmK4msafLSfDw7kGAuPOQCpybgQ0sW6GEHMqfXvgmRuUQ30mcUqKPwCJG7?=
 =?us-ascii?Q?INZWKDukomyCN6D0VnLS/BMOWnvtZUbFl0aS57ATLs+QWSigPGjXi8Pq5pRC?=
 =?us-ascii?Q?18mUX4UgWLn+4ZM3dPXW/RdWDoyJH4I7AfUgcDU76mtTQhYQFVv/6E66OGDW?=
 =?us-ascii?Q?XSwaDm++M5WUiDjDJapt7dG0Wuh6kR7DEWWsF7/SJ4vXmroIPz83CAf2OiUU?=
 =?us-ascii?Q?vfgSclucx2luFbK/yQPSOXeXfcVIZ27B3egbndeR9Efnl6vYog8dRw0oEFB8?=
 =?us-ascii?Q?3Sjcadh/G7Jd3vK5LCdmy6MYpIMzPwHbpnU883Q7ouuhbj13TUzEOd2OSTWg?=
 =?us-ascii?Q?BrbtZ2EiOu75FnRtuC4k12BkzdvUZwL0fkGqERl6iXpiZPrkBB8gtUNJ2x3p?=
 =?us-ascii?Q?OFr//dWsfD3LjWQROcNHPwwk0FyiquRlq6S7Y7YWHGjqtqaEFRGqcezllX1E?=
 =?us-ascii?Q?j4/XEpft3FoXPjyiI0aVQIT/gGCLZiDDCgfZNf9aop9cv49oOJ1hEUOTsH9q?=
 =?us-ascii?Q?n73cnCWHBC65bNel2e+RqzvFRyN2txqh9y63xtOFrL0UfkltiqK5kqTuMyIS?=
 =?us-ascii?Q?ZBNQw7m7Op01o9bmepnijUIffVPrI3IbPs21D5biBcysxtQSUMjkdX1dCza8?=
 =?us-ascii?Q?uMJbHFy6bRbov1I8ra+IaNxMhyIvX72S6uBx94BPcqzAUl8WZa30QGRujkk/?=
 =?us-ascii?Q?tTFDPWWwXUa+XtICd7KI1PiL4Uxg8RnNlkqXfX6G2hJkpSUNORQVgjQsi+o9?=
 =?us-ascii?Q?AVSAkGnffbM4xQfOYJg8QzE=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 349937df-40e8-411a-e0a7-08db655cd381
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 00:35:56.4091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Miub9P10zm68pwA6iXntOIZSmCyUs0ostT50Q7YZkzHioV0CaIIWE/hnk6KzZtcXjCItpodYDqMETEaEVSdLfO+X+Snzgb1j9qm51kaXX4qRlppy6t6C25Dsh/2aRO1y
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB11386
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Alvin

> --- a/sound/soc/generic/audio-graph-card2.c
> +++ b/sound/soc/generic/audio-graph-card2.c
(snip)
>  	/*
>  	 * convert bit_frame
>  	 * We need to flip clock_provider if it was CPU node,
>  	 * because it is Codec base.
>  	 */
>  	daiclk = snd_soc_daifmt_clock_provider_from_bitmap(bit_frame);
> -	if (is_cpu_node)
> +	if (is_cpu_node && !dai_link->symmetric_clock_roles)
>  		daiclk = snd_soc_daifmt_clock_provider_flipped(daiclk);
>  
>  	dai_link->dai_fmt	= daifmt | daiclk;

Hmm ? I'm confusing
[2/4] patch handling fliping, and [3/4] also handling fliping.
Nothing changed ?

Current SND_SOC_DAIFMT_xx_xx are very confusable,
framework and driver are different (flipped).
and also, audio-graph-card2 is using intuitive DT settings
(need flip for CPU).

Thank you for your help !!

Best regards
---
Kuninori Morimoto