Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <69ea054d-9e3a-6a84-a38b-796f6f152961@marcan.st>
Date:   Mon, 5 Jun 2023 10:21:58 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: linux-next: build failure after merge of the asahi-soc tree
Content-Language: en-US
From:   Hector Martin <marcan@marcan.st>
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Asahi Linux <asahi@lists.linux.dev>
References: <20230605085816.4f54bb43@canb.auug.org.au>
 <E17AC653-8534-4189-ACDF-F6CCD1C1D9F0@marcan.st>
In-Reply-To: <E17AC653-8534-4189-ACDF-F6CCD1C1D9F0@marcan.st>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/06/2023 08.11, Hector Martin "marcan" wrote:
> Hi!
> 
> Thanks, looks like a missing include. I'll fix it up when I get home in a bit. Sorry for the noise!
> 
> (And apologies for top-posting, I'm on mobile right now)
> 

Should be fixed now, thanks again!

TIL that allmodconfig includes COMPILE_TEST. Makes sense though. I don't
build test for x86 often, and I think on arm64 we get bitfield.h pulled
in via common headers, so this isn't the first time I've missed this one...

> On June 5, 2023 7:58:16 AM GMT+09:00, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> Hi all,
>>
>> After merging the asahi-soc tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> In file included from include/linux/io.h:13,
>>                 from drivers/soc/apple/mailbox.c:22:
>> drivers/soc/apple/mailbox.c: In function 'apple_mbox_send':
>> drivers/soc/apple/mailbox.c:151:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
>>  151 |         writeq_relaxed(FIELD_PREP(APPLE_MBOX_MSG1_MSG, msg.msg1),
>>      |                        ^~~~~~~~~~
>> arch/x86/include/asm/io.h:103:42: note: in definition of macro 'writeq_relaxed'
>>  103 | #define writeq_relaxed(v, a)    __writeq(v, a)
>>      |                                          ^
>> drivers/soc/apple/mailbox.c: In function 'apple_mbox_poll_locked':
>> drivers/soc/apple/mailbox.c:188:28: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
>>  188 |                 msg.msg1 = FIELD_GET(
>>      |                            ^~~~~~~~~
>>
>> Caused by commit
>>
>>  0d1f3f7f8486 ("soc: apple: mailbox: Add ASC/M3 mailbox driver")
>>
>> I have used the asshi-soc tree from next-20230602 for today.
>>
> 
> - Hector

- Hector