Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 09:04:45 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     "Paul E. McKenney" <paulmck@kernel.org>
CC:     Dave Hansen <dave.hansen@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>, <rui.zhang@intel.com>,
        <x86@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] x86/tsc: Make recalibration default on for
 TSC_KNOWN_FREQ cases
Message-ID: <ZH00rXjK+H1BTBrQ@feng-clx>
References: <20230522033018.1276836-1-feng.tang@intel.com>
 <87h6s4ye9b.ffs@tglx>
 <934e9008-36db-492b-b744-9d68183c6d32@paulmck-laptop>
 <73283eba-14b8-2da1-6109-c183586fe5b7@intel.com>
 <2c5a8c69-21d0-4b1a-ad1b-6072228e2b43@paulmck-laptop>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2c5a8c69-21d0-4b1a-ad1b-6072228e2b43@paulmck-laptop>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8CYwydEYx9oQb3RqeEUODuPJZBXPMQa1gja/+j4W5OadMl+DpjJRmJi7PMxS?=
 =?us-ascii?Q?+GsjxNpB90QkMTGX3YGGZ2m1Q0PZT0Y4OZNtYR3th+Iv99YA1g/LLay4zIaP?=
 =?us-ascii?Q?pZ+E5hmTzBiNHPolphu1O+io7ggFlaV/Hub2apNJlRGvSij1hPM3pToOpLFi?=
 =?us-ascii?Q?gUeeNtNN04X18ug+bx5Y91d4cdcx7TuhY1tKY5c4+nPZv/Xw0vDNQlUBfSzj?=
 =?us-ascii?Q?8cp4wZ5Wp1WsCy6Km/d6xai/rZdCK0YLStBbLeXPQPBSP2pNyIy7EpxOcTTF?=
 =?us-ascii?Q?IZAvw2mp8EilaB1GmkqSEwkF25WpocYWcORNRei2CqnarLMHb38rD9SjuNad?=
 =?us-ascii?Q?vO6gaa7pNgljh2xuTZLnjQUxXxajj2uv9hcVUqMFFdAnlJh1fkVlj9eZc+Y5?=
 =?us-ascii?Q?YoSUaWtVaTc0lt03LDwz1iBt8SURVOnJBEEabe/HTcIAZ0laD9+f9z4MD0Tf?=
 =?us-ascii?Q?duHyVerIGqAeiNMdD402pqnb6rdwDforLhR2qQkJISc3ijXY7bEBut7K5F/I?=
 =?us-ascii?Q?5pJe7ktvYoBtYdetOPXlowiO2qxHTEgI/3cDC6fomWtR6K1qZnmdgTCBW8/F?=
 =?us-ascii?Q?Hxdo3xdTLVxx5h1sBHD47DSFMJf3/gtpzpiYMd/6vjrHsgbSQgVXmOOGY3M5?=
 =?us-ascii?Q?+40/KS38EuejS/8EOcD8I6tJ6qAzKPuKklkkZVbR88ljzOsT2GpN+cNeqRqs?=
 =?us-ascii?Q?OiOAnPzOJTMXztLPV1cqCjTRM+4/jmNUJKPf7DQ7dPeq4+BcpnRxkqpthLZk?=
 =?us-ascii?Q?jmRzQXXejr0TmEcQEJLhJcQS0I0TKhIuZOHfkm+MScIFOn/BiKUQm/CuQG1f?=
 =?us-ascii?Q?4dZr99oMRITeUX1Ay4yNd81BiDbzbid9iEfaSB+6TvH5S6qQXrBdybVo+4yd?=
 =?us-ascii?Q?WRk5Xphvl5GTRWa7dkk3Vfc+iMzd4cbff+4D/9LrLkSd3m+ekYEJKKA1agFr?=
 =?us-ascii?Q?VYyK8E4AQeOFhJxSlB/9zsycrd09jkAXnRrpnokSH+wxxnepNSvW0cu3Lck1?=
 =?us-ascii?Q?2W+eaJIMvPhwsE5zYazs15+47nbuAYtMcBMQl0pNJzXDWzLLTXP+HKOzfBiW?=
 =?us-ascii?Q?49aWw5wnJhZbrnjdjuHqsP+0GapyIg/lz73sAapIcL22Wtehgg/Dw3XOLCra?=
 =?us-ascii?Q?BmC9mkJK4BmDmQpiv0bauSZLJAw7rbhGkhwQFuYsk4q8+3E+GKjflfvP7Iy2?=
 =?us-ascii?Q?wWm+mwCzVYPZHkISzeggLni2oWbCP+h0xdTHbXqEG6RXfgsVu9pRHZdjQwpV?=
 =?us-ascii?Q?gdNbi37uRnC2S3bVlDHmPp8hsBbydO+5ISePImU9dr4XfLowFOUBDLQ8lD5l?=
 =?us-ascii?Q?ODLE7KFi5DuBjAfZRK6WdpHLuuw5W3owRjlgOL7c1osHzheg+AimYp15vAzy?=
 =?us-ascii?Q?G6CF7wkD0qTgOoxAeK9EZuUWMSej1G1J8wdpglcNNeYHPTmO4xwOgIJBAIvg?=
 =?us-ascii?Q?lSyEgJNFLIMCBO4y/c7cFJWkVK/6jHn6e9uNRtvrfCxv2nmSfgznnZN8MgB/?=
 =?us-ascii?Q?eKUSM5ZaM8fOtSEhX1z4YRYRx1NTnE6t4fxDyoE7CcIcjq7hbFscYiCgfail?=
 =?us-ascii?Q?H9xbA60IJKSVVlD4U7UHQcJhiCP1VYCJigcYpqhu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f2a3330-1494-493f-714e-08db6561da02
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 01:11:54.9493
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +zqIhhCe9yL67pf6j3gXIKFpC6MO84XZe5Ym0zZ/VkRUx6DnKHrk/43cnkHmCRPjRUgdlJztrC9MaU7quSg7IQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8333
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 02, 2023 at 12:08:10PM -0700, Paul E. McKenney wrote:
> On Fri, Jun 02, 2023 at 11:36:54AM -0700, Dave Hansen wrote:
> > On 6/2/23 11:29, Paul E. McKenney wrote:
> > >>> One downside is, many VMs also has X86_FEATURE_TSC_KNOWN_FREQ set,
> > >>> and they will also do this recalibration.
> > >> It's also pointless for those SoCs which lack legacy hardware.
> > >>
> > >> So why do you force this on everyone?
> > > Just for the record, this patch could be helpful in allowing victims
> > > of TSC mis-synchronization to more easily provide a more complete bug
> > > report to the firmware people.  There is of course no point if there is
> > > already a fix available.
> > > 
> > > But it is not all that hard to work around not having this patch upstream.
> > > This can be hand-applied as needed, NTP drift rates can be pressed
> > > into service for those of us having atomic clocks near all our servers,
> > > or the firmware guys can be tasked with figuring it out.
> > > 
> > > So this patch would be nice to have, but we could live without it.
> > 
> > Is this the kind of thing we could relegate to a kernel unit test?  Like
> > make the recalibration logic _available_, but don't have it affect the
> > rest of the system.
> > 
> > I love patching my kernel as much as the next guy.  But, you know what I
> > *don't* love?  Explaining how to patch kernels to other people. ;)
> 
> One could argue that we already have the TSC equivalent of a kernel unit
> test with the tsc=recalibrate kernel boot parameter.
> 
> So, would it make sense to have something like tsc=recalibrate (already
> present) in the guise of something like hpet=recalibrate and/or
> pmtmr=recalibrate in order to allow people to opt into recalibrating
> whatever timer is marked unstable?
 
This kind of hint parsing should be in tsc.c, so some name like
'tsc_recal=hpet/pmtmr' ?  

As hpet and pmtimer are the only 2 choices and hpet is the default
one, if people want to use pmtimer, they can use combined parameter 
"tsc=recalibrate nohpet".

Also, thanks for sharing your thoughts form a victim's viewpoint
in the other mail! :)

Thanks,
Feng

> 							Thanx, Paul