Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 11:47:37 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Zeng Guang <guang.zeng@intel.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        H Peter Anvin <hpa@zytor.com>, <kvm@vger.kernel.org>,
        <x86@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/6] KVM: VMX: Add new ops in kvm_x86_ops for LASS
 violation check
Message-ID: <ZH1a2ep4o2xiI5wO@chao-email>
References: <20230601142309.6307-1-guang.zeng@intel.com>
 <20230601142309.6307-4-guang.zeng@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230601142309.6307-4-guang.zeng@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5PTeuFBp0AXVgigwjm6DiPKSzueQZw2yZal0LH80IrPQqNGBAlb80KYd2rrE?=
 =?us-ascii?Q?js1yqHLzN/NBC5C7aWoPcSRenQdxLhb3+jJ0UIRBCwaHCk4a91PLJzzcF1yk?=
 =?us-ascii?Q?UC9mgyKnTXjpoIzCHSzOAJeQ8kT97PGlgsKQnkQO3YpSY0cA3+3NnoYVIbwG?=
 =?us-ascii?Q?iypxt1G7+PDOiSlknvEXAM1evBOtSKKOX0EA4NAaXGo6g+C/x5JaFPpngK7g?=
 =?us-ascii?Q?rljwunIJjG7YBaxCv0Mgua3bTxAs/wrSq1enJRtcJRSJYW0rq8ZKTMpie5DP?=
 =?us-ascii?Q?l24BeMt9pBBFEpTv38k1yZvBeRxiBkfmyAgut+45QHbHXQ2ke/yKV24vadV8?=
 =?us-ascii?Q?XFMokuAuaTiKvkDadjZIYe+4S9HyLj+k7qkwohI+MYTNfLrdYKG/kk9/fdiZ?=
 =?us-ascii?Q?a5hCiL1+88OI1HIFjIPUwqP573KBa98vcsBi3QfF863myEVljfYV5VZI4Ptz?=
 =?us-ascii?Q?KA98M9epNIzCVwRtM/V6DWOHidhi8hwa+0S415FoX6lWOq0uypigm1KvRR/p?=
 =?us-ascii?Q?TjnpJb3o5Y3GOVHlM3v4UPtS/Pb8ErOXXWJCk7ba30hFsRw/YbwWIZh/tR8H?=
 =?us-ascii?Q?HkqQ/b2/sp85FR28zEqVrmhXv44yocNzmrjPwBR5AmeZmtMLfwHEmKwXV2kf?=
 =?us-ascii?Q?K+rUESxiE/HxjWruz6VRlR8ebo2cuOMGHDAR4wIWcck3zhEo7geTrlRSjldR?=
 =?us-ascii?Q?0pYrZs3pFl8PjXydlOB7cQzP2VWgKgkDNYCNyc2sTCx8lqbA3L2Xlv31L5R5?=
 =?us-ascii?Q?IhknOA7qsUlxgIsz2dVKMku2xM/yB3zrmRXlKtpT2/le8sYk9NRMI1w4OOYz?=
 =?us-ascii?Q?IC8Zs/a5LB1Sy12RaSmtnR5ib8xv0xDPnbhtDmY5qBrkJf/U8btXycSg2vjh?=
 =?us-ascii?Q?MQsJzu9XLl9Cyh94ZHHj/lwF4k002xsZd9FOXfS3aTlHPwr9xoHOS4YHpbTN?=
 =?us-ascii?Q?tAbbd5SHLgFpYs65BflJMPXVF6qaI8+MUorSkd9VZsBUEeGlH1xgC3NjHS5i?=
 =?us-ascii?Q?D/WmaNXwnCYDgAhAS+pK2qA38ATnBOny6CFYL6SY6tYWQNQd28SG1qcoRbvU?=
 =?us-ascii?Q?ICzKpn9xWMR/Naq0HbmD/3X6K/1RGfVUSeAWdgBUN9YwtpoBeTILhYD1hGav?=
 =?us-ascii?Q?qQM57UBEdyxoIzMEm8AbOf3l2IoSXDa0ld1Ri0+m5toS8SJ/3XMsyIr3dl/X?=
 =?us-ascii?Q?xPldfTg6kL3LiVV/qwcIbSaxFMp4V8oNjRjUfQ3+jrSTT9tJtGXJhLTsxEvh?=
 =?us-ascii?Q?l64qufeOewNzP52E7rQ84ro8ECHrHC3aA8B9HDJb4eXVeZ8F9u6QAk0cBvFL?=
 =?us-ascii?Q?kK0XaW2ciYXpoDkOgk5RUYz6ubyrINY0vzFjCYJ1GDE7C59novUgT7V5LNIN?=
 =?us-ascii?Q?WiqpmfgzKYkTEIWJNeqjHagwPBKwbAyZjM+5o3nnJSRZoxD5F/8+++SBXqxa?=
 =?us-ascii?Q?ECwfY38yToBRjbveLErfBubeT41c85kDceMrqPKYWQoJb5farf2x9LInVYfc?=
 =?us-ascii?Q?qB9dKaiSc6rtt7UtRX+bTv+As/M5GuhcLjfaAvt1ZbsYFbL70Bki7TN8p/c+?=
 =?us-ascii?Q?cnt6MrvLxHi3rVzp5Pz0QWUG60hg0u5wkaPmGUaG?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ff7c9197-02e1-4526-e224-08db6577a19d
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 03:47:49.4219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wr1JuiVfhgML8XgN5AwHGD889MhrLLTy8F+4bN+hHCx+i+iS4sW6d6tZSbRr+B4Dls+YUVwvZOuxb7ZY+vZbZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7323
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 01, 2023 at 10:23:06PM +0800, Zeng Guang wrote:
>diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
>index 92d8e65fe88c..98666d1e7727 100644
>--- a/arch/x86/include/asm/kvm_host.h
>+++ b/arch/x86/include/asm/kvm_host.h
>@@ -1731,6 +1731,8 @@ struct kvm_x86_ops {
> 	 * Returns vCPU specific APICv inhibit reasons
> 	 */
> 	unsigned long (*vcpu_get_apicv_inhibit_reasons)(struct kvm_vcpu *vcpu);
>+
>+	bool (*check_lass)(struct kvm_vcpu *vcpu, u64 access, u64 la, u32 flags);

It is better to declare the @la as gva_t since the address is a virtual address.

Both @access and @flags provide additional informaiton about a memory access. I
think we can drop one of them e.g. adding a new bit X86EMUL_F_IMPLICIT_ACCESS.

Or maybe in the first place, we can just extend PFERR_? for SKIP_LASS/LAM
behavior instead of adding another set of flags (X86EMUL_F_?). The benefit of
adding new flags is they won't collide with future hardware extensions. I am not
sure.