Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230603165949.1753326-1-masahiroy@kernel.org>
In-Reply-To: <20230603165949.1753326-1-masahiroy@kernel.org>
From:   Jinpu Wang <jinpu.wang@ionos.com>
Date:   Mon, 5 Jun 2023 06:47:02 +0200
Message-ID: <CAMGffEk-_dGmciH7ggsATVAHyCwLemkR_UX4ikRJmuC7w1ePrg@mail.gmail.com>
Subject: Re: [PATCH] block/rnbd: fix mixed module-builtin object
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "Md. Haris Iqbal" <haris.iqbal@ionos.com>,
        Nick Terrell <terrelln@fb.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Masahiro,


On Sat, Jun 3, 2023 at 6:59=E2=80=AFPM Masahiro Yamada <masahiroy@kernel.or=
g> wrote:
>
> With CONFIG_BLK_DEV_RNBD_CLIENT=3Dm and CONFIG_BLK_DEV_RNBD_SERVER=3Dy
> (or vice versa), rnbd-common.o is linked to a module and also to
> vmlinux even though CFLAGS are different between builtins and modules.
>
> This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
> Fixing mixed module-builtin objects").
>
> Turn rnbd_access_mode_str() into an inline function.
Thx for you fix, but Guoqing has a slightly different patch in the queue:

https://lore.kernel.org/linux-block/CAMGffEnDjAP3zqytmsYxacvUROLKZj+KhH6LOX=
icOoPhS9FJJQ@mail.gmail.com/
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>


> ---
>
>  drivers/block/rnbd/Makefile      |  6 ++----
>  drivers/block/rnbd/rnbd-common.c | 23 -----------------------
>  drivers/block/rnbd/rnbd-proto.h  | 14 +++++++++++++-
>  3 files changed, 15 insertions(+), 28 deletions(-)
>  delete mode 100644 drivers/block/rnbd/rnbd-common.c
>
> diff --git a/drivers/block/rnbd/Makefile b/drivers/block/rnbd/Makefile
> index 40b31630822c..208e5f865497 100644
> --- a/drivers/block/rnbd/Makefile
> +++ b/drivers/block/rnbd/Makefile
> @@ -3,13 +3,11 @@
>  ccflags-y :=3D -I$(srctree)/drivers/infiniband/ulp/rtrs
>
>  rnbd-client-y :=3D rnbd-clt.o \
> -                 rnbd-clt-sysfs.o \
> -                 rnbd-common.o
> +                 rnbd-clt-sysfs.o
>
>  CFLAGS_rnbd-srv-trace.o =3D -I$(src)
>
> -rnbd-server-y :=3D rnbd-common.o \
> -                 rnbd-srv.o \
> +rnbd-server-y :=3D rnbd-srv.o \
>                   rnbd-srv-sysfs.o \
>                   rnbd-srv-trace.o
>
> diff --git a/drivers/block/rnbd/rnbd-common.c b/drivers/block/rnbd/rnbd-c=
ommon.c
> deleted file mode 100644
> index 596c3f732403..000000000000
> --- a/drivers/block/rnbd/rnbd-common.c
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0-or-later
> -/*
> - * RDMA Network Block Driver
> - *
> - * Copyright (c) 2014 - 2018 ProfitBricks GmbH. All rights reserved.
> - * Copyright (c) 2018 - 2019 1&1 IONOS Cloud GmbH. All rights reserved.
> - * Copyright (c) 2019 - 2020 1&1 IONOS SE. All rights reserved.
> - */
> -#include "rnbd-proto.h"
> -
> -const char *rnbd_access_mode_str(enum rnbd_access_mode mode)
> -{
> -       switch (mode) {
> -       case RNBD_ACCESS_RO:
> -               return "ro";
> -       case RNBD_ACCESS_RW:
> -               return "rw";
> -       case RNBD_ACCESS_MIGRATION:
> -               return "migration";
> -       default:
> -               return "unknown";
> -       }
> -}
> diff --git a/drivers/block/rnbd/rnbd-proto.h b/drivers/block/rnbd/rnbd-pr=
oto.h
> index da1d0542d7e2..57afe9b07fda 100644
> --- a/drivers/block/rnbd/rnbd-proto.h
> +++ b/drivers/block/rnbd/rnbd-proto.h
> @@ -300,6 +300,18 @@ static inline u32 rq_to_rnbd_flags(struct request *r=
q)
>         return rnbd_opf;
>  }
>
> -const char *rnbd_access_mode_str(enum rnbd_access_mode mode);
> +static inline const char *rnbd_access_mode_str(enum rnbd_access_mode mod=
e)
> +{
> +       switch (mode) {
> +       case RNBD_ACCESS_RO:
> +               return "ro";
> +       case RNBD_ACCESS_RW:
> +               return "rw";
> +       case RNBD_ACCESS_MIGRATION:
> +               return "migration";
> +       default:
> +               return "unknown";
> +       }
> +}
>
>  #endif /* RNBD_PROTO_H */
> --
> 2.39.2
>