Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5189110rwd; Sun, 4 Jun 2023 22:58:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6dSI40Pa+/eFeFSZV4HRAlBTejkg39YaSXdVdZqWBVQKsyMGM4nE259D+uGjpsRXs3FGh/ X-Received: by 2002:a0d:d444:0:b0:565:8c16:a0e1 with SMTP id w65-20020a0dd444000000b005658c16a0e1mr10447183ywd.13.1685944690917; Sun, 04 Jun 2023 22:58:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685944690; cv=none; d=google.com; s=arc-20160816; b=M7JgUftdaO4SaUBzzQqCoYKjeDaoEGSgvSIXjsBC1TC3zwHuoBPqZvDr01wShJOA3z HpzMlWmkJzqM82CoNVeFPaJG9mDx1aFL0pmXpxf95ecewRgOhhTbY2NMzbeIP46t3F4t TwgF2jD/ejlIWvH9JErMOva0x7B80H0XFih/uUkNrRpK0uFwTXyyYDcPa+6KUblvTorR a51C55g3CSKkb2KgCShzkTQmmN7iZavZsoLWPUjGl4h/QvZG9uYukEDp3cxj1wpiwvtB eAqEk+kPkIO4IZ1tk5/wgis7RyA44bDOaPOnUezT7y5p13aRtwry5jDG9CDqIDL8YsEp KPUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=LGOId8j20XVFeHLR9Y38zWr7CHf3zpKBIMLddm7ddvI=; b=0eqXHBnr3e2Jd/um5dUmOhlEl83DULRrwS09lzRkphOZEKvn3rJQAFtInRTKaE1r+B 0ve7IQrVzyG6827HwKxdi859e7BO73CKoxlANbx4ueExYEiOIHTq6wl63wIYGFqx6Ekf w/Hl1TkoPT0J9o169AXZ2FtCCVBvgp8aiy7tDUpijCk/v63ngkGI+8RVMH+R1P/joyof HysfkNRF3Udm7oZN9v15FvxVja8RfccH4qfh3dyQCHG7sY4Cotg36KZmHfKgu8DGz8Ph rAIW5+9E7A/9maPDT2Zez22M/JTyl2/Am+CJo5AeSY5GG3N24q3mVRGpb9lcGUifM3X2 I9LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=fJcpG+FW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y25-20020a637d19000000b0054104fb57besi4259149pgc.449.2023.06.04.22.57.55; Sun, 04 Jun 2023 22:58:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=fJcpG+FW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232657AbjFEFih (ORCPT + 99 others); Mon, 5 Jun 2023 01:38:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjFEFif (ORCPT ); Mon, 5 Jun 2023 01:38:35 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 492C4A9; Sun, 4 Jun 2023 22:38:34 -0700 (PDT) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3555DYUu025288; Mon, 5 Jun 2023 05:38:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=LGOId8j20XVFeHLR9Y38zWr7CHf3zpKBIMLddm7ddvI=; b=fJcpG+FWHcSPYBdC3B530Iu1czRfK5XwNca6iUbjkk4FVcbJ0GvVYUqyN7ivzCjHrW4U +MfLAl9Wm2Ebsa8a+QCTDBTCOjuKIgemsZgDQkUtftFaCFb958bGbOjuQNngOvPeMoN5 fpV/6JlMMnU8Ne3Xg01TD6Hb5IPl0rzEgzFC2aJsu2OmxjEDwMV9wIEaQNNuIjjs84fl VTCRJZyAZQ2H3Z1N+pAQzuIM2RxG5dTV1EEXe09rtSe8d8HXKaRGB5t24I94aw6Vpn4N YayN/71MiU5lHlD86iIZuyb8ZJNQxKMWxp+aPuzmpMktx6jSd/CT8SkTu5O6iHY0vXVF YA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qyxq02jq9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jun 2023 05:38:29 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3555cT5u027285 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Jun 2023 05:38:29 GMT Received: from [10.201.206.238] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Sun, 4 Jun 2023 22:38:20 -0700 Message-ID: <24803a8c-098d-dfae-bb99-0feb9204e188@quicinc.com> Date: Mon, 5 Jun 2023 11:08:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH V2 11/13] arm64: dtsi: qcom: ipq5018: enable nodes required for multipd Content-Language: en-US From: Manikanta Mylavarapu To: Krzysztof Kozlowski , , , , , , , , , , , , , , , , , , , CC: , , , , , , References: <20230521222852.5740-1-quic_mmanikan@quicinc.com> <20230521222852.5740-12-quic_mmanikan@quicinc.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 37Zi98f2dl_h_vtkOflL3UfcbSTRF6C6 X-Proofpoint-GUID: 37Zi98f2dl_h_vtkOflL3UfcbSTRF6C6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-03_08,2023-06-02_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 mlxscore=0 mlxlogscore=778 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2306050049 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/5/2023 11:05 AM, Manikanta Mylavarapu wrote: > > > On 5/30/2023 4:35 PM, Krzysztof Kozlowski wrote: >> On 22/05/2023 00:28, Manikanta Mylavarapu wrote: >>> Enable nodes required for multipd remoteproc bring up >> >> Please use subject prefixes matching the subsystem. You can get them for >> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >> your patch is touching. >> >> It is "dts". Not "dtsi". >> > Sure, I will update to 'dtsi'. > Sorry please discard my previous reply. I will update to dts. >>> >>> Signed-off-by: Manikanta Mylavarapu >>> --- >>> Changes in V2: >>>     - Corrected syntax like alignmnet and kept nodes in sorted order. >>>     - Covered entire TCSR region. >>>     - Added 'firmware-name' property. >>> >>>   arch/arm64/boot/dts/qcom/ipq5018.dtsi | 140 ++++++++++++++++++++++++++ >>>   1 file changed, 140 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi >>> b/arch/arm64/boot/dts/qcom/ipq5018.dtsi >>> index 9f13d2dcdfd5..3772d54d89e4 100644 >>> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi >>> @@ -85,6 +85,18 @@ >>>               reg = <0x0 0x4ac00000 0x0 0x200000>; >>>               no-map; >>>           }; >>> + >>> +        q6_region: wcnss@4b000000 { >>> +            reg = <0x0 0x4b000000 0x0 0x1700000>; >>> +            no-map; >>> +        }; >>> + >>> +        smem@4ab00000 { >>> +            compatible = "qcom,smem"; >>> +            reg = <0x0 0x4ab00000 0x0 0x100000>; >>> +            hwlocks = <&tcsr_mutex 0>; >>> +            no-map; >>> +        }; >>>       }; >>> >>>       soc: soc@0 { >>> @@ -128,6 +140,12 @@ >>>               #power-domain-cells = <1>; >>>           }; >>> >>> +        tcsr_mutex: hwlock@1905000 { >>> +            compatible = "qcom,tcsr-mutex"; >>> +            reg = <0x01905000 0x20000>; >>> +            #hwlock-cells = <1>; >>> +        }; >>> + >>>           sdhc_1: mmc@7804000 { >>>               compatible = "qcom,ipq5018-sdhci", "qcom,sdhci-msm-v5"; >>>               reg = <0x7804000 0x1000>; >>> @@ -181,6 +199,14 @@ >>>               }; >>>           }; >>> >>> +        apcs_glb: mailbox@b111000 { >>> +            compatible = "qcom,ipq5018-apcs-apps-global", >>> +                     "qcom,ipq6018-apcs-apps-global"; >>> +            reg = <0x0b111000 0x1000>; >>> +            #clock-cells = <1>; >>> +            #mbox-cells = <1>; >>> +        }; >>> + >>>           timer@b120000 { >>>               compatible = "arm,armv7-timer-mem"; >>>               reg = <0x0b120000 0x1000>; >>> @@ -238,6 +264,96 @@ >>>                   status = "disabled"; >>>               }; >>>           }; >>> + >>> +        q6v5_wcss: remoteproc@cd00000 { >>> +            compatible = "qcom,ipq5018-q6-mpd"; >>> +            reg = <0x0cd00000 0x4040>; >>> +            firmware-name = "IPQ5018/q6_fw.mdt", >>> +                    "IPQ5018/m3_fw.mdt", >>> +                    "qcn6122/m3_fw.mdt"; >>> +            interrupts-extended = <&intc GIC_SPI 291 >>> IRQ_TYPE_EDGE_RISING>, >>> +                          <&wcss_smp2p_in 0 0>, >>> +                          <&wcss_smp2p_in 1 0>, >>> +                          <&wcss_smp2p_in 2 0>, >>> +                          <&wcss_smp2p_in 3 0>; >>> +            interrupt-names = "wdog", >>> +                      "fatal", >>> +                      "ready", >>> +                      "handover", >>> +                      "stop-ack"; >>> + >>> +            qcom,smem-states = <&wcss_smp2p_out 0>, >>> +                       <&wcss_smp2p_out 1>; >>> +            qcom,smem-state-names = "shutdown", >>> +                        "stop"; >>> +            memory-region = <&q6_region>; >>> + >>> +            glink-edge { >>> +                interrupts = ; >>> +                label = "rtr"; >>> +                qcom,remote-pid = <1>; >>> +                mboxes = <&apcs_glb 8>; >>> +            }; >>> + >>> +            pd-1 { >>> +                compatible = "qcom,ipq5018-wcss-ahb-mpd"; >>> +                firmware-name = "IPQ5018/q6_fw.mdt"; >>> +                interrupts-extended = <&wcss_smp2p_in 8 0>, >>> +                              <&wcss_smp2p_in 9 0>, >>> +                              <&wcss_smp2p_in 12 0>, >>> +                              <&wcss_smp2p_in 11 0>; >> >> What "0" stands for? >> > 0 means IRQ_NONE. These are software interrupts (register write), > so we have configured to 0. I will replace 0 with IRQ_NONE. > > Thanks & Regards, > Manikanta. > >>> +                interrupt-names = "fatal", >>> +                          "ready", >> Best regards, >> Krzysztof >>