Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5260090rwd; Mon, 5 Jun 2023 00:26:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5o+gxcNmcvBHa+meFkPEhT7CHH7bo4Mkhcw5IRGxxCTSJ16WAl2PlmbfE3P644bRM2sXRN X-Received: by 2002:aca:1817:0:b0:396:4977:e148 with SMTP id h23-20020aca1817000000b003964977e148mr7318410oih.9.1685949965484; Mon, 05 Jun 2023 00:26:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685949965; cv=none; d=google.com; s=arc-20160816; b=GwFrgYhfRKFITD74GTRaZJUdJ367BPVFvbKXzioCrAdJTtiZ8TvaQOvNITc6sj9cX7 6rVdZwy3zh5yQ2d795zx6bzYIF7P/4NPS9tpa1Ag0SttKXPOM0jUDA4fJ4GIDR1kH9ew jTUz6aS8uaTi7MFyWY0ZGr7nfo67rMjpvCwRoRShs9fAWRpcKROdEryp0tZ/NpqKVKgM N/jTLkQ8Lv94FuowRnuBnCwUmyWCs84q9B07T6ZoU6kBmOhlF2OMqTriHYRjq+WwCXNO FZJAxA1/8t+kUMCbDrOy7KiP6hlWfqRlJKOMr0ShdhvnEXQ2LEFlfG/66kRP0O+JD31h jDbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EALWmWWdQoiiTMoCxeeFSRu137UCz86GXVxWZguWtgc=; b=p88UGpjAcDqSJYp1YXuIH0JOsTpFMPj+SYNAdbibdfSOVgvPYOToxiqQw9w61xNT3F wI7F2EauiCvjJa2U9EVqJjKTHdgIlb+jag86N27+iA2AJZmvvveIGVpOV+p5cxXC3Hcd X8q731YRobTGlG1x7dDDU+3+BoczXKJiDJeNhbJJYHI09f4/4fAsh6bqKsLXX1Qel58Z qVwRtYQzcDnp0SCKzKpRg7iUIPshkpao2zCUOfT2Ie3mmIZ+Wr7Zy1bw/A7THt5cY9my TZx6klFlGGoV204VNniN/seeQV74A0DBpb8QYwCgNDRObIAiu3aimxHCuk+/TyYH2rEF UZfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FiNs5MlC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k186-20020a633dc3000000b005348977b5c5si5258613pga.97.2023.06.05.00.25.51; Mon, 05 Jun 2023 00:26:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FiNs5MlC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230034AbjFEHIY (ORCPT + 99 others); Mon, 5 Jun 2023 03:08:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230145AbjFEHIT (ORCPT ); Mon, 5 Jun 2023 03:08:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A3D7E5A for ; Mon, 5 Jun 2023 00:07:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A8DF861F9F for ; Mon, 5 Jun 2023 07:06:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F951C433EF; Mon, 5 Jun 2023 07:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685948801; bh=JrRk8+31vboG/VQHuPBXvcmI4AOcYJ94E5CXxrXjCIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FiNs5MlC02+V1hliD8D46cJ6xPDu55/uvF0FE4SVAAmg6b2AnTZ4ugLr+EbsEMkd9 IMj7yFbrA+nY+g5g81mkl+7Mg8Bgx5TtgPPXv1Ku1Z7T2CqPU1JfF2cKcZGudIJ1ln JdB/5Tv6KpVLXHoibY1MoxTlL34iwRmL2bI9N0n3MBhT2hxsUlUOnY9FTsWHaZ7hWg R0fP1lXP/di3AMjKzi23o4ZbIVzOw6wtmE3ZXJbZtTSGZybI7uHXDXT+VLvLu7YOiS i8D4I91LM5q+BSG+s6ipDSadzK5mI190sYeLbSI0GO6cGi62VH9FFGi23DQVnJ2RKf EqosM3B6EombQ== Date: Mon, 5 Jun 2023 12:36:36 +0530 From: Vinod Koul To: Bartosz Golaszewski Cc: Bhupesh Sharma , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Andrew Halaney , Jesse Brandeburg , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH net] net: stmmac: dwmac-qcom-ethqos: fix a regression on EMAC < 3 Message-ID: References: <20230602190455.3123018-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230602190455.3123018-1-brgl@bgdev.pl> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02-06-23, 21:04, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We must not assign plat_dat->dwmac4_addrs unconditionally as for > structures which don't set them, this will result in the core driver > using zeroes everywhere and breaking the driver for older HW. On EMAC < 2 > the address should remain NULL. Reviewed-by: Vinod Koul -- ~Vinod