Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 00:31:02 -0700 (PDT)
From:   Ilkka Koskinen <ilkka@os.amperecomputing.com>
To:     Robin Murphy <robin.murphy@arm.com>
cc:     will@kernel.org, mark.rutland@arm.com, suzuki.poulose@arm.com,
        bwicaksono@nvidia.com, ilkka@os.amperecomputing.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Hanjun Guo <guohanjun@huawei.com>,
        Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 2/4] ACPI/APMT: Don't register invalid resource
In-Reply-To: <91c8787f1e84d79e110a057615c838f6ac244669.1685619571.git.robin.murphy@arm.com>
Message-ID: <2a5adc-754-ec3-d139-3d49e3d7f1f@os.amperecomputing.com>
References: <cover.1685619571.git.robin.murphy@arm.com> <91c8787f1e84d79e110a057615c838f6ac244669.1685619571.git.robin.murphy@arm.com>
Content-Type: text/plain; format=flowed; charset=US-ASCII
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Kr59sGfhvjNlM65oXzkmfb2hQGsIpURcRBoS7jXq2tF3cCGur7U0tPa4g2nl?=
 =?us-ascii?Q?7DieP44AExFGhFAVoOdWJiy38iR+gcCMDn0aQDHfi7EF5bScNksyHRSjOevZ?=
 =?us-ascii?Q?fUCq/vfcW0tn8KERhCBK6yAGAG1/xlIENjXvCvb0PaK6BUePAHGkwzadGgcu?=
 =?us-ascii?Q?ZOcQsdpDp5PYgFF4tPe465siy3ROaRdQEa12rngRw+5+lZSmYxCJf5SPRs7r?=
 =?us-ascii?Q?F35810zH67STLq4+1SZZv+px3pEwFrTBx4LAHyc3d/klGxajZ1qmZqy2+Pzm?=
 =?us-ascii?Q?+T+BHo8mTIqS4xVIDcdO9Buj0G7jwrDUcg23mNVP+MqNiV3dai9vfZNBE4yn?=
 =?us-ascii?Q?oXMnEi/CGHu3/tV3huHPP0Xset12J+V09DJYQRxYRoxzop+V3J0dTPGZnKuZ?=
 =?us-ascii?Q?CMxsogyDHwngrbZQPinz5SkwPDtjSpPwZAxOncDZIya9V0cdWHWqz/KG8dlg?=
 =?us-ascii?Q?gQSm7Sr25qWLu1Pa771wFGWqoskLAGNl400FqesU6vgCxHlKkB0I/BJ/ATt3?=
 =?us-ascii?Q?fxd0tyTa22qbtzwiLHuBrBswI4dpWBjPK0egTD3nEmCk2r+UWjxXwZVecHCQ?=
 =?us-ascii?Q?HwnxklyGLv6PsIyzMZNBTExFKZN2oeyiyN9hiT1gBuF60n4koFaovTH3kgjE?=
 =?us-ascii?Q?J2/Ue27BFh6u3fUR/XtCyAlP+xvtu+dBDSixC5wXA3kDvHiKyB1s3N7Jr5Lo?=
 =?us-ascii?Q?Rj/Tv+IwN4QaP/YfPVIpvMfCBLzfuTKFfhdFVI6IkkZp2GasrNkk8AWlL98T?=
 =?us-ascii?Q?7d190pRq7vOeCdnTWitctQwzlRPUoOQeX6X3hGb6MkQP+D+PUECGJuEbCUf8?=
 =?us-ascii?Q?QoF4SUGhUcNwnLJTY7R2lB5ZyVDEzO2AoUfmfu9ZyMBhmHC/YkzyWe4ugO2p?=
 =?us-ascii?Q?pFVF2oYL+tnQWuaWkB+7ct3p6H0Z4ifRgwD8AV8Qoey/1UOgLoJBUwbMWeeL?=
 =?us-ascii?Q?Wd/zNP30RuXMXjm96kinELLeEXuBRzIDyTdupWFS53k20veq/U4t8RTdJR8m?=
 =?us-ascii?Q?iFdl0o1U6KIDblOQk5S1x4fd861XW27Nwu1sTrm/sgQsa2BSu7IhUOTbC9HN?=
 =?us-ascii?Q?4TKMeQOTC1DRCoOY3sKqegU3De8MceeysdWm38w0NxlMorETY/Uaq0Zv1nBV?=
 =?us-ascii?Q?P4Dw+gLoldtlBca82RpYONSw7f6V8mRR7b6+EZa6MiEWEdYdc5wPjZbpY4A0?=
 =?us-ascii?Q?+9MaPSE5QLIsSSCQ5Og3OLqImNI79OwUPlUa5V7MT9n/vQEczkwzLkjroxeR?=
 =?us-ascii?Q?MKp6eMT2iZBNHAzY9+vwMcDyHhmfXm/vlex66OY50euHEvncv3OHqiC6jYoc?=
 =?us-ascii?Q?LHyKtF4/OUhiknlO54ydkRi4IZ00uyLOe7ABFFHEIp/B4udDQWmq0eca9EWg?=
 =?us-ascii?Q?N3luGX+mBxK/W+NZxgxTJ8GyuGTQqzb8+DnhftSr8Qb86qV1uSIpEoSVFYoT?=
 =?us-ascii?Q?JfyXnGjtvJoBTSQPhoxBOWtNPlOjMzN23JqfZUBjmi32mzPVnl5LgzDrHByk?=
 =?us-ascii?Q?E1hTNLYY2qvv8b7G5m5piv5VGRtX682gGIf5zvWLYeVUWa0xJWu73yXbp/h5?=
 =?us-ascii?Q?aYlWfZb8MlKOrT7UrSXhXkvpCeHGavwcBrr/0Fw3uCMbhU74tJcIAN+NNiDf?=
 =?us-ascii?Q?6+U0OCdGJ3BOaLFbcTv0JGg=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da7b3af0-7d99-4396-08f7-08db6596d3b0
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 07:31:07.5355
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o9zl/bniuspXNARkD5oaG9S+nIhy7HGppBaMqEq2GMVrkOgGP1aTVnm/tlyIz6Pm/x0P7isJbUVeCCl4eyhscUX3skwrzxHUI5GtARIHAiP3zme3bnvb0hip+oO5CHP4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR01MB6491
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Thu, 1 Jun 2023, Robin Murphy wrote:
> Don't register a resource for the second page unless the dual-page
> extension flag is actually present to say it's valid.
>
> CC: Lorenzo Pieralisi <lpieralisi@kernel.org>
> CC: Hanjun Guo <guohanjun@huawei.com>
> CC: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

Reviewed-and-tested-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>

> ---
>
> Not a critical fix, since the driver currently works around this itself,
> but patch #4 would like to clean that up.
>
> drivers/acpi/arm64/apmt.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/arm64/apmt.c b/drivers/acpi/arm64/apmt.c
> index 8cab69fa5d59..aa7d5c3c0dd8 100644
> --- a/drivers/acpi/arm64/apmt.c
> +++ b/drivers/acpi/arm64/apmt.c
> @@ -35,11 +35,13 @@ static int __init apmt_init_resources(struct resource *res,
>
> 	num_res++;
>
> -	res[num_res].start = node->base_address1;
> -	res[num_res].end = node->base_address1 + SZ_4K - 1;
> -	res[num_res].flags = IORESOURCE_MEM;
> +	if (node->flags & ACPI_APMT_FLAGS_DUAL_PAGE) {
> +		res[num_res].start = node->base_address1;
> +		res[num_res].end = node->base_address1 + SZ_4K - 1;
> +		res[num_res].flags = IORESOURCE_MEM;
>
> -	num_res++;
> +		num_res++;
> +	}
>
> 	if (node->ovflw_irq != 0) {
> 		trigger = (node->ovflw_irq_flags & ACPI_APMT_OVFLW_IRQ_FLAGS_MODE);
> -- 
> 2.39.2.101.g768bb238c484.dirty
>
>