Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 05 Jun 2023 09:21:24 +0200
Message-ID: <87zg5eidcb.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Stefan Binding <sbinding@opensource.cirrus.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        <patches@opensource.cirrus.com>
Subject: Re: [PATCH RESEND v1 2/3] ALSA: hda: cs35l41: Fix endian conversions
In-Reply-To: <20230525135955.2108140-3-sbinding@opensource.cirrus.com>
References: <20230525135955.2108140-1-sbinding@opensource.cirrus.com>
        <20230525135955.2108140-3-sbinding@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 25 May 2023 15:59:54 +0200,
Stefan Binding wrote:
> 
> @@ -379,10 +379,10 @@ static int cs35l41_save_calibration(struct cs35l41_hda *cs35l41)
>  
>  				/* Calibration can only be applied whilst the DSP is not running */
>  				ret = cs35l41_apply_calibration(cs35l41,
> -								cpu_to_be32(cl->calAmbient),
> -								cpu_to_be32(cl->calR),
> -								cpu_to_be32(cl->calStatus),
> -								cpu_to_be32(cl->calR + 1));
> +								(__be32)cpu_to_be32(cl->calAmbient),
> +								(__be32)cpu_to_be32(cl->calR),
> +								(__be32)cpu_to_be32(cl->calStatus),
> +								(__be32)cpu_to_be32(cl->calR + 1));

Do we really need those cast?  Even if yes, it must be with __force
prefix for the endian cast in general.


thanks,

Takashi