Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 09:38:19 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     Mark Brown <broonie@kernel.org>, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com,
        Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: Re: [PATCH net-next v4 4/4] net: stmmac: dwmac-sogfpga: use the lynx
 pcs driver
Message-ID: <ZH2Q6//BSUKl8QbA@corigine.com>
References: <20230601141454.67858-1-maxime.chevallier@bootlin.com>
 <20230601141454.67858-5-maxime.chevallier@bootlin.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230601141454.67858-5-maxime.chevallier@bootlin.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ltdSXf4DfZnAM64g0/lWDG0W2AzsYX+4u0Z+N3KvBchtWt6uJAFLpv7t9355?=
 =?us-ascii?Q?KGXmH8kDdKjrN22H4HkAddnWG7ltqZDEvFNdKgkJOo6RJxID4t2FpbF5Q6fT?=
 =?us-ascii?Q?qHgI9C4qc7Oi/DhNIx6yNvcNiWIaNAPokPdgiDLurRl69nN0T8xw5ZnDJo0I?=
 =?us-ascii?Q?9YEBpUHMXtLEV6JDekt/g1H8b+zg25+PB6orJ7g3dY5B0ab5PNxbSuR/Qphb?=
 =?us-ascii?Q?7fQ5u73Mfy6J5NuwRGg74etwqD0l9K8peD23YXGK9sRS3rx7aXEj+AuGzNCA?=
 =?us-ascii?Q?KVrP0fx2D1IJkQosdRQHhxRtSh7UkAdXNiOCWZMglFHeJBLG5jREDZBCX5PV?=
 =?us-ascii?Q?enXhlV5P+TfYvG0MiDgqTmU1KIHIWLsJCf5ams4Edc6K+2m6rK+EAUh015L5?=
 =?us-ascii?Q?6jUa5iXySik/ffrpkGIyJZk7MNgz2r5PqVCOSiaweKVRGkUZAqfBOjN0Ioj7?=
 =?us-ascii?Q?Z/cCv/fBTelw/+Ah4otC/m6Jlw+AhffetXjLD4LYSJZPP7afpjC1feN3nnLz?=
 =?us-ascii?Q?rB2zPzcPrqv/FN2akr7n6ZrBLkcmIuOR/2ogOme1ExZeARJkVq3Qc0AbwfGh?=
 =?us-ascii?Q?wexcqu69qrRCgyn3Tb2F69cNqzcGbjhzi4X2Kco3DmFq9jX9yBdNx8KwBH5C?=
 =?us-ascii?Q?rLO/LGBY0urVHkTEEbg5Y60P1o98Xg5wIAMgFpa+Z1bPtC1jeWOd7lD9FSVK?=
 =?us-ascii?Q?RpprUjHQuTiHXL8r/+bxsNmbW1MYkLvz65o66QmEt4HAIQDGPYjbRy+3cZ4e?=
 =?us-ascii?Q?JKA6OcpGbqleUNEACF99qBRYH2p03lfl3BETytTHrDeg3Vj3lb2dJOXkgU2w?=
 =?us-ascii?Q?dAbY4kMCrJbIV640leny8Pxy407bmqnz5M7jJO12QH0dqJn+6tel1lhcpVa2?=
 =?us-ascii?Q?N63NZjtfF4F0lhdJPNrvMzG+TcBjETll+pAKPBfYW+8NmNQsHrncV6xqCNKp?=
 =?us-ascii?Q?mCKh85U/RqLTdzl1HlStTBQ/wK52yBF1c3anM3HdgYfgwnMkR6DAgsm2Xgxn?=
 =?us-ascii?Q?DKRmExqgw+7Yq3MivK9cXuIMGKvXeMs/SuY46qingtvNK9mzl1HAecRr7erq?=
 =?us-ascii?Q?qwfUuRvg0ayk+v+X3kRQuupB/G9jYxfVtFfU0PVdK1NdciMQckqDnWzL1HFr?=
 =?us-ascii?Q?d7tgTJmR4bEk8LYB550SP5b7Gkwba9/1uNK2fICyHAyD4Ded+3AUjj6YdNbW?=
 =?us-ascii?Q?5lo59P0VWgJgcd3dnrN0P1siz0za5p10itauPuGH2Dks/lVculh1k1nljc+8?=
 =?us-ascii?Q?HFMDC/qiMw47xkbMR8lxLUMR22Wv1JcoJ7OcaU1h+9xx+twuaQv0cyzpA4iO?=
 =?us-ascii?Q?MLpczCWenQIVT9/Eioqedyts/Fuy6SvHP4Y342H2Fa4Bv1edLEGUjxI2czfI?=
 =?us-ascii?Q?lNlb4OIcvHwg6o+5rj/PMa09XRtXF+EWabbDSmyhZ/v7L27wemowQ9tamR/9?=
 =?us-ascii?Q?N7D74zdnAGebXahCM96AERscSj/xbhQPQGXHe93cbkMnDhQrV4rn710L/kIV?=
 =?us-ascii?Q?AkgRXd6cb7tY6j6t9Oq0Tq2tvG/ZmCotvmECxgNFMSk0LiZdOWJSiND5pFtj?=
 =?us-ascii?Q?bNpfF+feMljKe9iBytVOJT42dEQQKACTEq4DW66f4YwGn0HdjFMKNLpzOJac?=
 =?us-ascii?Q?lBEWehfFaNkae7UzQD7b7r+OVTocKZWswaavmzlLy4MjP3wIjKY88lQ0zl6K?=
 =?us-ascii?Q?f6tnxg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f304ee26-6de0-4e90-c9d6-08db6597d9ed
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 07:38:27.6277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8CNKLePl40oP3iqBibp8CIXcceHkz4077+jOUpYitdyL1o/9ceyVpIdA/4FXb6EWpF3uk6ei2PNLj3LEo2ThNQZrqBHrLA26uyVIeUmj0xw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR13MB6445
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 01, 2023 at 04:14:54PM +0200, Maxime Chevallier wrote:
> dwmac_socfpga re-implements support for the TSE PCS, which is identical
> to the already existing TSE PCS, which in turn is the same as the Lynx
> PCS. Drop the existing TSE re-implemenation and use the Lynx PCS
> instead, relying on the regmap-mdio driver to translate MDIO accesses
> into mmio accesses.
> 
> Add a lynx_pcs reference in the stmmac's internal structure, and use
> .mac_select_pcs() to return the relevant PCS to be used.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>