Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Ashok Raj <ashok.raj@intel.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Ashok Raj <ashok.raj@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Arjan van de Veen <arjan@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Eric Biederman <ebiederm@xmission.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch 4/6] x86/smp: Cure kexec() vs. mwait_play_dead() breakage
In-Reply-To: <ZHwCurlgWM+Q8wCC@a4bf019067fa.jf.intel.com>
References: <20230603193439.502645149@linutronix.de>
 <20230603200459.832650526@linutronix.de>
 <ZHwCurlgWM+Q8wCC@a4bf019067fa.jf.intel.com>
Date:   Mon, 05 Jun 2023 09:41:30 +0200
Message-ID: <87ilc28ifp.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Sat, Jun 03 2023 at 20:19, Ashok Raj wrote:
> On Sat, Jun 03, 2023 at 10:07:01PM +0200, Thomas Gleixner wrote:
>>  
>> +void smp_kick_mwait_play_dead(void);
>> +
>
> This seems like its missing prototype for #else for !CONFIG_SMP
>
>  #else /* !CONFIG_SMP */
> +#define smp_kick_mwait_play_dead(void) { }

Nope. The code which calls this is only compiled when SMP=y