Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 05 Jun 2023 09:47:18 +0200
Message-ID: <87mt1eic55.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     <broonie@kernel.org>
Cc:     Richard Fitzgerald <rf@opensource.cirrus.com>, <tiwai@suse.com>,
        <perex@perex.cz>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: Re: [PATCH v4 00/12] ALSA: hda: Adding support for CS35L56 on HDA systems
In-Reply-To: <87o7luic7c.wl-tiwai@suse.de>
References: <20230601154731.3210572-1-rf@opensource.cirrus.com>
        <87o7luic7c.wl-tiwai@suse.de>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 05 Jun 2023 09:45:59 +0200,
Takashi Iwai wrote:
> 
> On Thu, 01 Jun 2023 17:47:19 +0200,
> Richard Fitzgerald wrote:
> > 
> > This set of patches adds support for using the CS35L56 boosted smart
> > amplifier on HDA systems. In these systems the CS35L56 audio is
> > routed through a HDA-to-I2S bridge codec.
> > 
> > This doesn't include the changes to the Realtek driver to actually hook
> > up the CS35L56 driver, because we don't yet have the QUIRK IDs to
> > associate it with. But we want to publish the driver now so that it is
> > available for bringing up hardware with the CS35L56.
> > 
> > The first 9 patches are moving code out of the ASoC driver and into the
> > shared library so that it can be shared with the HDA driver.
> > 
> > Patch #10 fixes missing #includes in the HDA headers so that the CS35L56
> > driver doesn't have to #include headers that it doesn't use.
> > 
> > Finally, #11 and #12 actually add the support for CS35L56 on HDA.
> > 
> > CHANGES SINCE V3
> > Patch 01:
> > - Fix double-free of IRQ caused by passing wrong cookie to devm_irq_free()
> > Patch 12:
> > - Fix memory leak of struct firmware object and firmware name strings.
> > - Find and open firmware files before taking the irq_lock mutex and pm_runtime.
> > - Don't bother executing the firmware loading code if no firmware files were
> >   found.
> > 
> > Richard Fitzgerald (4):
> >   ASoC: cs35l56: Move runtime suspend/resume to shared library
> >   ASoC: cs35l56: Move cs_dsp init into shared library
> >   ASoC: cs35l56: Move part of cs35l56_init() to shared library
> >   ALSA: hda: Fix missing header dependencies
> > 
> > Simon Trimmer (8):
> >   ASoC: cs35l56: Move shared data into a common data structure
> >   ASoC: cs35l56: Make cs35l56_system_reset() code more generic
> >   ASoC: cs35l56: Convert utility functions to use common data structure
> >   ASoC: cs35l56: Move utility functions to shared file
> >   ASoC: cs35l56: Make common function for control port wait
> >   ASoC: cs35l56: Make a common function to shutdown the DSP
> >   ALSA: hda: Add mute_hook to hda_component
> >   ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier
> 
> It'd be likely easier to merge all those via ASoC tree, I suppose, as
> some patches seem to have prerequisite in the recent ASoC changes.
> So, Mark, could you take those through yours?
> 
> Feel free to put my ack:
> 
> Reviewed-by: Takashi Iwai <tiwai@suse.de>

Oh, and after you merge them, please send a PR to sound.git tree,
too.  This will make our lives easier, as there will be other
conflicting changes for HD-audio component for TAS codecs, too.


thanks,

Takashi