Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Mika =?utf-8?Q?Penttil=C3=A4?= <mika.penttila@mbosol.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     x86@kernel.org, Ashok Raj <ashok.raj@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Arjan van de Veen <arjan@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Eric Biederman <ebiederm@xmission.com>
Subject: Re: [patch 5/6] x86/smp: Split sending INIT IPI out into a helper
 function
In-Reply-To: <b9cef72f-0bcf-5bd6-e828-f11bd822fe33@mbosol.com>
References: <20230603193439.502645149@linutronix.de>
 <20230603200459.889612295@linutronix.de>
 <b9cef72f-0bcf-5bd6-e828-f11bd822fe33@mbosol.com>
Date:   Mon, 05 Jun 2023 09:54:54 +0200
Message-ID: <87fs768htd.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Jun 04 2023 at 07:02, Mika Penttil=C3=A4 wrote:
> On 3.6.2023 23.07, Thomas Gleixner wrote:
>> +/*
>> + * Wake up AP by INIT, INIT, STARTUP sequence.
>> + */
>> +static int wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long=
 start_eip)
>> +{
>> +	unsigned long send_status =3D 0, accept_status =3D 0;
>> +	int maxlvt, num_starts, j;
>> +
>> +	preempt_disable();
>
> This seems like an unbalanced preempt disable..

Right. I screwed up a rebase completely....