Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <511269ce-2493-1d21-d8fe-a9d78828e018@collabora.com>
Date:   Mon, 5 Jun 2023 11:45:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH] arm64: dts: mediatek: mt8192: Add missing dma-ranges to
 soc node
Content-Language: en-US
To:     =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= 
        <nfraprado@collabora.com>,
        Matthias Brugger <matthias.bgg@gmail.com>
Cc:     kernel@collabora.com, Yong Wu <yong.wu@mediatek.com>,
        Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org
References: <20230601203221.3675915-1-nfraprado@collabora.com>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20230601203221.3675915-1-nfraprado@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Il 01/06/23 22:32, Nícolas F. R. A. Prado ha scritto:
> In the series "Adjust the dma-ranges for MTK IOMMU", the mtk-iommu
> driver was adapted to separate the iova range based on the larb used,
> and a dma-ranges property was added to the soc node in the devicetree of
> the affected SoCs allowing the whole 16GB iova range to be used. Except
> that for mt8192, there was no patch adding dma-ranges.
> 
> Add the missing dma-ranges property to the soc node like was done for
> mt8195 and mt8186. This fixes the usage of the vcodec, which would
> otherwise trigger iommu faults.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 
> ---
> Matthias,
> 
> this is a very simple but important fix for the vcodec functionality.
> Since the vcodec node for mt8192 was just merged, can we please get this
> in in this merge window as well?

+1

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> 
> Thanks,
> Nícolas
> 
>   arch/arm64/boot/dts/mediatek/mt8192.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 7ff183c35494..a3612de8e9d1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -401,6 +401,7 @@ soc {
>   		#address-cells = <2>;
>   		#size-cells = <2>;
>   		compatible = "simple-bus";
> +		dma-ranges = <0x0 0x0 0x0 0x0 0x4 0x0>;
>   		ranges;
>   
>   		gic: interrupt-controller@c000000 {