Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <578088ff-9feb-3d03-f12e-577f105144f5@linaro.org>
Date:   Mon, 5 Jun 2023 12:13:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: Add nvmem-clock
To:     Mike Looijmans <mike.looijmans@topic.nl>,
        devicetree@vger.kernel.org, linux-clk@vger.kernel.org
Cc:     Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>, linux-kernel@vger.kernel.org
References: <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.2167d5ad-7e99-4eb9-a313-030fc7a7d546@emailsignatures365.codetwo.com>
 <20230526143807.10164-1-mike.looijmans@topic.nl>
 <c6d886d9-8f74-7af3-5478-030f5d6e4b1c@linaro.org>
 <ae4e2041-9fd7-30e7-8c0a-22a423c5871e@topic.nl>
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <ae4e2041-9fd7-30e7-8c0a-22a423c5871e@topic.nl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/06/2023 12:01, Mike Looijmans wrote:
> On 31-05-2023 21:27, Krzysztof Kozlowski wrote:
>> On 26/05/2023 16:38, Mike Looijmans wrote:
>>> Add bindings for a fixed-rate clock that retrieves its rate from an
>>> NVMEM provider. This allows to store clock settings in EEPROM or EFUSE
>>> or similar device.
>>>
>>> Component shortages lead to boards being shipped with different clock
>>> crystals, based on what was available at the time. The clock frequency
>>> was written to EEPROM at production time. Systems can adapt to a wide
>>> range of input frequencies using the clock framework, but this required
>>> us to patch the devicetree at runtime or use some custom driver. This
>>> provides a more generic solution.
>> This does not look like real hardware. I mean, the clock does not fetch
>> its rate from nvmem, right? It's the Linux which does it, so basically
>> you described here driver, not hardware.
> Right, this just reads a setting from an NVMEM provider.
>> Extend existing fixed-clock bindings to allow reading frequency via
>> nvmem cells.
> 
> I just tried and implemented this, but it does not work. The reason is 
> that the fixed-clock implementation returns "void" in its 
> of_fixed_clk_setup() init function. The nvmem provider returns 
> EPROBE_DEFER because it isn't ready at this early stage, and this error 
> will not be propagated up because of the "void" signature. Thus, it's 
> never retried and the clock just disappears.

Linux driver problems are not a reason to add bindings for virtual
hardware...

Best regards,
Krzysztof