Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5455477rwd; Mon, 5 Jun 2023 04:05:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ62SrJdnDGbnGxIKs12cpXyrHEzphZER0gq0LA88+XKGKIrwh6b8cngHWt6Ch4QuJremaaz X-Received: by 2002:a05:6a20:2699:b0:111:997d:d215 with SMTP id h25-20020a056a20269900b00111997dd215mr2313536pze.8.1685963148079; Mon, 05 Jun 2023 04:05:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685963148; cv=none; d=google.com; s=arc-20160816; b=HS7YKEMP19q17VAupHdYlbALaS9khhznX+VzmWGxiEn6LRXAsUsZ5KCv+9l0axkgju 8N5CoTaBjOk9W+7tZHMdNmxB7QbFWsLBxEANv8EjjgHFATRdJyLULA1v54HvF0ORRvDs 4fIAyUwpPoogVupj7e2JiC/jkFiuPIBknFLBe0RNNFvLWCHYvq65PthCKnV1mNQgwAmO vNrUROp1D0NLVmuJ/lcZzx+0sCLzvogcdzPQ5UW5TvJ80cjkHuaDEefiS47UcdC0TngE rIf56Aoj1ax/HQImMST6hyLDBaeRenUzBDpobIWPEzzBBIxCss4LFIHg5lmUFZyciQMz cr2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=qqiLrEBhcKuSP2j4ToE3vVSgoa3aH4PehYYjuYthuUQ=; b=Xe+JFTM4fI/kg9BrYBFHHaInKPZxdvlwbZs/+7UelILn/Q6u4KQiYp9/+PtLDag2cb QDuybXLvO6NomNz1d+QbLjS4dHRweyD2vzSsGqWHPupK5jCRGjUR2gXRXxxt/QzOnsPB ZSGzx1JqD/Cx1T8EGKkVKnyIBouc4DJyoLumlWTU9HFBKtDpig4Htiq4okuR436zv1BA fdkXdREhS+ErDmoVIqN+RzFfOxqO5BvOwQPs20D8vtAuRYUW3LA4V/UWBJRg+4sCLkbt tSTCcYHn2II7hHc63wTQO/t2rTdlNVHJh7s/Ld7wXyH/FuXVbvqlQISsv5ixPfCiE3Y5 qK0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t+5Ho53u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v16-20020a63d550000000b0053084a794f0si5159607pgi.290.2023.06.05.04.05.23; Mon, 05 Jun 2023 04:05:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t+5Ho53u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230030AbjFEKkY (ORCPT + 99 others); Mon, 5 Jun 2023 06:40:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229659AbjFEKkX (ORCPT ); Mon, 5 Jun 2023 06:40:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79668A6 for ; Mon, 5 Jun 2023 03:40:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1316C6227D for ; Mon, 5 Jun 2023 10:40:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 63101C4339B; Mon, 5 Jun 2023 10:40:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685961620; bh=J9L9ZgxC2Kly/z+obdv2lAt35t36sXkamU/X8cpUyCI=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=t+5Ho53un0fNOIbSg7XaYfL51mL3yUz/msTZuvobC84aH8eUw//S05cXB+WF4UjDt M4rw6Rtil0b5kYXs6jRFjLRJX7zsslKkK0Hfaan4o/e7s+zHczWTtM/7KMz5H9/rpY bQCOVHy9kqAc9iXPV9W5mot9Rt5tyYP3TnhAoDCXfp/lvp9XNqozOhaLKol4D2E9n3 CTsd48WeKP+zbYOHllTf+In//gcztCmykq3TUy4fWPeFe/5qI/VZINPAK8pMcD9eXo /UsBOTMYsjKtl3fTZ3TwipKExJldDdA5phMRlF+Evhz/+yVio9gbrcw/QkxNBrAPo7 M9k0lBLxOD6gA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 4C6A0E8723C; Mon, 5 Jun 2023 10:40:20 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] net: stmmac: dwmac-qcom-ethqos: fix a regression on EMAC < 3 From: patchwork-bot+netdevbpf@kernel.org Message-Id: <168596162030.847.18206193816609441964.git-patchwork-notify@kernel.org> Date: Mon, 05 Jun 2023 10:40:20 +0000 References: <20230602190455.3123018-1-brgl@bgdev.pl> In-Reply-To: <20230602190455.3123018-1-brgl@bgdev.pl> To: Bartosz Golaszewski Cc: vkoul@kernel.org, bhupesh.sharma@linaro.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, ahalaney@redhat.com, jesse.brandeburg@intel.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bartosz.golaszewski@linaro.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Fri, 2 Jun 2023 21:04:55 +0200 you wrote: > From: Bartosz Golaszewski > > We must not assign plat_dat->dwmac4_addrs unconditionally as for > structures which don't set them, this will result in the core driver > using zeroes everywhere and breaking the driver for older HW. On EMAC < 2 > the address should remain NULL. > > [...] Here is the summary with links: - [net] net: stmmac: dwmac-qcom-ethqos: fix a regression on EMAC < 3 https://git.kernel.org/netdev/net/c/9bc009734774 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html