Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5513418rwd; Mon, 5 Jun 2023 05:00:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4kmSbkxaE82xug7A6vnA/etE74rZocPBLN22xBKjTQtXRRXkSfs2+bHRtyWLHP1m1/lRqw X-Received: by 2002:a05:6a20:3d05:b0:111:366:eea4 with SMTP id y5-20020a056a203d0500b001110366eea4mr8950472pzi.57.1685966439610; Mon, 05 Jun 2023 05:00:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685966439; cv=none; d=google.com; s=arc-20160816; b=uH0l0XcSdnO5+88iALGepK0WFqm4QmLzPtRhibxhhu9QK8XxbAd0ysctpYchpX+kZd iWm7Cf8lwANXcWoZ3dT/+BqJ6inRLIOZ+9pFLq4xfm4tovJWZOZqhGIY2t3aTTCFwrad Quj49hbiVcpf5guG5tqMWJwOjKAuUPpa38SpdzTxhF6HNXIhkZhQTI2nSeqMB0xDa/yY BhaMSg2Ps9oymQ5luVexeNqnYIJWLUt1UQ2DjV8HalBEcwsJoSodLJpNSH/oeIXcjsdG 97oK78dGDaT4e01PNkyKkNlG76BOtu4H/zlxDga0a0l125+U6zYMS5roaskXylwhzlrV aauA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=z90FTuZzOl3bgftssgaRSleKVaxL49veAboJ9XbQ5tI=; b=H8FzDTsOZ+YDth6sEDdW71rlRMq6nRYQzzr3gjciv4AH+ifgi9p0a3wsrLLQAM7slT bWdtjYWyJPyE7ilLvHhTmqLyMI7Zn24PvgpJUGrt6n5cWpikIbcv+ldGx16etSh6Q8z9 SDqDByMmzqUW7tgClVwaVOuAyh9ZeA8SwvD1Axf56/wiFfP2w9vmQsis4IUCa3zKnx+C I18RiEvwowRBAimkVKTql4mDVoagjQOVurptvBiFcKU4uHWFw1ceTyPzwF+KLcWBsHDA k04H+hkUJgyNuq0MZMygSzFmmrCNTsRSCIkRa1zllaMhFfhRIAImp+fqjhSTmhvGXcmO EtTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=awIf2YtJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a63d809000000b005343e03b044si5405028pgh.697.2023.06.05.05.00.21; Mon, 05 Jun 2023 05:00:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=awIf2YtJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232416AbjFELzR (ORCPT + 99 others); Mon, 5 Jun 2023 07:55:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232607AbjFELzQ (ORCPT ); Mon, 5 Jun 2023 07:55:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15D39DA; Mon, 5 Jun 2023 04:55:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9AD4F6230C; Mon, 5 Jun 2023 11:55:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65681C4339B; Mon, 5 Jun 2023 11:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685966114; bh=pUSC7oks7piN2gzMx4OqaEMjAcj/eQArd7w290LuOq4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=awIf2YtJkTEPkmDuvdcNoLdI2TUe2b+rwXUgF6JOEhN9dPsxR1nzPOUfEgasv7hXt Pt9PNG9LzJGeDxAVqq9cSp2Q4D5eZTdoFtYXs8r+WaIKFCFJHsXOw3LEzsOA5ljfBI NHApRg+D8Mi0sd06fz2D1iys9KuFD3m9lCoPG/i2HGv4aoztO6W6yZO6jkVNtAd2ny MUzSxdfgfigMWahl7Yoh5nSze7VD06AFB9O1H6dPSHsrnEK14qcmu0NY/zD3WENXky CVxpHhHbJpOIU3CiqYlpNcQ70wNOb9CH/odTk5olviBlB5M0u6usf9bopYLFl/wt81 z+FLaZGZbTuSQ== From: Christian Brauner To: "Fabio M. De Francesco" Cc: Christian Brauner , Al Viro , Andrew Morton , Dave Chinner , Chen Zhongjin , "Matthew Wilcox (Oracle)" , Alexander Potapenko , Andrey Konovalov , Bagas Sanjaya , Jiaqi Yan , Tony Luck , Peter Collingbourne , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] highmem: Rename put_and_unmap_page() to unmap_and_put_page() Date: Mon, 5 Jun 2023 13:53:58 +0200 Message-Id: <20230605-brombeeren-pelle-4c3b79161688@brauner> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230602103307.5637-1-fmdefrancesco@gmail.com> References: <20230602103307.5637-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1082; i=brauner@kernel.org; h=from:subject:message-id; bh=jKeD4wVOOupEPtRNzJJqOCLPd5qFAlNPBImFod19/MQ=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaTUnjlvdCyvjDvpSWaTesoNhuP75+mdnc8+wThpT5J944xO k9otHaUsDGJcDLJiiiwO7Sbhcst5KjYbZWrAzGFlAhnCwMUpABMRPsjwP2NZeu6aivR3307/k2Od8f aV2I+b6iLvLe/JzZV7Y7uAjZHhf73E+7VVa1qi/Cy44y9o7rv10T59fdy2/5P2HZzeE5/XzQwA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 02 Jun 2023 12:33:07 +0200, Fabio M. De Francesco wrote: > With commit 849ad04cf562a ("new helper: put_and_unmap_page()"), Al Viro > introduced the put_and_unmap_page() to use in those many places where we > have a common pattern consisting of calls to kunmap_local() + > put_page(). > > Obviously, first we unmap and then we put pages. Instead, the original > name of this helper seems to imply that we first put and then unmap. > > [...] Grabbed it now. Please yell if this wants to go another route. --- Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] highmem: Rename put_and_unmap_page() to unmap_and_put_page() https://git.kernel.org/vfs/vfs/c/01af7e7dd0ea