Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <63e2c1bc-4a80-4857-899a-dd87d92c6f7e@foss.st.com>
Date:   Mon, 5 Jun 2023 14:08:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] serial: st-asc: fix typo in property name
Content-Language: en-US
To:     Raphael Gallais-Pou <rgallaispou@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230604083558.16661-1-rgallaispou@gmail.com>
From:   Patrice CHOTARD <patrice.chotard@foss.st.com>
In-Reply-To: <20230604083558.16661-1-rgallaispou@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Raphael

On 6/4/23 10:35, Raphael Gallais-Pou wrote:
> Changes the property name read in the driver according to the YAML.
> According to device-tree documentation, property names should not
> include underscores.
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
>  drivers/tty/serial/st-asc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index 5215e6910f68..6ef99a037a9b 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -754,7 +754,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev)
>  
>  	asc_ports[id].hw_flow_control = of_property_read_bool(np,
>  							"uart-has-rtscts");
> -	asc_ports[id].force_m1 =  of_property_read_bool(np, "st,force_m1");
> +	asc_ports[id].force_m1 =  of_property_read_bool(np, "st,force-m1");
>  	asc_ports[id].port.line = id;
>  	asc_ports[id].rts = NULL;
>  

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice