Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 13:16:33 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Raag Jadav <raagjadav@gmail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: act8945a: rely on hardware for operating
 mode
Message-ID: <04b8fa24-e5a8-4871-a397-f1c0c886449a@sirena.org.uk>
References: <20230605104830.68552-1-raagjadav@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="0oO7Zo9cWYTLbwt+"
Content-Disposition: inline
In-Reply-To: <20230605104830.68552-1-raagjadav@gmail.com>
Precedence: bulk


--0oO7Zo9cWYTLbwt+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 05, 2023 at 04:18:29PM +0530, Raag Jadav wrote:

> Convert ->get_mode() and ->set_mode() hooks to read/write operating mode
> from/to hardware instead of relying on driver memory.

Why is this change being made - what is the benefit here?

> While at it, map fixed-frequency PWM regulators to REGULATOR_MODE_FAST.

Don't combine multiple changes into a single patch, this just makes
everything harder to review.

--0oO7Zo9cWYTLbwt+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmR90iAACgkQJNaLcl1U
h9A6kwf+OqMF+3d7LmP0EcpT8N5evUuexunsk7rR2aHeOHqL4VK4TX+gG4lkmBHM
4PYtqrL5KkEaY10yAa6VCksusLeO7fHiErCPgBM4OdzEzGB4hAHIIt9L5dvEv8jK
F+x++v7bOi/MVA+dLP2IcPKTwlCCx9aHwTJfcelH6NmZ3fmbJCj+JyP/tYeAWJkw
iTccVIB9fJhu3Cqk8MK+0Dwd+ToSFxGL2qEaqpoNk9opDzMemHC01JjixJmDVTJd
HCGBkbtz44Jw3jwwKjuFXspbtKt53EmtbVbpMwnPIjFKMdtAx+D7mj1Rxve/uPLf
z7eOIcUhDqyyK0wCHpNFe3JQwR6J7g==
=ReKK
-----END PGP SIGNATURE-----

--0oO7Zo9cWYTLbwt+--