Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Xin Li <xin3.li@intel.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org, kvm@vger.kernel.org
Cc:     mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, peterz@infradead.org, andrew.cooper3@citrix.com,
        seanjc@google.com, pbonzini@redhat.com, ravi.v.shankar@intel.com,
        jiangshanlai@gmail.com, shan.kang@intel.com
Subject: Re: [PATCH v8 02/33] x86/fred: make unions for the cs and ss fields
 in struct pt_regs
In-Reply-To: <20230410081438.1750-3-xin3.li@intel.com>
References: <20230410081438.1750-1-xin3.li@intel.com>
 <20230410081438.1750-3-xin3.li@intel.com>
Date:   Mon, 05 Jun 2023 14:07:48 +0200
Message-ID: <87o7lu6rjf.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Mon, Apr 10 2023 at 01:14, Xin Li wrote:
> +	union {
> +		unsigned long  csx;	/* cs extended: CS + any fields above it */
> +		struct __attribute__((__packed__)) {
> +			unsigned short cs;	/* CS selector proper */
> +			unsigned int current_stack_level: 2;
> +			unsigned int __csx_resv1	: 6;
> +			unsigned int interrupt_shadowed	: 1;
> +			unsigned int software_initiated	: 1;
> +			unsigned int __csx_resv2	: 2;
> +			unsigned int nmi		: 1;
> +			unsigned int __csx_resv3	: 3;
> +			unsigned int __csx_resv4	: 32;
> +		};
> +	};
>  	unsigned long flags;
>  	unsigned long sp;
> -	unsigned long ss;
> +	union {
> +		unsigned long  ssx;	/* ss extended: SS + any fields above it */
> +		struct __attribute__((__packed__)) {
> +			unsigned short ss;	/* SS selector proper */
> +			unsigned int __ssx_resv1	: 16;
> +			unsigned int vector		: 8;
> +			unsigned int __ssx_resv2	: 8;
> +			unsigned int type		: 4;
> +			unsigned int __ssx_resv3	: 4;
> +			unsigned int enclv		: 1;
> +			unsigned int long_mode		: 1;
> +			unsigned int nested		: 1;
> +			unsigned int __ssx_resv4	: 1;
> +			unsigned int instr_len		: 4;
> +		};
> +	};

This does not match section

    5.2.1 Saving Information on the Regular Stack?

of version 4 and later of the specification.

Thanks,

        tglx