Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 14:16:18 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     Jaco Kroon <jaco@uls.co.za>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/pppoe: fix a typo for the PPPOE_HASH_BITS_1
 definition
Message-ID: <ZH3SEl7ZT+MBI7V0@corigine.com>
References: <20230605072743.11247-1-lukas.bulwahn@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230605072743.11247-1-lukas.bulwahn@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZJJED86+VRYbCQZDeVAvjNxrXYQAQW0fLva8NzRKEIQOg23CGmpn1vCgkgvn?=
 =?us-ascii?Q?1osk+MWADcWNMNY0iqDEa9g8i3csfWYry+fneOncFhQ+8VEwlHYEL5xOM+Kc?=
 =?us-ascii?Q?qRb47t4uXOG5aC11ceh3JYQNZ8WuOlCpkw+4xynkPzArgO2jpkbjQhj3DK27?=
 =?us-ascii?Q?ia2qrSIQ/QO4vuQqQTjBugdfN1EzuRA54KLr/uuZrNVA2NlhJ3ezx9xQMujk?=
 =?us-ascii?Q?3xn8P9R0IXBP2YuXUKY7CBvTt4/z/Q05+jyzJBoCDRbUlCnLQzTOTtirRLsp?=
 =?us-ascii?Q?IoLjSRIEp1E/XtrcI3CNhhr202mpIgu7xo7v8/dgaId3F3xbZR0rnuoby7c3?=
 =?us-ascii?Q?1kUMwFHU+ofplvJSqDmXvnCwbdxUPgx5C1P9JvF1VW50K/JQoyCXbPg0yATx?=
 =?us-ascii?Q?bAvvvMYUNzfYjSV679zd3ClX+WdNYEniDaeX2U/3ucg84z3L3pYtz1c+DNTT?=
 =?us-ascii?Q?oLo2He+9DqdFv3Cjr3pWquMsALtxwuRb3BJjmwDZHiVVTZnz85jJI0krp8Z3?=
 =?us-ascii?Q?WMq79u2OoDK2ONKXqS1A+gJXOzgbCMx8p7EASUlY7ny2TuuD3REl20LN0J6z?=
 =?us-ascii?Q?TcdXnSS/bod2yJfazHtzcviLTfNCu50GHIZYcjcrDQnS7RieZu0Zn1uhaSEz?=
 =?us-ascii?Q?GB/8p4tt+UF2i6TCKvWVOTOF76L4Dzk/Hxz641aXkpYIh5J4RMVkvd7bwM7R?=
 =?us-ascii?Q?7U6xPpi1aIwYTH+OJXIfFw5SrtuSq0whcgMXtVg5LiSBEQPqJXtmBQaFuw+f?=
 =?us-ascii?Q?uNseHceOhi28xUqcyi3J0YbaUgIFg708mYNMXWRp5nLF+L8zbLref4JkoAv0?=
 =?us-ascii?Q?EEqZu5DJjK3faweMT+LuZTv1JLltNG7MCOBSwN5VN2T/15pKwvW6Cw1yeWh+?=
 =?us-ascii?Q?TNNuhEPQTJPShRCd4Q3K9Ge883tavwyvCWBctBu+xmYk59HsrKkmUIUp/wry?=
 =?us-ascii?Q?vh+asB0IFqdFrkHhGObWgzoKnvVxws9RJqT0CMMpYny9SKDe3LJ0QCX7AVFx?=
 =?us-ascii?Q?JUgDBK8bRQ4/lbaiTt3X6C6+ad0UNjz5egnrZdAJwxFyOeI7dQy62OybBMqt?=
 =?us-ascii?Q?Tn8c3qFaHJwXayza/of+ww3SjLORCRsGECQxt3gvqRTgLh+cCurcnkYxakDA?=
 =?us-ascii?Q?+QhoJocw5uSXN8EUbusWMA8YcEn8SnEHM/gE9ENSiuBIHJU/tM7+olr16QKO?=
 =?us-ascii?Q?AB58lttz01CjJsX0obj8/vye1D7b4dyzAqs3YWfMlNUodqYyFDCJGMSd5/n0?=
 =?us-ascii?Q?IJJL0NqRcjWTFpZP85ePHgJp8BYW9FuENwlHMwgb4DwqZwtx8peZZCrucY2V?=
 =?us-ascii?Q?1DUbl/UlUkw8w0EYU5C4o96GT7QgnHGQd/xIdHP7RJvWXczKhg6Ke73v6ZqA?=
 =?us-ascii?Q?JAcifCrhrO8lgy/of0Uo1uPn7OdOSata9oPm5GUmLUFh6rcFbvYidHyMO8vR?=
 =?us-ascii?Q?AWVBneTyeIiElmDfa/98cii0M8tyx1wjPsK1hsnbJjzP9GJLr0RYQEnt7O6w?=
 =?us-ascii?Q?KBSt4DTLIvBVqhh0gQUyiftd9+PGgrExpkVvs6nCXVLmguD6FYbrop4/tubj?=
 =?us-ascii?Q?EZI0txxp7fHvTUDIceKrhvNoBDwqd8NbS5uFvjqegYbQHAife5jy9dKm7nVF?=
 =?us-ascii?Q?ZYxpcYJExgdcsGeudr43BF6TlVWLC482VKrFLYdZB99xXOdJ+pChM7J5a5HF?=
 =?us-ascii?Q?OHUnww=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bdcac3d-e755-4473-684b-08db65beae1e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 12:16:24.5590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uLZD2uBY8XNvqj4HgJbmibkKx9gnv5BIF8J37RYSh4AzcRTymvneKGz2s23lQMh60tdf7i3wPqC5w8/nsG81mrtSL8R/ek/YCF4CMaGOMUM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3833
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 05, 2023 at 09:27:43AM +0200, Lukas Bulwahn wrote:
> Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0
> ("net/pppoe: make number of hash bits configurable") actually defined
> config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick
> typo with the numbers.
> 
> Fix the typo and define PPPOE_HASH_BITS_1.
> 
> Fixes: 96ba44c637b0 ("net/pppoe: make number of hash bits configurable")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>