Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 14:31:10 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Hangyu Hua <hbh25y@gmail.com>
Cc:     jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: sched: fix possible refcount leak in
 tc_chain_tmplt_add()
Message-ID: <ZH3Vju3D3KCKAkCO@corigine.com>
References: <20230605070158.48403-1-hbh25y@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230605070158.48403-1-hbh25y@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ftx7E8j6wPNRXQubYYf2d0ZrYRGfE0vwQnsuXV7bI5sLxOh9k8xUdKt8p+Jc?=
 =?us-ascii?Q?sNzHb5mJFPRGG/wKF0qmvq3duGf/0/s4T05lw+ihsMp0cnSoMeXXzyy52z7F?=
 =?us-ascii?Q?k2JpwkZx6m7QVyT0EIJWnxnEdWfJ5U4HgbEXY7/8h+FrP+WaUL364holPCFS?=
 =?us-ascii?Q?Ob4/1NnlvwE8EsF8YIfSnajakpP3QUk28LHzE1QGMo8ewgx/XPStSFkIetk6?=
 =?us-ascii?Q?V2IHgLWsPSlwFCdlpDUNgbVauaGy+9iK/AWMCfTDfJPaW2kJta4ZY6cM3aek?=
 =?us-ascii?Q?7QncwGlKP2jnw31MYUBesDlFPwmRR7tI/uS0jY3QrxwhaVnIGD3ahgCyLcH3?=
 =?us-ascii?Q?mDhUcmSYhRsRd81LwrcrE09dTVuxb1zUVZo1dH324vq9FUf4NNzfYpn9oVz0?=
 =?us-ascii?Q?0TP4jaQvFmPfEdqDhsqu4+an5xSfnqShSU1RPBJX52NZPeQz7g/q7A3WzGlO?=
 =?us-ascii?Q?6tj6xgF4YothDPAGiiS+JuHnptUqibcAOmHdnOgiIKGgF3AatQ1FeJrNg2NO?=
 =?us-ascii?Q?W2DPj3+CkRnId4S9e+mm8ZnGV7lJ8EtOvhofuv7rYXppB7Fs/Ad44NZIvqj6?=
 =?us-ascii?Q?O6xh52hNcw+FqYvawLFV5oBZbP/d2fKo3nxyZv0wkc+XVPvTOp0A+7cQ9f8y?=
 =?us-ascii?Q?qi4TXnmEm+6gmGZ8uHk5D3z1TcuuB2KvZLgQnGXV+vMim82e5nBEgklccLJA?=
 =?us-ascii?Q?wZDA+Dk9TImOFuTCVqIDNv6Z6hf5LlA69YjeVj2x579LyeBdXx/0nU6spwoQ?=
 =?us-ascii?Q?nKwMbvpN5G8T2RdHO6Ggn+k86xLvv7Xb4HKlksBJ7eBTtalfiyOUreGShN74?=
 =?us-ascii?Q?8G/RakAze4965Lm5EQ7XtjSuwZGqIlYW5nH8zwRx/m7nsZW4P9huzkehCvXN?=
 =?us-ascii?Q?5ngh8wY1ZaKAZnAf+0Br0zBr6i3GYje/SHh3Xb35IXFeKOYWPl+H6e4BrjlG?=
 =?us-ascii?Q?S1uvj39PsN0lHGgPnABtdc1Y1JNHuVgsbYfpcMuxhl7RQ2WYfG+efU1gyIMz?=
 =?us-ascii?Q?342ge+beusTJsiLEQkutptbyKi5EiM1Kj25qmnXWE+kIxJS4+pMQXRYwmz98?=
 =?us-ascii?Q?Z6FDaXrZX25yBcm2Vn1gG9BsN0d5LJ/94F6A1WXgtEjJevnwgApK4gbDHB55?=
 =?us-ascii?Q?k6BauE2meZBwrqf/R3jtLkhTPOPxCFmLh8IoJIiTkYEgplT0loenjMC88Fne?=
 =?us-ascii?Q?Vp39ETHOk/Tde1wUTy18Zo3ne/DvPXlymfVEbnUo8saXw9vmZNQIbBafGsjx?=
 =?us-ascii?Q?OmOGHeKIpIDIg9shb/DROO7YVfz5BM/FM89yv764RHe2Uhfz+u5jdeSKRVWf?=
 =?us-ascii?Q?TphZd4XELNjqMiMCRhMgLoA6qq1b3dKDkvHDX7fp4L0GWS7WMOUKm9r8GIBu?=
 =?us-ascii?Q?0PWq+XUqia1UmUwm0j7kGeUB1rUReLhDK6nlym3zmIXyb3z/KVpw8uDwZBRs?=
 =?us-ascii?Q?5nscUS1hXQ36REniv3AmmJ3mPjI2juMpODeaNdNpZR3ONLQcbBxT3ii7+cYa?=
 =?us-ascii?Q?5GnTPSTb1uGo8vDqByDP90sAWfCn9ZipriZ0ls91YeRTbG4hwtB6hUrGdQr2?=
 =?us-ascii?Q?tsyHF14li5fL+F766CHqsTVVd8npeJB66VxZW/2lV+5B9SuT1pIZxzq3y/7N?=
 =?us-ascii?Q?8dVmy1Jy+sSsaRkShFgqs4l/jWdYpk9a9irbagRZTT9v/zLXgAxsy6+30Lje?=
 =?us-ascii?Q?N0WfdA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6935f668-0e19-4874-84e3-08db65c0c230
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 12:31:17.1282
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A7Ukbg8pV9xGlP0Rpo3rVvzBMj1y/Op2HLYMKyxpmGU0Ntsw9e9H8mEHNTMiJDDFL8KFp/gdKnjBWO7qjf9W9UZmIU5LF29dElzQqc04RkI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR13MB4994
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 05, 2023 at 03:01:58PM +0800, Hangyu Hua wrote:
> try_module_get can be called in tcf_proto_lookup_ops. So if ops don't
> implement the corresponding function we should call module_put to drop
> the refcount.

Hi Hangyu Hua,

Is this correct even if try_module_get() is
not called via tcf_proto_lookup_ops() ?

> Fixes: 9f407f1768d3 ("net: sched: introduce chain templates")
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
>  net/sched/cls_api.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index 2621550bfddc..92bfb892e638 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -2952,6 +2952,7 @@ static int tc_chain_tmplt_add(struct tcf_chain *chain, struct net *net,
>  		return PTR_ERR(ops);
>  	if (!ops->tmplt_create || !ops->tmplt_destroy || !ops->tmplt_dump) {
>  		NL_SET_ERR_MSG(extack, "Chain templates are not supported with specified classifier");
> +		module_put(ops->owner);
>  		return -EOPNOTSUPP;
>  	}
>  
> -- 
> 2.34.1
> 
>