Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 15:50:42 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
        Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
        Peilin Ye <yepeilin.cs@gmail.com>,
        Pedro Tammela <pctammela@mojatatu.com>
Subject: Re: [PATCH RESEND net-next 0/5] Improve the taprio qdisc's
 relationship with its children
Message-ID: <20230605125042.lx6ng5jcsxp625ep@skbuf>
References: <20230602103750.2290132-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230602103750.2290132-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZyasNJfnddlkqMtmmjQtzSZlK4M4212Prff2/AyeANtyHeGiVR6DaZP60L9d?=
 =?us-ascii?Q?VzOOd1y/Jl+uNhevSRfz3pyVSIp2u9uUsk4exeUDD4EGnoeiY9z35VgWFPd5?=
 =?us-ascii?Q?DlMzL4hDj5pIKPZSd/le11/4bpFGol52iT8YlDkwCJGh0ORR/iYcvteS4NDS?=
 =?us-ascii?Q?xc1V0AbXsaDtBx3i8gMaMj3a/JH6oCVYT79VMS8rce2asZ7rq6tmI+ZhMvC7?=
 =?us-ascii?Q?Ru3f/MpWRxAaRPmQSvVP9bei5B35/P/QVPiBYmzSnOnYssW3sapQ9ijGE/sX?=
 =?us-ascii?Q?nl4nnNmloFOpc6SoQD293JN/mt7zagnzquqPBm0azNYwaN+tMA0N69AT1Suv?=
 =?us-ascii?Q?1CLghYYMKKu5O1oh5Z7KV/04xFVx4zitNxJIkX8KgRhyZkxuN4sJ3eo8WRmL?=
 =?us-ascii?Q?PlPPah9/EFVOA4XvYz0fGuKS0vmMe41UWAcVvMA6vqkOkNWRs4kOP0a9ikT+?=
 =?us-ascii?Q?E30vVWmk2ia0Md8R6RaYoWXJW4vAATU7AyDvFAQQu0+lRhj3nH6Lv9FhGdAn?=
 =?us-ascii?Q?eGzp2/L2vlrI3FnJ8EAisOeBqC6iswwbcN3s60PQDRUZRyG5wG8+o2LYkQEt?=
 =?us-ascii?Q?tn4yZV8NOOHb2+z0XCS1UXLU26kwCl+tsJMPGH/8glUNeFzRx+44h2O+CEFG?=
 =?us-ascii?Q?RnCrLZr1gOfmgkpWEGRt4vXPkKLZKFz/ZCwK0Q5tXkvhKeCLfwogbf0YMX20?=
 =?us-ascii?Q?YDouPLS4n53Ked7nFAPOF+jJwWFe/1H5WKK5Yhkx6/8/GdpFTp2ghjHu8AGn?=
 =?us-ascii?Q?t/Ri3sFgcsUZnTcHY40yw6VZjVrEVRKQ0t+Yzvdl0jrtQBTrHTMjxdIVWVDP?=
 =?us-ascii?Q?eJOjg9iXrW0xd1f0ZZVrLhkiUOM9lnAWAw59j/fFD3cHkeTkskNcOfRpsxER?=
 =?us-ascii?Q?E7x8mXgR6kYg48sY2rkMJZUMazRJbrx1ZX4mMBxTsxL0dK+Jo8k5IrLKOreY?=
 =?us-ascii?Q?alksY7SfZjeYq3ZApwTyo4EZIOOw73BbqMz3+xf7TOhl+lb0IUUHlt6kOjzd?=
 =?us-ascii?Q?ki36qvTBz0+QVaXCSCpAJnFhfh++9XjXDM7+3wg+U6YttKOADJ0BIjFipkDs?=
 =?us-ascii?Q?gTAJgVL0QGIE05KOVFvM9VUnZ71OCAR0yZD2OYV5ATqJzNVzbEvvC6229t3o?=
 =?us-ascii?Q?RWK3Vud2JzpHSaawcYJ2lE9BJD76dYyry+eGsld22gfxw6D2n8lpNUX3bCMk?=
 =?us-ascii?Q?Fv9OF8IVAjXiUsRUfAB1GQEXq5i6PMROMck+ZKmDdycY7ouVPRd6yvOHYCIv?=
 =?us-ascii?Q?oD+UqdM9tX+zFWZGAAbIhm7qDTeYEUi9VbuGEakRVv1yT1AQU5zCqyqGexCa?=
 =?us-ascii?Q?TPbNChK5AB/5lBD7yQor0x0E8gdP1UNajIbbRLIK9bSbJCt6L/zzQA9NPAQf?=
 =?us-ascii?Q?Kjfih7biqqY2NVVUJfwfWZa7oRywrEYZZ6Obwojrv6Ee7THFYIqF6n+rGOAh?=
 =?us-ascii?Q?kwqhiEacWpfpwobHhjP56ofwhEI44Ft8e4IVyKZVaSEEcS+4fUPJyBU2ACNn?=
 =?us-ascii?Q?L8e6Qndwbi5eXtqm6RJoWjPM08fqBUrurPPd6fT9KYTowIf4D6TEAU+WIIbs?=
 =?us-ascii?Q?k7dgYpP8aEIKiv+HHLWQwe9jlhtHhQhB4Zk9wL5GcvI+DLK5UjtJ7TBxHbEs?=
 =?us-ascii?Q?og=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47f283c7-e6aa-4690-65b4-08db65c37b53
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 12:50:46.7609
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X79p2IcbnWppc7uerCQ114IjUTJkWCF0B3PM4EgMRv+NWBKc7PGbzkmjDRG+orsXHpjzvrDX0yUPRoFimTD6Qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8103
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Fri, Jun 02, 2023 at 01:37:45PM +0300, Vladimir Oltean wrote:
> [ Original patch set was lost due to an apparent transient problem with
> kernel.org's DNSBL setup. This is an identical resend. ]
> 
> Prompted by Vinicius' request to consolidate some child Qdisc
> dereferences in taprio:
> https://lore.kernel.org/netdev/87edmxv7x2.fsf@intel.com/
> 
> I remembered that I had left some unfinished work in this Qdisc, namely
> commit af7b29b1deaa ("Revert "net/sched: taprio: make qdisc_leaf() see
> the per-netdev-queue pfifo child qdiscs"").
> 
> This patch set represents another stab at, essentially, what's in the
> title. Not only does taprio not properly detect when it's grafted as a
> non-root qdisc, but it also returns incorrect per-class stats.
> Eventually, Vinicius' request is addressed too, although in a different
> form than the one he requested (which was purely cosmetic).
> 
> Review from people more experienced with Qdiscs than me would be
> appreciated. I tried my best to explain what I consider to be problems.
> I am deliberately targeting net-next because the changes are too
> invasive for net - they were reverted from stable once already.

I noticed that this patch set has "Changes Requested" in patchwork.

I can't completely exclude the fact that maybe someone has requested
some changes to be made, but there is no email in my inbox to that end,
and for that matter, neither did patchwork or the email archive process
any responses to this thread.