Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5560351701e78a0dfb9b7d2eef703395a0d531b0.camel@linux.ibm.com>
Subject: Re: [PATCH] evm: Complete description of evm_inode_setattr()
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Roberto Sassu <roberto.sassu@huaweicloud.com>,
        dmitry.kasatkin@gmail.com, paul@paul-moore.com, jmorris@namei.org,
        serge@hallyn.com
Cc:     linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Roberto Sassu <roberto.sassu@huawei.com>
Date:   Mon, 05 Jun 2023 09:12:25 -0400
In-Reply-To: <c2b7b5531660befc66a25477abc0cc069d08926c.camel@huaweicloud.com>
References: <20230306104036.1298529-1-roberto.sassu@huaweicloud.com>
         <c2b7b5531660befc66a25477abc0cc069d08926c.camel@huaweicloud.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2023-06-05 at 13:57 +0200, Roberto Sassu wrote:
> On Mon, 2023-03-06 at 11:40 +0100, Roberto Sassu wrote:
> > From: Roberto Sassu <roberto.sassu@huawei.com>
> > 
> > Add the description for missing parameters of evm_inode_setattr() to
> > avoid the warning arising with W=n compile option.
> > 
> > Fixes: 817b54aa45db ("evm: add evm_inode_setattr to prevent updating an invalid security.evm")
> > Fixes: c1632a0f1120 ("fs: port ->setattr() to pass mnt_idmap")
> > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> 
> Hi Mimi
> 
> this probably got lost. It was also reviewed by Stefan:
> 
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> 
> Could you please take it?

Thanks for the reminder.  In case kernel-doc changes are backported to
stable, I've added # v3.2+ and # v6.3+ respectively to the Fixes lines.

There are two other warnings in EVM.  Any chance you're planning on
fixing them as well?

-- 
thanks,

Mimi