Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5674962rwd; Mon, 5 Jun 2023 07:07:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Rz2HDi3S7amIz0wRdRfSrZ7JBILPDuRYZDVKcDIk24xsqqz9dNzfk0LR3qrpwVq+NXa/R X-Received: by 2002:a17:90a:19d5:b0:259:45d6:f2dd with SMTP id 21-20020a17090a19d500b0025945d6f2ddmr1206712pjj.18.1685974042772; Mon, 05 Jun 2023 07:07:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685974042; cv=none; d=google.com; s=arc-20160816; b=VwvtcvRtI3liPEG7E3GCcn8J5dN1fpKo9ew/JE+6NbRuwa214sU8OIDlkiEGibsC72 4O452uAI8xoj8qaXkGH07n3dnsZ4g+yW7FQSVae5Uqn4MoK8Xrh9tqQe8S0XL2yIRCHZ TyiB7vyVnJfx48ADpdMJhmRGlXrmec02rRlY1KKnyjZLhz0Hn3BO2QRGAmYxUt5ZUxZY GogY4gXymb0E1n6eIvgWXTXcxL8U3L47fUi6pID3PSV+Q506xH+211BXzzmNRdcYiK4A cwsMAmGtwFgw0fNBpmQO6msWNijE2d6eCaGiSwa1wLyv4QFWlfA4vStTisAmDZ8at8W1 Q0rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/ELSczkhtd9VXMLVlEBA8HALsqT7GXHXhcL7sJaXMFg=; b=LcqhdNeE+/VfqaxTI97W6uLQ6qrWIoRA0veUzf7+pEFktxJsPDOnodnkXbuUC/AyDI 8Rx/0r+fSMi4vgMJ8c81O0+A1NmYdUwoOH14DjvgyA+4Fm6i+zTlwiH9ZWAJJ/mrmCfn 7/g+YvKXpLpYb3M5nIQtW/YF5nDi42KCiHuiccOplf9dNm7NirulAWs6/x5/vBAWl9k9 vv8ihyVyPXoDBSmWRS440GahP1I/BrbFNJUkLmnt/R+HVydF5epgi/Q5HaiAqfjzEZZJ 2pP1kzVYFIxFzC6NlQEOlUe5Csw0J7m6kz46aYjK9pF3itxqJWVO9ni1O24cVBzioGn+ BH/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=GV5IqcIx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w2-20020a17090aad4200b002569147d64asi5706708pjv.114.2023.06.05.07.07.07; Mon, 05 Jun 2023 07:07:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=GV5IqcIx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233929AbjFENxo (ORCPT + 99 others); Mon, 5 Jun 2023 09:53:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231308AbjFENxn (ORCPT ); Mon, 5 Jun 2023 09:53:43 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC27A90; Mon, 5 Jun 2023 06:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/ELSczkhtd9VXMLVlEBA8HALsqT7GXHXhcL7sJaXMFg=; b=GV5IqcIxuEWnfe2y1GOXozlcec hCcPFPZz0OwME3BdlN6M9C4ILdh0xSf90Y4as0FYmq4EjTI7qyGK6AhoCMBT6+Cc8KZoyFXlDfaya 32BeQlpELC5kOi/zMaEYCK0z8gYzeta6lbyTygceNEW80hp2Ce0j6kIKuDySVyYJgO96hi5IffH3P 5cC7ZTty7oNBpRfLR1Yjp3rWXP2+H8g/TjIZ1bNoJEvnMbH2yqPagF/z7AnKSpGTfZv1WIKCIPHX1 o7HOvOcjHUaiJ78hi/OahjPduiXw1F6faWWRJbaWLmKz4BfF0I9uPP0E2FMgdXsxsfhd4UkD2rR7s IaURQX5Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q6AeO-00Fgws-0W; Mon, 05 Jun 2023 13:53:36 +0000 Date: Mon, 5 Jun 2023 06:53:36 -0700 From: Christoph Hellwig To: Christian Brauner Cc: Alexander Mikhalitsyn , xiubli@redhat.com, stgraber@ubuntu.com, linux-fsdevel@vger.kernel.org, Ilya Dryomov , Jeff Layton , Alexander Viro , Seth Forshee , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/13] fs: export mnt_idmap_get/mnt_idmap_put Message-ID: References: <20230524153316.476973-1-aleksandr.mikhalitsyn@canonical.com> <20230524153316.476973-2-aleksandr.mikhalitsyn@canonical.com> <20230602-lernprogramm-destillation-2438cc92fee3@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230602-lernprogramm-destillation-2438cc92fee3@brauner> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 02, 2023 at 02:40:27PM +0200, Christian Brauner wrote: > On Wed, May 24, 2023 at 05:33:03PM +0200, Alexander Mikhalitsyn wrote: > > These helpers are required to support idmapped mounts in the Cephfs. > > > > Signed-off-by: Alexander Mikhalitsyn > > --- > > It's fine by me to export them. The explicit contract is that _nothing > and absolutely nothing_ outside of core VFS code can directly peak into > struct mnt_idmap internals. That's the only invariant we care about.o It would be good if we could keep all these somewhat internal exports as EXPORT_SYMBOL_GPL, though.