Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5678092rwd; Mon, 5 Jun 2023 07:09:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ64FkTA6h1Val5DfB0WX7wNNO0RnSvw1uhrDH1qv6gdP3XJz7As/NsAIqOFOewnszt/nSRW X-Received: by 2002:a17:902:c1c5:b0:1b1:ac87:b47b with SMTP id c5-20020a170902c1c500b001b1ac87b47bmr4523680plc.55.1685974160611; Mon, 05 Jun 2023 07:09:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685974160; cv=none; d=google.com; s=arc-20160816; b=GnsorERNdD/fqoD7YDomI+hb99uYgieUWfNwwiTleZbnP9qUNulak8m2sP+X7bUs06 jepxkEHsrIFGBOcqZQtVgSsLMmgbT1BGiPnRxBIe65LNfpoEWzeu7zrQBUyevYilWq0M YfIsWjarnerewWOl355oR7DkNi2rjaJaF+ut/0/qhkXamWsujiGqsHInknDHj3L6hKzi 1m20qYF3NBZKO7CmZnFunZbYL64qSov5Fr5YFN6wLrC+5XuhjAW0acCXLiWmTjNtv/6n txR0/VcmHcGf0iBRSg6U+rwuLEt0Kj2Dbi0xveJk3OMPWS1EEHWVg6EqPAzNzVENh5CS yXFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=m00S/6avnRtLOYXgg+cBIVoViQC54EeAvPZld6Eonok=; b=LrCP8FZlX25HJAKhfmKgV0YQeb217oAfwxq3Qm1rN/7YNc1YRD506Nq0gHuhcpj9hS v8KXD+IfYRc/snZDEDQsdrJ56pcRVpR2hP2NeM3qobNgaBi2yK5DhRsHK4fxPpgHiLeC 44xtGcLnzZvjpkmkjHKT01xFpQIX7DDg8PEMe55VacgRNcCHEDy4XMeemrk8gx0HlbPn u4PbvRjnasHPNR48aE+5KZvWcN9DdTRbhLEm4J5ftDFLuFxZOcTunHBs9jVFu4RCbvW4 Dmy0oh4e6306Ofl3wnJian/7rkRpMP84j34+5YkhKZLjUn8XYBryboivHMj5g1SBKGi0 IM7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=cQecMopr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y2-20020a170902ed4200b001ac495a2f96si5325531plb.559.2023.06.05.07.09.06; Mon, 05 Jun 2023 07:09:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=cQecMopr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233343AbjFEOHK (ORCPT + 99 others); Mon, 5 Jun 2023 10:07:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233137AbjFEOHH (ORCPT ); Mon, 5 Jun 2023 10:07:07 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3586FA for ; Mon, 5 Jun 2023 07:06:55 -0700 (PDT) Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 0E8383F458 for ; Mon, 5 Jun 2023 14:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1685974014; bh=m00S/6avnRtLOYXgg+cBIVoViQC54EeAvPZld6Eonok=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=cQecMoprq0e4h/NZrjRMfLuoPafvXd/D72eNAIUh6dVjkH5wvGg6t4PXGg7Qs2q4Q DiPFjqIK/fOS0BECyhBdgCoYvpYdO6R6EYZ2tB7LheywZHdcLC8PNCKYGUcOoYwQPv LEAR7JMQdUQBVTANqfSRdFHvG+8p7/tpL99bGo6FFFqNtfRHhCjcvdVgDGg6xKW2+J nLKZ+R6IHKkvmthkDA8asBs6XJHhZ4PGZ3xGeijppeNJyqGg6wm+lecjLYlfRZZgU+ vAyR4QEmrzYAAEe7RnbiThAT/wjE7Z6uUa9CbpLQ9yVAqMQ4CtbJSR+h3BG+mPvZJC 5fmCyPuVf3ovQ== Received: by mail-yb1-f198.google.com with SMTP id 3f1490d57ef6-bb2202e0108so5809150276.1 for ; Mon, 05 Jun 2023 07:06:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685974012; x=1688566012; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m00S/6avnRtLOYXgg+cBIVoViQC54EeAvPZld6Eonok=; b=kq9zv2RXv7mf1qADkt7KUTnyMgw2mUou3W3zn10L4C33+nA13eEs28WivzdTzWgc4O PZzDU9Ak9P7mAZO3X2ESsXytEB1tMSJC9/WcBqitr9Nh8xoebU9ZG87wJC+suKeB873W EVUB2G2tPBlyFvPSVQ2YArSG7S+K5/QXggoCkciopQWq/kbWNesDzuttHhwegHmu+CNH 8v49D7sFvvCM/2Zxpm3XLs80Mq8zDJgOsQFBvFK6zn9zZhQrOg6WWVQLDRKhfhTUC9uu nBpQsXFhEnoZHGyB3cZ/mYHpBhqU6VMilvTL1futqJyrgrQ9Vv0hRXS2R4hwWiuD6sl0 wXpQ== X-Gm-Message-State: AC+VfDwAxL4H8VYyJQ4ZtbHABN5+owxFgvEQh4kXQY+Ndf9IiXxkKZ02 bvn97iffUs/jeelsOHT8foH3D0+Zei8mwYppnW5626WXepY9tiXATQGxaXnmUVGJO9WCPQbhbpc lB97UGgZAKR6Ra1sV2jDhTEC+g/2q4zjb7KPkc+mw0h0rFI+WfThqjJFypg== X-Received: by 2002:a25:7242:0:b0:ba6:be9b:3085 with SMTP id n63-20020a257242000000b00ba6be9b3085mr14652190ybc.26.1685974011990; Mon, 05 Jun 2023 07:06:51 -0700 (PDT) X-Received: by 2002:a25:7242:0:b0:ba6:be9b:3085 with SMTP id n63-20020a257242000000b00ba6be9b3085mr14652164ybc.26.1685974011736; Mon, 05 Jun 2023 07:06:51 -0700 (PDT) MIME-Version: 1.0 References: <20230524153316.476973-1-aleksandr.mikhalitsyn@canonical.com> <20230524153316.476973-2-aleksandr.mikhalitsyn@canonical.com> <20230602-lernprogramm-destillation-2438cc92fee3@brauner> In-Reply-To: From: Aleksandr Mikhalitsyn Date: Mon, 5 Jun 2023 16:06:40 +0200 Message-ID: Subject: Re: [PATCH v2 01/13] fs: export mnt_idmap_get/mnt_idmap_put To: Christoph Hellwig Cc: Christian Brauner , xiubli@redhat.com, stgraber@ubuntu.com, linux-fsdevel@vger.kernel.org, Ilya Dryomov , Jeff Layton , Alexander Viro , Seth Forshee , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 5, 2023 at 3:53=E2=80=AFPM Christoph Hellwig wrote: > > On Fri, Jun 02, 2023 at 02:40:27PM +0200, Christian Brauner wrote: > > On Wed, May 24, 2023 at 05:33:03PM +0200, Alexander Mikhalitsyn wrote: > > > These helpers are required to support idmapped mounts in the Cephfs. > > > > > > Signed-off-by: Alexander Mikhalitsyn > > > --- > > > > It's fine by me to export them. The explicit contract is that _nothing > > and absolutely nothing_ outside of core VFS code can directly peak into > > struct mnt_idmap internals. That's the only invariant we care about.o > > It would be good if we could keep all these somewhat internal exports > as EXPORT_SYMBOL_GPL, though. Dear Christoph, Well noticed! Thanks, I will do it. Kind regards, Alex >