Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5695772rwd; Mon, 5 Jun 2023 07:21:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7LvyyLe02ftgBzSQbClVov9Tcob7VRJiJjrYp+Lw4WnKFrV4lmwdH8oitz2LCvTE+f/QJ2 X-Received: by 2002:a92:cc11:0:b0:331:105c:81f9 with SMTP id s17-20020a92cc11000000b00331105c81f9mr20555043ilp.29.1685974917661; Mon, 05 Jun 2023 07:21:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685974917; cv=none; d=google.com; s=arc-20160816; b=x486MdeXNDD0Np3o2WscwWUeG1CwJq9MzCGE5wDC3FIZVPzSRmQK9VCTttq/n7NgwS 2UynprlyLPL/9lwjdOIoIS/gtj3kN5Dk74SuQ0B14yepGt9cs/xJ4Ea6CPv2Ys2VuSKu YVqS8WgeZQVYC6iy/ur6/RdMfVTZy6bkvsSQzS7j1edXvrxx+GIxx8opBAAOpTVKpioz /gehuXuFXb4X/6G88OOp7bpz7LVIMUF+cAY+8HYf+BfqBe2YjK+ReZ8zGhoceQpEWV5h WXcacE4vIQfdNi5Bv7N+3rT1rcImsoCxorohJydptWolzDQO6ODvbuiAKQ/5FvMoKysR 0Gjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=iCDndboYofs1euZozUPZ+wnkvppaYLsmW/x22Y7k9M0=; b=Lf5oM8Gr2TbNFTuPfwcPrRCmr/UJBbwwiPjoU23GRUGRnc5mUqIxbjF4wjIj6ETDzT VF4H1iReEOpJc1FBNWhUjtrollrvMDGaHf7Adrt9nqmXEQ2tbHN5i2v4WuAbXr2qf09U hCTRHSN2c5am7h1hI/GqVcFGGO1ifWGKsGDp0exfXV5f8VRUfflM1Dz2TjjWONGKgE4v w2vBWPQrwpxQJY3q18itb41kM5x6FQEwfc9t2nx+bUDY5zxLHTVN39PlZPX8ME940NUh OhzT+0t/6fS3hbKx0rHcA+ALts4MGwyk86DlRfrGNUWEzpvr6W2z5loz66A2kivFxQjY il5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=pvV+1QGk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x18-20020a17090aca1200b00235dc16de3asi7481860pjt.16.2023.06.05.07.21.45; Mon, 05 Jun 2023 07:21:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=pvV+1QGk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231583AbjFEN7H (ORCPT + 99 others); Mon, 5 Jun 2023 09:59:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbjFEN7G (ORCPT ); Mon, 5 Jun 2023 09:59:06 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F7E094; Mon, 5 Jun 2023 06:59:05 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-30aebe2602fso3986097f8f.3; Mon, 05 Jun 2023 06:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685973544; x=1688565544; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=iCDndboYofs1euZozUPZ+wnkvppaYLsmW/x22Y7k9M0=; b=pvV+1QGkdTwyZVyWQBE4H57sf4SvOHNIIJwSSDPCX5sbiigvDQx1XAd9yORmbpC0I/ IgjijCwGDme1HiuHePb3QmZAImM7Tl0y4988DbqOL+QRMGgfuNf/gjjp1TD+3Bs9/QMF I1+hUybPmKRwVRvRKyy6xSec8WUJT4or8unei0NCZWL7hPRX1lSGF/owrdy8n32y4KmD 3v3kuRhQSau4a5Nbs9z7sYNijM++d8pxDB5w7bcJ591ZXeYRhJtGz8LmvBR4/IaNlZOn yWxN+HGJiU4g/QZ8JOQ/THt7CztMijvUXp2/uqopPTCQSHie9GdEV0pkeSLGiW30rISP /8Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685973544; x=1688565544; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iCDndboYofs1euZozUPZ+wnkvppaYLsmW/x22Y7k9M0=; b=EJDhFV6YsUh7JP38S5f1+20nwpSJ0DrSs5l1bjA2D6fYzNIMpGtI/KQn9A9ku0AgoL SjtAp4pamFHafBRW1GHbl6PmT68NkqM+sxzuwYiUV65AaAsPvKszloWgX/bBH5XA4maI BV//4N+9pkt0XkzXpSyEv6aSTSVN+u8+4IW+0Sy/GKiVdxd4Qs70jk5P0fCUNiPGz7fn w5Z+DYMdjrQwMALLZNN79qAVKlG8zemGR0IJMD+t4slLeh9xE23u2plzXoBYIBpz2JLJ KqO5VS1Deerts9P7Kj5dmwtzGC7bOUbHJ5QDmdvdVAml9AisMbGBfVYDQ0lehjIWZV2v W8ew== X-Gm-Message-State: AC+VfDyjxNb4zUWApKJGym+jZ1+9ivzl7O3NfBzj+/10BR8u9T5aZrZX tKa5bEO6NCpK/O1+p7dBEF4= X-Received: by 2002:adf:fed2:0:b0:306:368d:8a1c with SMTP id q18-20020adffed2000000b00306368d8a1cmr4857559wrs.45.1685973543846; Mon, 05 Jun 2023 06:59:03 -0700 (PDT) Received: from debian ([89.238.191.199]) by smtp.gmail.com with ESMTPSA id j14-20020adff54e000000b0030aec5e020fsm9886635wrp.86.2023.06.05.06.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 06:59:03 -0700 (PDT) Date: Mon, 5 Jun 2023 15:58:23 +0200 From: Richard Gobert To: Alexander Lobakin Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lixiaoyan@google.com, lucien.xin@gmail.com, alexanderduyck@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/1] gro: decrease size of CB Message-ID: <20230605135821.GA8361@debian> References: <20230601160924.GA9194@debian> <3f6cd784-767e-02e3-0c30-c0dda12e51ab@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f6cd784-767e-02e3-0c30-c0dda12e51ab@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I hope you've checked that there's no difference in object code with and > w/o `inline`? Sometimes the compilers do weird things and stop inlining > oneliners if they're used more than once. skb_gro_reset_offset() is > marked `inline` exactly due to that =\ Checked on standard x86-64 and arm64 gcc compilers. Would you check any other cases?