Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5735571rwd; Mon, 5 Jun 2023 07:56:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6JtEr13EHCE1B5dMoKkw8pma1+61JuCLzSNOQ2s57PgTCQdA/C531N7AYfzUAFyVpGGejl X-Received: by 2002:a05:6a00:114e:b0:64d:123d:cc74 with SMTP id b14-20020a056a00114e00b0064d123dcc74mr13642359pfm.4.1685976986854; Mon, 05 Jun 2023 07:56:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685976986; cv=none; d=google.com; s=arc-20160816; b=ig5gWhY+TAhc5Z9JRaIR06MfQP0w+w6bdPlJ6v7SlqjdLsttjNW29ZesgOUem7fW/D lMu3anRczh2unt7FxGPFRZZ111PAx0bqsbmkmakegm9XFd9XhOM+TzJaA/Aih7+fhE0m 1y01DxL1va8EHL4lLKDYfQ18hW3aRTDXFz/cEoEpZyW38PN76f2IDaBkV3OWlYnJdvWi 6xvlAT17KdyoSyHRxzdPZWnTf5DHvqM1x5Gy4jWUtcGxdMJpj/SK5Y7MZ7p9M2LDc1OZ kpzx9ZWKA/Vbnog2/vmXiKguhoMZrMRnZ9a4UcSaIi69DplXwKj6+SQ/jjb4HU9PSNLu qIPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0HopakberV/09Ymhu7PPDsILgtKdjcJJ/WhzeUdV2A8=; b=o8ClasW0OKy3urrDO/0t/UY4UMQzgSklmrwvzFskeO1RQvCj2ByGljKEUNptPYOna7 gGZvfGbEhWX37sJFOklR4vA5b/inb12/2GqZLWdDbDuYYzsaUrPcGQhN8wpDFjKobGBd kCTMz5z6TTEqUZywQKNLaAa57piGHIPSpuhxtPAqkuZDhDd0RBqBkh87ZcG3ivkWvjad j7GFVZc8nPpK3bzVL8VlkqF2p8WGEnkYLsL6/QYer34lnR7urpBCeLR8W7aXLDO2U3/x T67GfUTPVb+5Ibn/zIoXyaM5c4PYPov7OBWVek12lPFwpkQHSYUbBVIg171cF0S2LyTh WLDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LZZD4FB6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z2-20020aa79482000000b0064378fd1d54si5311424pfk.258.2023.06.05.07.56.12; Mon, 05 Jun 2023 07:56:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LZZD4FB6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233223AbjFEOnn (ORCPT + 99 others); Mon, 5 Jun 2023 10:43:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbjFEOnm (ORCPT ); Mon, 5 Jun 2023 10:43:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D64C89C; Mon, 5 Jun 2023 07:43:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6ABEC61728; Mon, 5 Jun 2023 14:43:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8008FC433EF; Mon, 5 Jun 2023 14:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685976219; bh=HTJSadZWF7SLKiMGfv9EXQYASZ1ZrbukpqV/os4ftPc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LZZD4FB642a/zNeeKDGYJD0PxclIQ3zj7I4h9fg6dQj68H0ksOHMNcQq+EdSWevTt NJgf31NwMBRrMRp5U7OYICKVMLgdE6jMn7zn1R+y7xtQJUw8L3fGFU92wvqJsiY/Ih x7soiIi7cOKKJa3XGfRXjM/NHrZvJrQ6sv0gGo5Mvb9S4rOrCR8k+2BgrSea0BX+QU vdVcmq3CfCnq0VaCl76i+UUTM+5EXDseao0DSrO/Y1Yr2DnV7JmqgD6mOXkb3zBmIG 8nifdGmdoGFK0VDTOVz/lpJggz1SdMA6QSwUKwdWOrRth3hG3OGl5CYgAxtPGkiPPm +CYO3S2r7X3xQ== Date: Mon, 5 Jun 2023 15:43:35 +0100 From: Conor Dooley To: Paulo Pavacic Cc: neil.armstrong@linaro.org, sam@ravnborg.org, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: display: panel: add fannal,c3004 Message-ID: <20230605-handyman-rebound-0c10df9dfaf2@spud> References: <20230519142456.2588145-1-pavacic.p@gmail.com> <20230519142456.2588145-2-pavacic.p@gmail.com> <20230519-emerald-void-066fad80950a@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nQ7uVUKzJWHOOXKP" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nQ7uVUKzJWHOOXKP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 05, 2023 at 04:33:15PM +0200, Paulo Pavacic wrote: > Hello Conor, >=20 > pet, 19. svi 2023. u 18:41 Conor Dooley napisao je: > > > > Hey Paulo, > > > > On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavacic wrote: > > > > > > Added fannal to vendor-prefixes and dt bindings for Fannal C3004. > > > Fannal C3004 is a 480x800 MIPI DSI Panel which requires > > > DCS initialization sequences with certain delays between certain > > > commands. > > > > > > Signed-off-by: Paulo Pavacic > > > --- > > > v3 changelog: > > > - renamed yml file > > > - refactored yml file to describe fannal,c3004 > > > - added matrix URI to MAINTAINERS > > > v2 changelog: > > > - revised driver title, now describes purpose > > > - revised description, now describes hw > > > - revised maintainers, now has only 1 mail > > > - removed diacritics from commit/commit author > > > - properties/compatible is now enum > > > - compatible using only lowercase > > > - revised dts example > > > - modified MAINTAINERS in this commit (instead of driver commit) > > > - dt_bindings_check checked yml > > > - checkpatch warning fixed > > > --- > > > .../bindings/display/panel/fannal,c3004.yaml | 75 +++++++++++++++++= ++ > > > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > > > MAINTAINERS | 6 ++ > > > 3 files changed, 83 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/panel/f= annal,c3004.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/fannal,c= 3004.yaml b/Documentation/devicetree/bindings/display/panel/fannal,c3004.ya= ml > > > new file mode 100644 > > > index 000000000000..a86b5ce02aa2 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/panel/fannal,c3004.ya= ml > > > @@ -0,0 +1,75 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/panel/fannal,c3004.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Fannal C3004 MIPI-DSI > > > + > > > +maintainers: > > > + - Paulo Pavacic > > > + > > > +description: | > > > + Fannal C3004 is a 480x800 panel which requires DSI DCS > > > + initialization sequences. > > > + > > > +allOf: > > > + - $ref: panel-common.yaml# > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - const: fannal,c3004 > > > + > > > + reg: true > > > > Are there no restrictions on the number of reg entries? >=20 > What do you mean by this? May I have some example if possible? I was commenting on the lack of minItems and/or maxItems. Cheers, Conor. --nQ7uVUKzJWHOOXKP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZH30lgAKCRB4tDGHoIJi 0lsLAP9+CTvXC/zgIcFgiFLJzGtxQzLLeTQaXoaW4152gfRbWAD/XNUI3DAx6XIn 65u/o0sBnBl5RLLBxQIrAK9k2gdYugg= =PaM0 -----END PGP SIGNATURE----- --nQ7uVUKzJWHOOXKP--