Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9d420293-f5af-7563-e7ec-1e42bd69bb8e@amd.com>
Date:   Mon, 5 Jun 2023 09:46:31 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v3] ACPI: resource: Remove "Zen" specific match and quirks
Content-Language: en-US
To:     Chuanhong Guo <gch981213@gmail.com>
Cc:     linux-acpi@vger.kernel.org, rafael@kernel.org,
        linux-kernel@vger.kernel.org, ofenfisch@googlemail.com,
        wse@tuxedocomputers.com, adam.niederer@gmail.com, adrian@freund.io,
        jirislaby@kernel.org, Renjith.Pananchikkal@amd.com,
        anson.tsao@amd.com, Richard.Gong@amd.com, evilsnoo@proton.me,
        ruinairas1992@gmail.com, nmschulte@gmail.com
References: <20230601221151.670-1-mario.limonciello@amd.com>
 <CAJsYDVKoB1AEL47Ud+8jbxMrbZedM0i9p44-PLQTFR9PKLfy6A@mail.gmail.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <CAJsYDVKoB1AEL47Ud+8jbxMrbZedM0i9p44-PLQTFR9PKLfy6A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGJ1RGVDYi9SY1N2Z2R3akNLYWtNSUtBS3RJcEc3a0NGK3lkUW9taXFWdGhr?=
 =?utf-8?B?MWFzRVp0dUxEaEUwR3Y1YUtaeFpYT1RrdEozNzZoTWFXUHVvbnphRW9CWkpY?=
 =?utf-8?B?TldialVEWDFldlFSc2s1c0t3SUJjdm9PUDFnSUtGMVlwUUhJcFZQa2gzZmVV?=
 =?utf-8?B?cDMxYmZTVy9EV1dLNmFGeWZ6UC9aK3NHaU16ZWtta2N6YWpwNzB0Q0QyTzNZ?=
 =?utf-8?B?U2NLUWIvYTFQb3FNQXZDWTVvYWZqV3RFck9JcG1pMTJGa3g0Y2pwbnBjUTFX?=
 =?utf-8?B?NFZzSXZPckhVTHVqK1VlSjBPckJGcnB4MXBJYi9xbjNqYUVCMzJMU1lybzl6?=
 =?utf-8?B?aUoxWktSRGRyZmVlcDdKQTBzMy9tbGJnNkkxVC9uKzRDck5ncGNSWHFiUnY1?=
 =?utf-8?B?UnBZVE9zamFvZmxUdFhFK0VhZzhHRWtjRkY0dzU1UWN0Q0dRdjEwTVNlUk9E?=
 =?utf-8?B?M3lhOFhCN0RXYTdEN05UVWovRnBmTGNkaE9kS1FNQ0VQUGZOSzZERkc4MUZp?=
 =?utf-8?B?by9zOGhSa0JURjBXSXViYWJ2eUJvZk5NSThjSTBCQnlqcUJZcGhnKzU2V1l6?=
 =?utf-8?B?Z0Ezcis1SEsyRm1HUkRRQjhhODNyOFhzSGZZMnZTVWNSVEk5dUJ0QThYTFhz?=
 =?utf-8?B?TitMSW5XTm1IbzlQcnFNaVVRR2JnQlk4aWtZRU5hV25NY2lvYk1BWlRCNnI2?=
 =?utf-8?B?TXdXZFV6ZWZqcmF5NUZzNkk4ZVhzUUhzUTFXRW1DSGI3TDJ3MUZWeVRJOHRO?=
 =?utf-8?B?T2Vpd3pKbXZnM0Fhd2JKVXk0STJuTVRuc2JRYTNZMVpnbnE4TUVkVUZkOUFj?=
 =?utf-8?B?KytiRGN2UVF0Q2lleW5hV0l5c2hhMlFyd0tJMEFFL1FzN1VhSjliWHRHVEcw?=
 =?utf-8?B?c2dIZUVhM01GMG9mUkUzSzMzWHRLZy9vNjd1NDBaSTJMY3BsaFl0T3BrRjZh?=
 =?utf-8?B?Z3JXSUdjRU5pdnRHRUppb2RLVTF6VVhpTHo4UE5VYkdUNldSV3F4MUcyQmtz?=
 =?utf-8?B?WTc3UXdCZ1dJWERzb0hOeTArUm14aEZhVDFmNE90YWMweTJsamlvMkdPWWpH?=
 =?utf-8?B?aSs2eDVvWFNpNnhkVE1LMVVMNkZRNVJYbHFUNURqdGlVQlQrb3V2QVU0ZGlG?=
 =?utf-8?B?dFErekRvdDhoeW5TVWhhR2Z6S2Jka2xybW1VUC9Ud2dncFM3QU5NR0k1elJQ?=
 =?utf-8?B?NzZRcXE2djBwU21tNWtQN0NzVGdtYkNYcC9XZjk2YW9vTWZTbnVaT0J4TFY1?=
 =?utf-8?B?UTdMU2RUNnRaekYvUnY3Yy9CVWo2d09nQWpIbGpLWG9yNyt6eWY1d09ZNDVQ?=
 =?utf-8?B?dkNjN2x5NDZ0aEZmakduZGxZdVBpUEdHQzVQc2pXRkxucklFMENiV2wvL1JR?=
 =?utf-8?B?Z2oyRWRJckMvWHBqdEkxcWdIdHNJVkVuY0VVZE0zemtjVFJjRFA4ak5ERjR2?=
 =?utf-8?B?WlBPYWZxMU9qOUxsOFdZbjFzc2RNOVhZQUIwbXpIenVRdTRmYkZQTzcyaUlP?=
 =?utf-8?B?cUZsNTJHNHRweTZRWXhVUFFkVmhnY2ZLYVJUZzdUS0ttZUxMaTBpd2NNS0Fn?=
 =?utf-8?B?dlpkdWJkY3NFR1ZjU2dmeVdnd1J1NGc2YWxhRlhkNmQ4b0ZYRGJDRlc4b3FO?=
 =?utf-8?B?MDQrZVNDNTExeWE1UkR4a1R4TVJmQnpWR1QyMWVFQ2RnUmR3a0cxeWVVMHo5?=
 =?utf-8?B?alhSb2E4TUd1bjNGOFpPVnFqVnNYcmNTb0VEMGxFOVhHM1J3ZFhyUnZyOHlH?=
 =?utf-8?B?a1c0L2Jsb2NLVFU2WTN0Yy9MYjBTUVFPUXRGRXFWM2VZdTU4SkE0SEd1SnN1?=
 =?utf-8?B?VG1zbzhWbE95NHhLd1NJSXIzR2NMRWJmYnUyOGpsVGYvUlYyeFNIMWhZdStN?=
 =?utf-8?B?UVhJa3pUVlluYUljWG42Z0p5Vks5SHNQSFFpQSsxL3Q4Mk95S3ljRStUalBa?=
 =?utf-8?B?NWloUW5SSmZVYjFWTWo3clZTQmZBNklKNHFSR0s2OW40MGw0OXNGVUp4OU9o?=
 =?utf-8?B?bEVGRUo5Q2h3Y1JEUjBkU2M0VjBDRUZSTVZGYWQxQ1ptNHBGdzVvOE94VDNT?=
 =?utf-8?B?MWVValVYdk9ESjJqdUp6RXhobE1CS2ZZZzd3QU1OR1lNUGF1b2luMnE0eGFn?=
 =?utf-8?Q?zqqCOaZSuBlMT2Tf/i6Y3Mya5?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aeb979dd-1dfe-4192-4dbc-08db65d3a818
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 14:46:33.7647
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rEgKY5OMaVy7//LoUNMRmKOtqNNGM2DLTsyMsnZ5oatD3sKBQSo8Gy7cd3ccsv0eC1TyegMdG/nYlzrfofMy3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7983
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/3/2023 5:19 AM, Chuanhong Guo wrote:
> Hi!
>
> On Fri, Jun 2, 2023 at 6:12 AM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>> commit 9946e39fe8d0 ("ACPI: resource: skip IRQ override on
>> AMD Zen platforms") attempted to overhaul the override logic so it
>> didn't apply on X86 AMD Zen systems.  This was intentional so that
>> systems would prefer DSDT values instead of default MADT value for
>> IRQ 1 on Ryzen 6000 systems which typically uses ActiveLow for IRQ1.
>>
>> This turned out to be a bad assumption because several vendors
>> add Interrupt Source Override but don't fix the DSDT. A pile of
>> quirks was collecting that proved this wasn't sustaintable.
>>
>> Furthermore some vendors have used ActiveHigh for IRQ1.
>> To solve this problem revert the following commits:
>> * commit 17bb7046e7ce ("ACPI: resource: Do IRQ override on all TongFang
>> GMxRGxx")
>> * commit f3cb9b740869 ("ACPI: resource: do IRQ override on Lenovo 14ALC7")
>> * commit bfcdf58380b1 ("ACPI: resource: do IRQ override on LENOVO IdeaPad")
>> * commit 7592b79ba4a9 ("ACPI: resource: do IRQ override on XMG Core 15")
>> * commit 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen
>> platforms")
>>
>> Cc: ofenfisch@googlemail.com
>> Cc: wse@tuxedocomputers.com
>> Cc: adam.niederer@gmail.com
>> Cc: adrian@freund.io
>> Cc: jirislaby@kernel.org
>> Cc: Renjith.Pananchikkal@amd.com
>> Cc: anson.tsao@amd.com
>> Cc: Richard.Gong@amd.com
>> Cc: Chuanhong Guo <gch981213@gmail.com>
>> Reported-by: evilsnoo@proton.me
>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217394
>> Reported-by: ruinairas1992@gmail.com
>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217406
>> Reported-by: nmschulte@gmail.com
>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217336
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> v2->v3:
>>   * Adjust to drop heuristics entirely
>>   * Drop tested tags
>>   * Add more links and people to Cc
>>   * Drop Fixes tag as this got a lot more risky
>> v1->v2:
>>   * Rebase on 71a485624c4c ("ACPI: resource: Add IRQ override quirk for LG UltraPC 17U70P")
>>   * Pick up tag
>>
>> Rafael,
>> Please hold off on picking this up until the majority of those on CC
>> have tested it on hardware they have and reported results.
>>
>> Everyone else,
>> Please test. If you have problems with this applied, please share
>> an acpidump and dmesg either on a bug or to me privately.
> I was expecting this patch to break my keyboard again but
> that didn't happen. I'm on the latest UEFI from Lenovo.
> By dumping ACPI APIC I found that there's this:
>
> [0C4h 0196   1]                Subtable Type : 02 [Interrupt Source Override]
> [0C5h 0197   1]                       Length : 0A
> [0C6h 0198   1]                          Bus : 00
> [0C7h 0199   1]                       Source : 01
> [0C8h 0200   4]                    Interrupt : 00000001
> [0CCh 0204   2]        Flags (decoded below) : 0007
>                                      Polarity : 3
>                                  Trigger Mode : 1
>
> I don't have a dump of the ACPI table from older UEFIs anymore.
>
> Tested on Lenovo Thinkbook 14G4+ ARA with the latest
> UEFI (J6CN45WW).
>
> Tested-by: Chuanhong Guo <gch981213@gmail.com>
Thanks!  Yours is the one I was most worried about.