Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230605110200.938902-1-arnd@kernel.org>
In-Reply-To: <20230605110200.938902-1-arnd@kernel.org>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Mon, 5 Jun 2023 16:31:13 +0200
Message-ID: <CAMRc=Md=s+HbRWA6ReZsviYDg5TPzQZ9iETV_TpBTeTXakt4og@mail.gmail.com>
Subject: Re: [PATCH] gpio: delay: add OF_GPIO dependency
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Alexander Stein <alexander.stein@ew.tq-group.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        William Breathitt Gray <william.gray@linaro.org>,
        Pandith N <pandith.n@intel.com>,
        Yinbo Zhu <zhuyinbo@loongson.cn>,
        Niklas Schnelle <schnelle@linux.ibm.com>,
        =?UTF-8?B?TnVubyBTw6E=?= <nuno.sa@analog.com>,
        Davide Ciminaghi <ciminaghi@gnudd.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jun 5, 2023 at 1:02=E2=80=AFPM Arnd Bergmann <arnd@kernel.org> wrot=
e:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new driver fails to build when OF_GPIO is disabled:
>
> drivers/gpio/gpio-delay.c: In function 'gpio_delay_of_xlate':
> drivers/gpio/gpio-delay.c:79:39: error: 'struct gpio_chip' has no member =
named 'of_gpio_n_cells'
>
> Fixes: cf5dec80c4e23 ("gpio: Add gpio delay driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index a1dac1345f60f..006abaedcae82 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1735,6 +1735,7 @@ config GPIO_AGGREGATOR
>
>  config GPIO_DELAY
>         tristate "GPIO delay"
> +       depends on OF_GPIO
>         help
>           Say yes here to enable the GPIO delay, which provides a way to
>           configure platform specific delays for GPIO ramp-up or ramp-dow=
n
> --
> 2.39.2
>

Thanks, Alexander beat you to it.

Bart