Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 15:44:37 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Raag Jadav <raagjadav@gmail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: act8945a: rely on hardware for operating
 mode
Message-ID: <545d3463-ce56-41d5-9d95-55764c448c09@sirena.org.uk>
References: <20230605104830.68552-1-raagjadav@gmail.com>
 <04b8fa24-e5a8-4871-a397-f1c0c886449a@sirena.org.uk>
 <20230605143103.GA3068@pc>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="puGooPXjA0AF5duk"
Content-Disposition: inline
In-Reply-To: <20230605143103.GA3068@pc>
Precedence: bulk


--puGooPXjA0AF5duk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 05, 2023 at 08:01:03PM +0530, Raag Jadav wrote:
> On Mon, Jun 05, 2023 at 01:16:33PM +0100, Mark Brown wrote:
> > On Mon, Jun 05, 2023 at 04:18:29PM +0530, Raag Jadav wrote:

> > > Convert ->get_mode() and ->set_mode() hooks to read/write operating mode
> > > from/to hardware instead of relying on driver memory.

> > Why is this change being made - what is the benefit here?

> Original implementation uses drvdata to load/store
> operating mode for the regulator.

> This change doesn't really add anything new.
> It is just to make sure that the driver is in sync
> with the current state of affairs in the hardware
> instead of relying on locally stored status in the memory.

It's also removing a cache so we need to talk to the hardware more often
which doesn't seem like a win.  If there's a bootstapping problem then
shouldn't we just read once at startup?  If there's no problem what's
the advantage?

--puGooPXjA0AF5duk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmR99NUACgkQJNaLcl1U
h9A+awf9E7r5u5zgTmh4yjCrkSLmbjQ/Lpdd/GSvGdMeoWYVkj0Q7iyu9+dwxQnV
UUaBqkrSXcahIl0JkRoWSpMcW0GotHcvzyRrzjCU9uK3DJ5a8SiHa6rm7WbNhMT8
S6JcBGeJzywknHBRpeWfpa7H90WFSxU7/cf/EmVzkAOLxT9T0GQktHSxwrl6BM0T
Ro+DG5elPionsSBnnoHX1UKJE2XCRTMHXpF7+j15aGknbZJs6SuFxaF/9P023v8O
c5CpIVIojStYSvDuZFbol+9NRwKxFLwzXYpNumAXAwU3q0MkT6dqXz+dtPZfIUeC
b3VAjvm7g92qmhwqprlxCi+HDYpmpg==
=jbQQ
-----END PGP SIGNATURE-----

--puGooPXjA0AF5duk--