Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 16:50:14 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     David Howells <dhowells@redhat.com>
Cc:     netdev@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Chuck Lever <chuck.lever@oracle.com>,
        Boris Pismenny <borisp@nvidia.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        David Ahern <dsahern@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 03/11] splice, net: Use
 sendmsg(MSG_SPLICE_PAGES) rather than ->sendpage()
Message-ID: <ZH32Jp1Iop8FaDtC@corigine.com>
References: <20230605124600.1722160-1-dhowells@redhat.com>
 <20230605124600.1722160-4-dhowells@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230605124600.1722160-4-dhowells@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3j7qU7nBqxfa7u7F/HPXtjwosK6qv/dHF1UdQ06AROJETzxmx4VUySCuT6Sg?=
 =?us-ascii?Q?lm8vg7M1ZzN5x/Zc96YsIOfvB16nlkkTPxgiwayAMpZtPkpCNAseRfJv+AlB?=
 =?us-ascii?Q?lXwci7T+r9eAwJubzWDrlhSLKfFjDb4Uu7BtoZ7HVGXzYqniefyeWe4Lp6Pf?=
 =?us-ascii?Q?8GMdZAzbxzFtaFipuBNPwGHqVKVCcc+d8F3NEZl4LZ/Mw4BQzKFbKGtwlKxd?=
 =?us-ascii?Q?rv3WMtSGORelIhPA+yr6S8H0QvvJFXY0Nhj3QYutzBKFYEnbL4mP+OQwuKWG?=
 =?us-ascii?Q?JRmTbMSsozS79jrrtEl9uk1ioUPMltv6G/teSJc3l6JIXTFqeKsUQobf5NUZ?=
 =?us-ascii?Q?zqR8Mh4Db5DD8otrOc+SlCCBWFuBmmD337nyAK2Xbdx4P7tdWHpDcpLFrq8B?=
 =?us-ascii?Q?cvdq7QchDGGTuplRnmqt2lln6flpzqGzpDIxlNgj7/X0oQDibjJ4HQCogIN7?=
 =?us-ascii?Q?d1CnWf/2orMUlrdUBXBZxqPQwamwmHgcPSo9blc25CvMAUiBnXGEVWgTUKXC?=
 =?us-ascii?Q?ZqMM4zwpaZXcQ7o/7KkHHJ2UpO38kYH9by2LFE7egahvd7NdcyCQ6JZ1q3zX?=
 =?us-ascii?Q?Y8k9ogohnOKokbOCkVllkL3llmAs9W9nXYUzF8mdHVm/IKK4opZ76UojoX2p?=
 =?us-ascii?Q?sSjyHk7fhGeHdRRFtWvOTC9CIp4ThnMME+HM60ENgUTuhxI2eRvxsWW6c33r?=
 =?us-ascii?Q?LcnImEj1KIEjMVF4DaYMandWIxpZwwnR8UsmPcJmpcVLBShyi3F2SHImWyaA?=
 =?us-ascii?Q?Lf0jpdzaoFTmem3Aafn/Ozojo/FqKxSSYNvr2DT7Hq9MeE7EHqN0mY+d9Wym?=
 =?us-ascii?Q?wqF0lVuKVTDT7Z/DjHEHvVLIaPxVQyW5PZ/0/Bj+o0W+HJCv1PXoHuy0Yh6v?=
 =?us-ascii?Q?4par7adY1M3F5+J5dXUc2QvcuzQ0OZ8Q0UIFwyySAiOScx5yUyUcfNUnHb1u?=
 =?us-ascii?Q?ywqoJtrkjmFxOrAefMhjgDItSmAS7sG+UyBfePyIa7Hwma7iE+OmIqlDWC3z?=
 =?us-ascii?Q?65Rg9dxKBZ9cluqgkEa5hq+3aKNjMz6Qxx/0G8hn9D/PPMPdp27LfuicXxW7?=
 =?us-ascii?Q?K+21g41rCnE0I7vTwla9RzA609Cx4tf4ORespTjGe/lTTAElMgBN0bua2EfQ?=
 =?us-ascii?Q?VmZf7FYJ5e4UVUm2vIUFLpVrr6JLX1EKVC1f2jPGxrRha9w9WaiKQ5FWD0s/?=
 =?us-ascii?Q?HaCkjv/arvFf2lrmhsiHrL9FcIxpT/3e8twyaHxY3d5JrCKt0FbHwezMJwo6?=
 =?us-ascii?Q?wSfqTSVyj9QfZKXQB3hwSyxYY6vCqwrgUfIlqB7keicMk9HS6a/8PSl9dVqm?=
 =?us-ascii?Q?d6IfMUi5bGE57ydp49vRluM+U/vuYGP1dhxjrkGWnMG2PMuSS3g8GvqHGGVD?=
 =?us-ascii?Q?gPtt9FeIpQiuoI3JG9YS7CbFexaArXGtCdAD6TO++LZ+6aJI8G6uB9uYMFtt?=
 =?us-ascii?Q?0w1svCso2J0b0tluINKiOtnWi8w1nJcoWYrzthvGrTBb0NDqp/INLV2wCweq?=
 =?us-ascii?Q?cn6fk8FMUFzRJqCcOtWdrSgYpylvKnv2qPjUpXsvKIULv5uZskzXrkOG7osC?=
 =?us-ascii?Q?lKo1lCHK66gv1qnOgrE96dIVFCqAfw/j3RJ7Y43vwNipGyhcPVjxslbkdzab?=
 =?us-ascii?Q?sTtwBhexXnst8egT9WgXnAmUphPuTTqZta8eRY+ChGBGjhasrR19K4ApHJMS?=
 =?us-ascii?Q?V+uA5g=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 681c2313-d569-4b1f-19dc-08db65d42fcd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 14:50:21.5424
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JIfUpE2+iBpCvi7+VtnVyobQPnk9L7Ltqno4yHC11FdiBMQavbioSos4D7tpckDnwCiCgIg1Cu2HpEhlHKj9jCnjhRmnSVsMRnucvnvzLDU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR13MB4692
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 05, 2023 at 01:45:52PM +0100, David Howells wrote:

...

> @@ -846,13 +824,131 @@ EXPORT_SYMBOL(iter_file_splice_write);
>   *    is involved.
>   *
>   */
> -ssize_t generic_splice_sendpage(struct pipe_inode_info *pipe, struct file *out,
> -				loff_t *ppos, size_t len, unsigned int flags)
> +ssize_t splice_to_socket(struct pipe_inode_info *pipe, struct file *out,
> +			 loff_t *ppos, size_t len, unsigned int flags)
>  {
> -	return splice_from_pipe(pipe, out, ppos, len, flags, pipe_to_sendpage);
> -}
> +	struct socket *sock = sock_from_file(out);
> +	struct bio_vec bvec[16];
> +	struct msghdr msg = {};
> +	ssize_t ret;
> +	size_t spliced = 0;
> +	bool need_wakeup = false;
> +
> +	pipe_lock(pipe);
> +
> +	while (len > 0) {

Hi David,

I'm assuming the answer is that this cannot occur,
but I thought I should mention this anyway.

If the initial value of len is 0 (or less).

...

> +
> +out:
> +	pipe_unlock(pipe);
> +	if (need_wakeup)
> +		wakeup_pipe_writers(pipe);
> +	return spliced ?: ret;

Then ret will be used uninitialised here.

> +}
> +#endif
>  
>  static int warn_unsupported(struct file *file, const char *op)
>  {

...