Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 17:18:59 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     David Howells <dhowells@redhat.com>
Cc:     netdev@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Chuck Lever <chuck.lever@oracle.com>,
        Boris Pismenny <borisp@nvidia.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        David Ahern <dsahern@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 03/11] splice, net: Use
 sendmsg(MSG_SPLICE_PAGES) rather than ->sendpage()
Message-ID: <ZH3841Qotr/QWgXk@corigine.com>
References: <ZH32Jp1Iop8FaDtC@corigine.com>
 <20230605124600.1722160-1-dhowells@redhat.com>
 <20230605124600.1722160-4-dhowells@redhat.com>
 <1729074.1685977857@warthog.procyon.org.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1729074.1685977857@warthog.procyon.org.uk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QzdOA6rrNDsgry81dhE6XZmalw39UX55k6YfpWHheS2fLOzAzmzgC58hWEuk?=
 =?us-ascii?Q?IlxTyd2MVN7HFLjniUFIQWp8ZKuQ9XcHHdGkj2II4JX2icKsslQT+4GdoeTs?=
 =?us-ascii?Q?lv5JCLdpbs+U0s7YCzBanzqdjiTkZEA1HY3ollAxGRJWzFJagTOu4AI4b9Xl?=
 =?us-ascii?Q?fUv9NNk+hkjFNA2y8jvwzpSLdmcfJjqILwW0zqZMT0pDYNEvSU0o6G34Z1HS?=
 =?us-ascii?Q?xAqnQSELOhKbmlX7evRkScwE7Z6ep3CwIaST1XjZ6DK5k2J4vTb6lyeDt7sW?=
 =?us-ascii?Q?9qMYYggljF4FP838Q/W/oLQPoLwe/iLt5689KkK6Yae88oDJefqav/6jywCs?=
 =?us-ascii?Q?k+RNP9UEfl49p9fXSnc+XekyQybz6yFgbX8sNqCj06WlBLqDhKoGY7SVenam?=
 =?us-ascii?Q?RcNNahwy/Ih1xGdP9zxuc1WcvNYq2DtMvIM/oIv+XyIhxZPXv5sh2pPUnDz+?=
 =?us-ascii?Q?1GGSCDIG9LzHNKU3CJOSjzBuIX+aHBi9DaLxXUB1hJPiRvEOGu0IWJVjSoZR?=
 =?us-ascii?Q?gRkGBL/TvP223YobKHfjHFNhA12siD/M6mkSoJ2wkp0zzewXfzFBCNn8Fg4t?=
 =?us-ascii?Q?/R6p6xUiTStkNwVsSn8LVADjWIXVLdPuB67VLYjYVpA2oZtmCIHHMOR5OdoV?=
 =?us-ascii?Q?4RRpawXL+3wHoI3Itb7/l0xxC0cWMcx/bwBLGttv1PNc28bmd0hlv0jzFWVb?=
 =?us-ascii?Q?3NhOTRd+EcL/SPV7S2HLDo4sOoCpoq7kJ9l1VLdk1ODsFZZDXtfFqi9vYxgC?=
 =?us-ascii?Q?NM0TLAYj7FDakJXMclgy4H6E/MH+X0LIkLw+Nh095kBB0QzYZdA9/NCnCv2P?=
 =?us-ascii?Q?bsuivFpbzCioQGfwj5yh/5MRhAFFW/fl1ZPgh7wfjt+7NfWxzJCImNlo95u/?=
 =?us-ascii?Q?j2YjNplXdN8cjc8jwC3Zq+s9sJ4hlJoeTFN5rA/feM5le5Hvqi17GRTyzNJH?=
 =?us-ascii?Q?6l513nCksdyX0If+2yWGx1Ka1UovKMDTzSgL2B6uPlMICoEIGXAbquEppQ1q?=
 =?us-ascii?Q?/d7ThagJgmK1jmtkRn5YSsV/fQKqGfxODdOxR9jR332XdujGBMrgr2omSo5f?=
 =?us-ascii?Q?X4RTOX9oGerB0+289XToM7ABJFvCwgJNWfy6gtdmH4aNwPC2QbFNLPPH1d2z?=
 =?us-ascii?Q?f/wxEnEIPGOoxIMa9gPUm9HVNVDVgKankYMColDHISUn1VzgpcaBgD3pgR8/?=
 =?us-ascii?Q?GddwlPs7KH6grY6dglQUb8KfFgjjmC5rG7CAjYlVTyiDJLqNkmz3lg7JSl2R?=
 =?us-ascii?Q?ZRcs5W0mA6/x0ZKhq3oWx/n3WagdXQc/vt+Lb/E/8C21tIFwS5Fo4CJzYmpB?=
 =?us-ascii?Q?Y5i6Qmwj835Ns3gluc9xI0Jkzk5qFXjBDUvC5wDM0Q+vV7PTDkxykjibQnfc?=
 =?us-ascii?Q?klupJzFi08hmbQ9qKclNwY1p2gP2AiV8i2fRaiab1HKI07o7qX2uIclmDJ9K?=
 =?us-ascii?Q?FNru8i59okL5rBih8MktYjg8aoDykraRMut9Je7OX7XAx6YEgvgr3zyjRUya?=
 =?us-ascii?Q?SUHolx8SfUICT1QjX5lCD9uqy9N7G0N1u0D28mNGfEDYm2ke2yNqzaDM2C/Y?=
 =?us-ascii?Q?1CxNo8EhuV4FmIUQpPcMqE23/R8Y3CazwfSVHcuaKvc7r5OE4LnA9lDGQdm6?=
 =?us-ascii?Q?22uzEm3MznICxzyVtRm3cgkKT/Q9IdxoF28HxsMa+JBwm/JpnmiCvGnaNVVb?=
 =?us-ascii?Q?09a7tA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b43b6b5-7ff7-401c-1d42-08db65d8336a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 15:19:05.4070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LXRiEdmSSxdDDDTHjfq+PRWuejWGvP9+dIj8D7JeLUAZG8Z5T0NbJlGKUVfLOSI+fH/jiQKpTLedsyETuI2pXgX+LUuFQOL4Mm1ET/NF8oc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR13MB6478
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 05, 2023 at 04:10:57PM +0100, David Howells wrote:
> Simon Horman <simon.horman@corigine.com> wrote:
> 
> > I'm assuming the answer is that this cannot occur,
> > but I thought I should mention this anyway.
> > 
> > If the initial value of len is 0 (or less).
> > ...
> > > +	return spliced ?: ret;
> > 
> > Then ret will be used uninitialised here.
> 
> len shouldn't be <0 as it's size_t.

Yes, sorry for not noticing that.

> I don't think it should be possible to get there with len==0 - at least from
> userspace.  sys_splice() returns immediately and sys_sendfile() either splices
> to a pipe or goes via splice_direct_to_actor() will just drop straight out.
> But there are kernel users - nfsd for example - but I don't know if they would
> splice directly to a socket.
> 
> That said, it's probably worth preclearing ret just to be sure.

Thanks, I agree it's better to be safe than sorry.