Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Wei W" <wei.w.wang@intel.com>
To:     "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        "Aktas, Erdem" <erdemaktas@google.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "Shahar, Sagi" <sagis@google.com>,
        David Matlack <dmatlack@google.com>,
        "Huang, Kai" <kai.huang@intel.com>,
        Zhi Wang <zhi.wang.linux@gmail.com>,
        "Chen, Bo2" <chen.bo@intel.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>
Subject: RE: [PATCH v14 011/113] KVM: TDX: Add C wrapper functions for
 SEAMCALLs to the TDX module
Thread-Topic: [PATCH v14 011/113] KVM: TDX: Add C wrapper functions for
 SEAMCALLs to the TDX module
Thread-Index: AQHZkeUO9CJK5Ein70KPqCCkDQrVv697abhQ
Date:   Mon, 5 Jun 2023 15:20:19 +0000
Message-ID: <DS0PR11MB6373872D1536D6469B29159CDC4DA@DS0PR11MB6373.namprd11.prod.outlook.com>
References: <cover.1685333727.git.isaku.yamahata@intel.com>
 <37b118268ccf73d8e9cc1ef8f9fb7376fb732d60.1685333727.git.isaku.yamahata@intel.com>
In-Reply-To: <37b118268ccf73d8e9cc1ef8f9fb7376fb732d60.1685333727.git.isaku.yamahata@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1E/g15wM5SIsCYCF7N4hSAvaKCKeRooxmmrevH0Ip/XN+TsX0ygf+fNM8+Oq?=
 =?us-ascii?Q?ROmJ+6RFsG5qNEXwi8GVYm0GZFTXT8pNdafKX7NcrkjJreBu9U/c19pfyb6j?=
 =?us-ascii?Q?+zd8VmCRMvb9BKLpsWFvB/fW2udwztiWEESWJ4u0SZqkXc3MsNcX/9d8ZzWQ?=
 =?us-ascii?Q?M8KNzOVKxBwjARwdPASuMnIm2Iv7owNuXREgkkhdlPoNaprCwKG2aF3n93Gb?=
 =?us-ascii?Q?DLNyqjz0jYRVQMpU1i3aGtjY5uRPWe1OVIFWWaMaj8mmZNJ0ptHFQZAfmyV8?=
 =?us-ascii?Q?m2OFJ6xx5wKkn2aGZR8ZTVxsjXKOdmbtWolkJ1alqmRpHyLgo7zNipvdbuUm?=
 =?us-ascii?Q?2feHqI5/BREefyJtkhAw9IoadF5LsvNWd8LXV2C4iMpN6yiizQfsQZ9UlDp7?=
 =?us-ascii?Q?PSLX6fXAJiY3n/GOu0FQTz5fH+W4eAWaGTSEsqnh0cKCL+PNsYdvd2lIWFIZ?=
 =?us-ascii?Q?nJRWRkm2kpscMQ0U4isyWUj04vNZcWsdfL/RDLhx8iALIOqpubtYHWe95yl3?=
 =?us-ascii?Q?R8k1Byfgp9Sg24JQIq29jm5i1wzCan+jD1Qi2jzhcFmroUpfdtW7Ln2gQ4tz?=
 =?us-ascii?Q?sNY1/UHfUqXiKUbMhvV6Qg1O38FFQsFcDY7tRSlkyHcyrF34m1aCCQ4+0pUW?=
 =?us-ascii?Q?IrA6nA8+pRYmpDy+mS+GE9IsPs+L4MozcqfHUO7hT924IfrmZUz3VQ+l0nE0?=
 =?us-ascii?Q?poNbqfSZvvVOOfz556thdLL3sxsVqttWbZhKCM3GYZlG4rNoY7rN6jdoP6WE?=
 =?us-ascii?Q?9/3e/oZEEG+MDq4fHAVJQLDTF5uh+j1amc+URjtwYCMy+zSPyUt4EPY2YOee?=
 =?us-ascii?Q?WiCB3ff8ys144IuypQK+Hkb+DEiXSeiR63mfEKZ+dJLhTRfiHLqNBLE3t0ZT?=
 =?us-ascii?Q?uF8TAIxSz4sXON2i7cH/LShO7B0v712hJ2lSssUKA/++BX0Q5527a+qPoshr?=
 =?us-ascii?Q?ZXecmFBuMI3Gp/RNWxkbgyGHHeIS39cxbq7m19XpDw3bQ1JH70wAdeNvBZCb?=
 =?us-ascii?Q?gelHUNLvu5ExqP4fWhPr97WUIsfVGi6Lwi91CaYNc9h6JSHbsrhNiSGtI3Pq?=
 =?us-ascii?Q?xD/Igd0vFBS5NeyI9zfXXY5iLBg4FaHrHcoE/SLmKaLvy5UcfarnvsRh3owX?=
 =?us-ascii?Q?l1ztthWYnHj0MnZO0VUbZ2tJEHvDxftF9iC58yeNcBsyibmVCGd7ZltmV2dD?=
 =?us-ascii?Q?eVbX8eVI/E+tB7eSb0Gujq7tP6evqowVQ1dfmEXtstyuer78kyxc2Yoq7xTt?=
 =?us-ascii?Q?hbppeqQ5B7udS4ngr5y/bsZfIZTQaCAQIU5mCT2WbX850ySVvFdpBnW3im1B?=
 =?us-ascii?Q?gu+rmiAowjlsMHByLWqCO89v+Qwb32T2i+tO7E5JPajHLDvXSu2tu/acdbdN?=
 =?us-ascii?Q?3kL8Nar5KHGP9Pcwc79oD0YNutDNrtbiLT9Mwt8DGIFP1PQ3OkXBr8+sSa2a?=
 =?us-ascii?Q?8tHFdLops948LIaTz3XRhLKhg46hviOpfmvN6KELJgKTU4OW48l8giaXSH5a?=
 =?us-ascii?Q?biQWuSGPZJWDMB/YQC/LFKaSMg2aB5PnNgYZgYduWPrchKd3Ndaps3t+q2S9?=
 =?us-ascii?Q?WbWS4hEPUO01qLKcGE+d0Qn/7TV4BzWPHE/nyaqe?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39c2999b-b333-48f7-9c81-08db65d85fae
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2023 15:20:19.5094
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /Y160pT5Ym4kq8HGYpC1zhFyjleh4r2VJvbcJTZgkv1uFOkqUu12pJPwtgAihSyp59xlfL+6SBm1Fax3zY1Ftg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6780
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, May 29, 2023 12:19 PM, isaku.yamahata@intel.com wrote:
> From: Isaku Yamahata <isaku.yamahata@intel.com>
>=20
> A VMM interacts with the TDX module using a new instruction (SEAMCALL).
> For instance, a TDX VMM does not have full access to the VM control
> structure corresponding to VMX VMCS.  Instead, a VMM induces the TDX
> module to act on behalf via SEAMCALLs.
>=20
> Export __seamcall and define C wrapper functions for SEAMCALLs for
> readability.
>=20
> Some SEAMCALL APIs donate host pages to TDX module or guest TD, and the
> donated pages are encrypted.  Such SEAMCALLs flush cache lines (typically=
 by
> movdir64b instruction), but some don't.  Those that don't clear cache lin=
es
> require the VMM to flush the cache lines to avoid cache line alias.
>=20
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
> ---
>  arch/x86/include/asm/tdx.h       |   4 +
>  arch/x86/kvm/vmx/tdx_ops.h       | 202
> +++++++++++++++++++++++++++++++
>  arch/x86/virt/vmx/tdx/seamcall.S |   2 +
>  arch/x86/virt/vmx/tdx/tdx.h      |   3 -
>  4 files changed, 208 insertions(+), 3 deletions(-)  create mode 100644
> arch/x86/kvm/vmx/tdx_ops.h
>=20
> diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h inde=
x
> 112a5b9bd5cd..6c01ab572c1f 100644
> --- a/arch/x86/include/asm/tdx.h
> +++ b/arch/x86/include/asm/tdx.h
> @@ -104,10 +104,14 @@ static inline long tdx_kvm_hypercall(unsigned int
> nr, unsigned long p1,  bool platform_tdx_enabled(void);  int
> tdx_cpu_enable(void);  int tdx_enable(void);
> +u64 __seamcall(u64 op, u64 rcx, u64 rdx, u64 r8, u64 r9,
> +	       struct tdx_module_output *out);
>  #else	/* !CONFIG_INTEL_TDX_HOST */
>  static inline bool platform_tdx_enabled(void) { return false; }  static =
inline int
> tdx_cpu_enable(void) { return -EINVAL; }  static inline int tdx_enable(vo=
id)
> { return -EINVAL; }
> +static inline u64 __seamcall(u64 op, u64 rcx, u64 rdx, u64 r8, u64 r9,
> +			     struct tdx_module_output *out) { return
> TDX_SEAMCALL_UD; };
>  #endif	/* CONFIG_INTEL_TDX_HOST */
>=20
>  #endif /* !__ASSEMBLY__ */
> diff --git a/arch/x86/kvm/vmx/tdx_ops.h b/arch/x86/kvm/vmx/tdx_ops.h
> new file mode 100644 index 000000000000..893cc6c25f3b
> --- /dev/null
> +++ b/arch/x86/kvm/vmx/tdx_ops.h
> @@ -0,0 +1,202 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* constants/data definitions for TDX SEAMCALLs */
> +
> +#ifndef __KVM_X86_TDX_OPS_H
> +#define __KVM_X86_TDX_OPS_H
> +
> +#include <linux/compiler.h>
> +
> +#include <asm/cacheflush.h>
> +#include <asm/asm.h>
> +#include <asm/kvm_host.h>
> +
> +#include "tdx_errno.h"
> +#include "tdx_arch.h"
> +#include "x86.h"
> +
> +static inline u64 kvm_seamcall(u64 op, u64 rcx, u64 rdx, u64 r8, u64 r9,
> +			       struct tdx_module_output *out) {
> +	u64 ret;
> +
> +	ret =3D __seamcall(op, rcx, rdx, r8, r9, out);
> +	if (unlikely(ret =3D=3D TDX_SEAMCALL_UD)) {
> +		/*
> +		 * TDX requires VMXON or #UD.  In the case of reboot or
> kexec,
> +		 * VMX is made off (VMXOFF) by kvm reboot notifier,
> +		 * kvm_reboot(), while TDs are still running.  The callers
> check
> +		 * the returned error and complain.  Suppress it by returning 0.
> +		 */

Curious how do the callers check the returned error when " Suppress
it by returning 0" here.


> +		kvm_spurious_fault();
> +		return 0;
> +	}
> +	return ret;
> +}