Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Deucher, Alexander" <Alexander.Deucher@amd.com>
To:     Paul Menzel <pmenzel@molgen.mpg.de>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] drm/amdgpu: Log if device is unsupported
Thread-Topic: [PATCH] drm/amdgpu: Log if device is unsupported
Thread-Index: AQHZl8GmBf1fuDCUxkan6FATlzGhAa98VOew
Date:   Mon, 5 Jun 2023 15:28:57 +0000
Message-ID: <BL1PR12MB51449DDCC16D5E3035B5571CF74DA@BL1PR12MB5144.namprd12.prod.outlook.com>
References: <20230605152300.171794-1-pmenzel@molgen.mpg.de>
In-Reply-To: <20230605152300.171794-1-pmenzel@molgen.mpg.de>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=929ec35b-e2c4-4b6d-8fef-54cc674948f3;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-06-05T15:27:16Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BL1PR12MB5144:EE_|CH0PR12MB5138:EE_
x-ms-office365-filtering-correlation-id: 178d5a55-8064-4a72-be3c-08db65d9941e
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: J3wifOQ1vbZz7h3qBHz2cTEUUEZHVEsbvDv4xeymdsspKA262+rVcM2l/9hPhfjEL0kxZXBPRY7kwQEd9LSqBymhdVn6YlZSzEtFziYcaYeumNWQ+F3mpD++F5BPDQvU1SltPaRxfhQtgb84kLCKDvWCb6/xgh+Q47OKOIAv8/1KI81CqPaY3GD3K0VArK0+SoACIXOBzdmFb3lGNj1eZl1zWP8t9jR5CqmYFa2yy8+MsR2ayjtZKRDt8qnOlBbvtCGvLYS6UaBnMQD3TA42rQ0VHm4/xReLZtV2bThJKsbxiop8pdl+a+c9ayQR3cYqtoy8eN4+k1SOn58JIuJZxXgxjZaYCGfaaz30fTDTEevN2mooQs/r/aAQt7IWqAVXsb3PJLDIswpCI1xRoAS2rdtdIWya3Pr6gV8aTStLeCTrAO8NpxZl2prAHcinMrsc72XovJHGE3FsHAzVkIGIhLA16mPaD2fKNFyRvfV+oFsinkRkPaJMDdHO9G2PoK5zegtZRkG3Aadhe3oCRZSYvTutXRdBkQPCW4g7mN3xqBz9napIX+GjB8lTnrJNL9Pv
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5144.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(366004)(396003)(39860400002)(376002)(451199021)(110136005)(54906003)(2906002)(38070700005)(71200400001)(33656002)(478600001)(86362001)(52536014)(38100700002)(41300700001)(8936002)(8676002)(5660300002)(55016003)(316002)(4326008)(66556008)(76116006)(64756008)(66476007)(122000001)(83380400001)(66946007)(66446008)(6506007)(9686003)(53546011)(26005)(186003)(966005)(7696005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zf1UspMa/L5fHrRQN/LQMG/SSCaI/W0D/9L8ZyMmMD/qSw0z8VD9G+9E23TM?=
 =?us-ascii?Q?VWX1yaJQHa9uJD4NrSD7U38/dB0O3oqhu3d73Lb0/Z4qdXK7W8b/B+J+McP+?=
 =?us-ascii?Q?u8daC5ryDS1ifvuD4X396G7cwfZR1N7sB7rYj+JOtBPDbUGuwUpzrVsxS2sw?=
 =?us-ascii?Q?TZRibnctKof3UtMBPYkivncmcl3ozdVpzQROVyyp4OjNODepzFdQ6OvwYCrw?=
 =?us-ascii?Q?zX0pcnqi9k7/6SZBz2FijPbVh9ZdHBPtUTR6TZ8E5uBeaPUqUKMOL+GwwFkv?=
 =?us-ascii?Q?8vzjvLqjHXqIVBS5bjhoL4NMPBIINjPLzCWx4WHCYo3gl4ehEIsRis7CJTJn?=
 =?us-ascii?Q?MyLlycFH8ciEUBCTgfGOD2ysd4juncF0R0TP3Mc6a1MPCELIh1ozT7k0b2oa?=
 =?us-ascii?Q?rJVpYlUH1J3/B83Ph8zbqbAqQ3gl4CaUnGxIzEIjpl3M27mU07OA6l6YAmSW?=
 =?us-ascii?Q?vUEytsP2JAvNucq3/3WRMBlbfyN6978wrECnPsyq3q9lkuZxTrnhJ0w6Lxh8?=
 =?us-ascii?Q?rdiLGJj9voJme4oSiD0tJ8GNe1vzXU/O5AUDJpz86fGGMCek+h5A68G54GpT?=
 =?us-ascii?Q?2l0bkrIV/W8+k/iPruML65KiZGkm/ObmqqYA/OwBP7qa020++ItJ3yAfF01w?=
 =?us-ascii?Q?/cPZQy/XYOwxNUGA6Hm93lGf6arQ7oocVOKhE3OXGXAnAgoILITe913+vBw1?=
 =?us-ascii?Q?z2w0w9Lt+Q+GxFsZZRjgVL+V2I1HX1ingGJeFBimSSyvEvyfuVdYbA14oR4B?=
 =?us-ascii?Q?DXIHaM3/3Vrov91/k6+jCFuitm3YSA6/gg5+7dljGs2jvi+SJYVbDwSknzxt?=
 =?us-ascii?Q?UngZ5t/2A+5dXppg9z+CRiZURmb065KNAf42Okw0v7qxbQtlPbSURpBSfGbC?=
 =?us-ascii?Q?5WYnjvUtaABFs1Gonr2mu70xhfu7AzSFW+tX6QJTmWuqmkevuF9cn9UlqOPp?=
 =?us-ascii?Q?O08jxSLr1fNdc1P+4giK/2vRQDY/MkjvnLhKlpebiUd22OceRgKx5DGt7OMR?=
 =?us-ascii?Q?NVdUPlp1qUBwTixgERLr3TbkSgIsV9Zv3iLQR/Jt1knGRhBSvqNRSpAztqKT?=
 =?us-ascii?Q?9rKfov2Ie43yX8qUVDhpVTW3UVTXoNSTyw3j34wOZErPK5EZEVWcji6t8JvH?=
 =?us-ascii?Q?WXkfC8XJRlmTfVb+jpoywpO0vjnIit6tNznafI+sakM67VezeqfB1+/U8lSk?=
 =?us-ascii?Q?4E0y90VIucRcQmnoCVaY3kVSXMmeSk9oLK6ykI5v+tprN+vBYFlUmFcbQBB4?=
 =?us-ascii?Q?PcOwVMH1T/lfX9vv6Zl7xKpoYJeyb64Z/nr4z8RqLkyd8qQYy5Ce2yIqYmAb?=
 =?us-ascii?Q?hMKEz/lPUCxo3q1yMc2MGcZUylrnQfNWmQcigaxabrqrO4OCyU1YtgL/PlGv?=
 =?us-ascii?Q?6DrxSejKERuamZlnNpL+Jg16CpC8hSKH1Z4nP0JY+mHxWVjIr3OmOYO/NgR5?=
 =?us-ascii?Q?o0omB5XTZc7Ds78qEEyCS9jkyE51OpzHrGKfzok19aMfOllh1S+i1RhhJWMR?=
 =?us-ascii?Q?T2axzFaaMWKB8k511NdeNUpSw33X4XPB1O92IqrmL/9fe+y1zlBMKXktPk7b?=
 =?us-ascii?Q?Z4VdSVfSg1lQGjXogaI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5144.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 178d5a55-8064-4a72-be3c-08db65d9941e
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2023 15:28:57.0342
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: o2oB7g3kuHAvo0FPuOhjhE+NhzVJgJaemDJ2f3lBMlx86HozWzdMTWMzP48bys5Q5DXtUZt1O9OdYcMVy11SHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5138
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[AMD Official Use Only - General]

> -----Original Message-----
> From: Paul Menzel <pmenzel@molgen.mpg.de>
> Sent: Monday, June 5, 2023 11:23 AM
> To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; David
> Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>
> Cc: Paul Menzel <pmenzel@molgen.mpg.de>; amd-gfx@lists.freedesktop.org;
> dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] drm/amdgpu: Log if device is unsupported
>
> Since there is overlap in supported devices, both modules load, but only =
one
> will bind to a particular device depending on the model and user's
> configuration.
>
> amdgpu binds to all display class devices with VID 0x1002 and then
> determines whether or not to bind to a device based on whether the
> individual device is supported by the driver or not. Log that case, so us=
ers
> looking at the logs know what is going on.
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2608
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 86fbb4138285..410ff918c350 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -2062,8 +2062,10 @@ static int amdgpu_pci_probe(struct pci_dev
> *pdev,
>
>       /* skip devices which are owned by radeon */
>       for (i =3D 0; i < ARRAY_SIZE(amdgpu_unsupported_pciidlist); i++) {
> -             if (amdgpu_unsupported_pciidlist[i] =3D=3D pdev->device)
> +             if (amdgpu_unsupported_pciidlist[i] =3D=3D pdev->device) {
> +                     DRM_INFO("This hardware is only supported by
> radeon.");
>                       return -ENODEV;

I think this will confuse users even more.  As there will be a new "error" =
message reported.  I'd suggest either dropping the message in init per my p=
roposed patch or just leaving things as is.

Alex

> +             }
>       }
>
>       if (amdgpu_aspm =3D=3D -1 && !pcie_aspm_enabled(pdev))
> --
> 2.40.1