Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5914553rwd; Mon, 5 Jun 2023 10:10:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7vjn9qCVdcKrbTnNA3NJL62TnFMa0B+b3btJhBiB2uYEj+7zXlHtFwfdEowl6w35PfK35F X-Received: by 2002:a05:6a00:21d5:b0:647:157b:cb61 with SMTP id t21-20020a056a0021d500b00647157bcb61mr355563pfj.7.1685985005854; Mon, 05 Jun 2023 10:10:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685985005; cv=none; d=google.com; s=arc-20160816; b=bFCCzUxUsWMAUYjW/fwkg8Y54C5F1KHmJB5q5WmRhPxczh5Vz0bxLB5gXhDXUZC44E C1asZKMVgPdBva9BJT4z8Os1rV45vvpx09hil1kx+VZ2xLmw87Pd0I+0yGM35E61xbC3 G0muofzuHP1jEINo8WC3naJlZCzUfSQBm7ns+rQECnZi1Lqw5AsLWlfwwhCcPSWcDvxr 8M18QQGv/nIZ0g/DIqcgydmM5Y10LI6b0rjSWWgqT3nkKHHmKNFBLfweob+hQqOPgSa6 VYY71NjW0kGdbblUDbDya8D2tmz/Y0dxPwtsJWmehNNAwyCnBVqBOvhs4hjuxzq/E6Qj vwFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=83NktPWyotPnIP6ctRP/lbvydHsK9DrqhUfJFfVVMCY=; b=T0yupHn4N5GeF51JLR4GWlF/LS1I3mBUpO6apw/IgGd7nkEDE7CkGwMJHC1HtPw23+ 7vhuB8bQ+njMzgkNzqU8JbFwKTBH83pkv80NHaXy9LHMIUnlM4d43TDrGGO5KF00pjPz cEhuNCHVH/Jmx+5k0+tGW7p8mniD3+/91XXZJhVz5Ljn6WMeumU97OwVt1MaDyiXI+83 WnNA7oeI8cfDSdKniCjRqS5OSXZG2/M2z/++ILEsphkaXJi5vS/LwbRoRQJsUu7wejbb fCtUGBySysphiWbONhmiykj+KoWa6E3ntZn7FbM79LpEJ3V8f6TceRSMQXZ14SZwaa55 kKpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="Ix/RnCPT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s18-20020a632c12000000b0053fc2857c09si5809039pgs.652.2023.06.05.10.09.50; Mon, 05 Jun 2023 10:10:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="Ix/RnCPT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234586AbjFEQt0 (ORCPT + 99 others); Mon, 5 Jun 2023 12:49:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229825AbjFEQtZ (ORCPT ); Mon, 5 Jun 2023 12:49:25 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62C64D9; Mon, 5 Jun 2023 09:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=83NktPWyotPnIP6ctRP/lbvydHsK9DrqhUfJFfVVMCY=; b=Ix/RnCPT2/sRZIFzldq0mqWSyV vdUg1T0JTIVInWRDJMfB9yqmx5rskWb8olvB+pa9YI+lYTAGYqQ+fKuVD2rSJgOlVOYyTj3PGaDHP 1ipA5LbMPchF5C7QrZTRp6eP9Qc5e32XuEGr8o1U8ILq+iXvDi7srxE4Eif76559b6Ac=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1q6DOK-00Ev7j-OH; Mon, 05 Jun 2023 18:49:12 +0200 Date: Mon, 5 Jun 2023 18:49:12 +0200 From: Andrew Lunn To: Michal Smulski Cc: "msmulski2@gmail.com" , "f.fainelli@gmail.com" , "olteanv@gmail.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "linux@armlinux.org.uk" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "simon.horman@corigine.com" , "kabel@kernel.org" , "ioana.ciornei@nxp.com" Subject: Re: [PATCH net-next v7 0/1] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x Message-ID: <87a5491e-6697-48d3-94fe-aa2c6f5ab129@lunn.ch> References: <20230605053954.4051-1-msmulski2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 05, 2023 at 04:32:03PM +0000, Michal Smulski wrote: > Andrew, > > I will remove this line and resend v7. This was a mistake on my > part. However, could you clarify on what is the best way to let > reviewers know what changed between different version of the same > patch? It seemed to me that changlist should not be part of the git > commit message and hence I decided to add 'cover-letter' email for > each new version of the patch so that it would not be part of the > applied patch to net-next git repo (but it would also be easy to > match changelist email with patch email to people reviewing latest > patch) Some people think the history is actually useful, it shows what has been considered etc and the patch matured. However, anything text after the --- marker in a patch will get discarded by git am when the patch is merged. So you can place the history there. Andrew