Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230601213319.3304080-1-arnd@kernel.org>
In-Reply-To: <20230601213319.3304080-1-arnd@kernel.org>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 5 Jun 2023 19:16:39 +0200
Message-ID: <CAJZ5v0gvs=3GVE_1GpP1mKsQAkc0+gC6AQYoWP7r+60kUtjfAw@mail.gmail.com>
Subject: Re: [PATCH] ACPI: s2idle: fix section mismatch warning
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Len Brown <lenb@kernel.org>,
        Manyi Li <limanyi@uniontech.com>,
        Juergen Gross <jgross@suse.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Simon Gaiser <simon@invisiblethingslab.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Jun 1, 2023 at 11:33 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The acpi_sleep_suspend_setup() function is missing an __init annotation,
> which causes a warning in rare configurations that end up not inlining
> it into its caller:
>
> WARNING: modpost: vmlinux.o: section mismatch in reference: acpi_sleep_suspend_setup (section: .text) -> acpi_s2idle_setup (section: .init.text)
>
> It's only called from an __init function, so adding the annotation is
> correct here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/acpi/sleep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index 72470b9f16c45..552adc04743b5 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -840,7 +840,7 @@ void __weak acpi_s2idle_setup(void)
>         s2idle_set_ops(&acpi_s2idle_ops);
>  }
>
> -static void acpi_sleep_suspend_setup(void)
> +static void __init acpi_sleep_suspend_setup(void)
>  {
>         bool suspend_ops_needed = false;
>         int i;
> --

Applied as 6.5 material, thanks!