Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4e27af47-2a4a-a976-32a9-bb0f0868cec1@gmail.com>
Date:   Mon, 5 Jun 2023 19:49:01 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH V6 0/3] nvmem: add fixed cells layout
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Michael Walle <michael@walle.cc>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
References: <20230327141611.25131-1-zajec5@gmail.com>
Content-Language: en-US
From:   =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
In-Reply-To: <20230327141611.25131-1-zajec5@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Srini,

On 27.03.2023 16:16, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> NVMEM bindings received a new feature recently: layouts. They allow
> defining NVMEM device content in a separated DT node named
> "nvmem-layout". That improvement results in cleaner and more generic
> bindings.
> 
> New bindings & drivers should use layouts design. If possible we should
> also try converting existing bindings & drivers to layouts.
> 
> This patchset allows defining NVMEM cells in a new way (using NVMEM
> layout feature).
> 
> This deprecates support for defining NVMEM cells as direct DT device
> node subnodes but IT DOESN'T drop support for that.
> 
> PLEASE understand what this patchset handles. It adds new & preferred
> way of defining NVMEM cells. This patchset does NOT meant to:
> 1. Convert ALL existing bindings or drivers (it's a task for later)
> 2. Add support for new extra features (like multiple layouts)
> 3. Break any backward compatibility (it WON'T happen)
> 
> V5:
> Support "fixed-layout" internally in NVMEM core (see PATCH 3/3)
> V6:
> Rename function & add unevaluatedProperties

This patchset seemed ready for 6.4 but I guess it has missed your window

I see you already picked some stuff into your for-next:
https://git.kernel.org/pub/scm/linux/kernel/git/srini/nvmem.git/log/?h=for-next
but I don't see those changes.

Can you pick this work too, please? I would like to avoid waiting
another month before getting this upstreamed.


> Rafał Miłecki (3):
>    dt-bindings: nvmem: layouts: add fixed-layout
>    dt-bindings: nvmem: convert base example to use NVMEM fixed cells
>      layout
>    nvmem: core: add support for fixed cells *layout*
> 
>   .../bindings/nvmem/layouts/fixed-cell.yaml    | 31 ++++++++++
>   .../bindings/nvmem/layouts/fixed-layout.yaml  | 50 +++++++++++++++
>   .../bindings/nvmem/layouts/nvmem-layout.yaml  |  5 +-
>   .../devicetree/bindings/nvmem/nvmem.yaml      | 61 ++++++++-----------
>   drivers/nvmem/core.c                          | 32 +++++++++-
>   5 files changed, 137 insertions(+), 42 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/fixed-cell.yaml
>   create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/fixed-layout.yaml
>