Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33481784-f1c8-cc0f-4c68-404efcf2258d@linuxfoundation.org>
Date:   Mon, 5 Jun 2023 13:26:49 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and
 repeating outputs
Content-Language: en-US
To:     Christian Brauner <brauner@kernel.org>,
        Ziqi Zhao <astrajoan@yahoo.com>
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20230523232207.363136-1-astrajoan.ref@yahoo.com>
 <20230523232207.363136-1-astrajoan@yahoo.com>
 <20230524-tausend-erlitt-b3163dd1dd05@brauner>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20230524-tausend-erlitt-b3163dd1dd05@brauner>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/24/23 03:12, Christian Brauner wrote:
> On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote:
>> An output message:
>>
>>> # # waitpid WEXITSTATUS=0
>>
>> will be printed for 30,000+ times in the `pidfd_test` selftest, which
>> does not seem ideal. This patch removes the print logic in the
>> `wait_for_pid` function, so each call to this function does not output
>> a line by default. Any existing call sites where the extra line might
>> be beneficial have been modified to include extra print statements
>> outside of the function calls.
>>
>> Signed-off-by: Ziqi Zhao <astrajoan@yahoo.com>
>> ---
> 
> Fine by me,
> Reviewed-by: Christian Brauner <brauner@kernel.org>

Thank you. Applied to linux-kselftest next for Linux 6.5-rc1.

thanks,
-- Shuah