Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Jun 2023 15:35:46 -0500
From:   Nishanth Menon <nm@ti.com>
To:     <sabiya.d@mistralsolutions.com>
CC:     <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <afd@ti.com>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, Dasnavis Sabiya <sabiya.d@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am69-sk: Add eMMC mmc0 support
Message-ID: <20230605203546.uq77hmu627socvis@uncaring>
References: <20230605174551.160262-1-sabiya.d@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230605174551.160262-1-sabiya.d@ti.com>
Precedence: bulk

On 23:15-20230605, sabiya.d@mistralsolutions.com wrote:
> From: Dasnavis Sabiya <sabiya.d@ti.com>
> 
> Add support for eMMC card connected to main sdhci0 instance.
> 
> Signed-off-by: Dasnavis Sabiya <sabiya.d@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am69-sk.dts | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> index 4b7d9280d76f..ab8ec2cb396e 100644
> --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> @@ -22,6 +22,7 @@ chosen {
>  
>  	aliases {
>  		serial2 = &main_uart8;
> +		mmc0 = &main_sdhci0;
>  		mmc1 = &main_sdhci1;
>  		i2c0 = &main_i2c0;
>  	};
> @@ -191,6 +192,14 @@ exp1: gpio@21 {
>  	};
>  };
>  
> +&main_sdhci0 {
> +	/* eMMC */
> +	status = "okay";
> +	non-removable;
> +	ti,driver-strength-ohm = <50>;
> +	disable-wp;
> +};
> +
>  &main_sdhci1 {
>  	/* SD card */
>  	status = "okay";
> -- 
> 2.25.1
> 

Reviewed-by: Nishanth Menon <nm@ti.com>

Though this will probably need a rebase on top of
https://lore.kernel.org/linux-arm-kernel/20230602214937.2349545-1-nm@ti.com/


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D