Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp6244481rwd; Mon, 5 Jun 2023 15:34:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7m70ITWm4umxrqRNElMZC4OvQJ0cKlwOzLe8KD6mewcWVoB0GUZ+SO3I+ziu0GgH0e1SV4 X-Received: by 2002:a17:903:1251:b0:1b0:4527:3716 with SMTP id u17-20020a170903125100b001b045273716mr331634plh.15.1686004452056; Mon, 05 Jun 2023 15:34:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686004452; cv=none; d=google.com; s=arc-20160816; b=sxgaO1he/GKnQ96JbVqJN4c/wUkUUqljSqIR2/JmbBvQ1ljV9d5mh3M9xt+Yu+pW/2 Hm77MyBY4cMNcLqrhPMpl/fDU7aYaDdJ1iE+/2LAQd3JKkVjYDh0BlJ4+CJtCnrRKXIb UBekNNNtY7kDiD5CTiamZVvYEj81tUbHzqP0xGy3cswjADgQs8ZNGc+M4/KCUEZoGQ1s w2kC7a1rQTPMBB6mSHcPsi2nPN0kpAkzHteCKJx0GBY4oQj+O5H7auKgfBaK460DylEQ FoG4DYy1BOy8eE/AzwLjzTH7BUQ3QBtLJOlOZBXe8bSoLmH2Oun888QyqY/6oXp0gAzg Hz4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=yUCzq2HsaSRGY/z9Th5d3wLk704JxEIfRF7A/bzoBII=; b=F31dZxHWOyx+F35zMCuMgZhSvE0rIuaQM1ZHEb/13p6ieQUcFmcbN7TK8IeR5sW2B6 jB4GlfVT5NAf+gR/PfuO1yp1cJNV+sqDeaUl9O1K663RBBgM72fhO3eap+BFkjU3HJ4N mPQUFldxj2IaOtjRbvK3jlu34Nuf5hE7JuwLZmDRUB9BRGHGKXsqJfH/fDwGVWceqtZ4 Ah/AlGxEni7el/MvNPHcqNW8PhsfAiy9JhRLAa5sISfOwnuci7o8mu2astffJawry/qw XrPN+uR/iXDj+eyP6cL21uJBx8IZ/J5IR8XYH3ZqNNNBFTLTTjHIH4kaYW65ytoTBbGa 3MDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EuIxGYJw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lg13-20020a170902fb8d00b001b0499f7a90si5832387plb.513.2023.06.05.15.33.59; Mon, 05 Jun 2023 15:34:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EuIxGYJw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233030AbjFEWQb (ORCPT + 99 others); Mon, 5 Jun 2023 18:16:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231764AbjFEWQ1 (ORCPT ); Mon, 5 Jun 2023 18:16:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4717510B for ; Mon, 5 Jun 2023 15:16:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD06562B4C for ; Mon, 5 Jun 2023 22:16:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2F86C433EF; Mon, 5 Jun 2023 22:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686003383; bh=WVGdFDvKNz9o0nDSSbiXtPP3pwqKvj5fwhy7WCAwqsk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EuIxGYJwXI3jO5VWQZminZPOdmYJmtywgAGDVctJnc9rwDAMtZPjtHnlsuAtZoA3R PtNOUYurq4Z+C0wbcfw30lchccWv9CL/1sBsOek7BDPjxXK83vOHs4URK2iR3Exifk m8kv2VgpT4eZnBKu+Ij2k4bv6cHklOa7fEqURCLgszBBr1BtSlxxEm5SbYxEtOOZjl xMctHR3t7qagKfDzRa1TRWjQUHBt21HqE3lCTPqbql1+ycLXPl4tiKB1L5TkCdRqtW P6jKacFg8kecBXmF/Vb0U44TZa9+872KXkxZi5HClJV3p3b6OW84lC71N1j8EA56LF JbNdreTB9F2sw== Date: Tue, 6 Jun 2023 00:16:20 +0200 From: Frederic Weisbecker To: Anna-Maria Behnsen Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , Steven Rostedt , Sebastian Siewior , Giovanni Gherdovich , Lukasz Luba , "Gautham R . Shenoy" , Tejun Heo , Lai Jiangshan Subject: Re: [PATCH v6 08/21] workqueue: Use global variant for add_timer() Message-ID: References: <20230510072817.116056-1-anna-maria@linutronix.de> <20230510072817.116056-9-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230510072817.116056-9-anna-maria@linutronix.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Wed, May 10, 2023 at 09:28:04AM +0200, Anna-Maria Behnsen a ?crit : > The implementation of the NOHZ pull at expiry model will change the timer > bases per CPU. Timers, that have to expire on a specific CPU, require the > TIMER_PINNED flag. If the CPU doesn't matter, the TIMER_PINNED flag must be > dropped. This is required for call sites which use the timer alternately as > pinned and not pinned timer like workqueues do. > > Therefore use add_timer_global() to make sure TIMER_PINNED flag is dropped. > > Signed-off-by: Anna-Maria Behnsen > Cc: Tejun Heo > Cc: Lai Jiangshan Reviewed-by: Frederic Weisbecker