Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <17f2f270-abff-8db7-c91e-bece1a61254a@infradead.org>
Date:   Mon, 5 Jun 2023 15:41:55 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v2 5/5] block: CONFIG_BLK_DEBUG
Content-Language: en-US
To:     Kent Overstreet <kent.overstreet@linux.dev>, axboe@kernel.dk,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
References: <20230605212717.2570570-1-kent.overstreet@linux.dev>
 <20230605212717.2570570-5-kent.overstreet@linux.dev>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230605212717.2570570-5-kent.overstreet@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 6/5/23 14:27, Kent Overstreet wrote:
> diff --git a/block/Kconfig b/block/Kconfig
> index 86122e459f..611dddb59c 100644
> --- a/block/Kconfig
> +++ b/block/Kconfig
> @@ -165,6 +165,13 @@ config BLK_CGROUP_IOPRIO
>  	scheduler and block devices process requests. Only some I/O schedulers
>  	and some block devices support I/O priorities.
>  
> +config BLK_DEBUG
> +	bool "Extra block layer assertions"
> +	depends on DEBUG_KERNEL
> +	help
> +	Enable extra assertions in the block layer. Currently this is just the
> +	bio iterator code, but may be expanded.

I see that block/Kconfig isn't consistent about indenting help text,
but Documentation/process/coding-style.rst says:

10) Kconfig configuration files
-------------------------------

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.


so please add 2 spaces after the tab at the beginning of the help text
lines (but not the "help" line itself).

-- 
~Randy