Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp6598284rwd; Mon, 5 Jun 2023 22:16:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7MIDz3Mpf7nTpi6U8yuYCidXCrlA9Z0BRLe3aigF/yvUcUDdhcHOcUgUBWCb1d37cBkqIw X-Received: by 2002:a17:902:f546:b0:1ab:1355:1a45 with SMTP id h6-20020a170902f54600b001ab13551a45mr963002plf.30.1686028567932; Mon, 05 Jun 2023 22:16:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686028567; cv=none; d=google.com; s=arc-20160816; b=G7QzkSijinu6ucf1o1S1zOFj+86vIGKw7uR1pXVkcSt/6qUfyVGUYrprbxDxv2PlmX xdCS8lNX8SfmtVUvp8CmYhxpmjAMykvn/tiRzDJmIJ7vNvylvYZpf7JIm687XE0jLhjE BktdWh3pP6VcgT+le2cwn6+wtBgmf5e92xA00/EcLp59UZ/4p8RmzcPKWshOaVj1F9++ ApnWWBcwHzVunyyClJ2EhzUdKE66+hlq1SV+gXpW87w5MZAKFwOygklY8VFQc6VNKl1t 9dXWNm/Sq8qnRfTft69nEAA9DcEaq8tKckT/LWJH01XTSAAcy8sNLVMzCK/Uu2tHFs6k UKHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TCpyJJTYhZ4iqYFhG3t37jQKLKmeT9J7D74n/XMpCCQ=; b=hM3oiG1yqUPU/HtUENxJkt3x1/UbZkebXM0nW586Xb/H37EYqqNWR/n/OkoFXCnL4A oOAx0PdaNStMhQyMHHWhgV2X1fn4zbMXxpcB3doNPQX+03J0cXSCwGSbnEwT9xkgdhDQ /b4kWKBoVcmmfVSk2qaMQIw3yAFYIZb7VrnkAM0dIA7PuiZvTCLwfJRu98VDKLIj4iXq 0vccXEXdcVu1Mnh4/mfobbOuTYqGNTENi78cgV43V2uBikk88khosoBUr4Vky6rNNKZE l6mylnBdY+fdkwObwlewty1xcwfnG+8Ypec6bPhALVWRe1IKOALZe3BYLjM3GwaiqadZ 9MQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FHJswNyF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n6-20020a170903110600b001a1a9a1d336si6766611plh.206.2023.06.05.22.15.55; Mon, 05 Jun 2023 22:16:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FHJswNyF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234316AbjFFFLP (ORCPT + 99 others); Tue, 6 Jun 2023 01:11:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231223AbjFFFLM (ORCPT ); Tue, 6 Jun 2023 01:11:12 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E39C9123; Mon, 5 Jun 2023 22:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686028272; x=1717564272; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/y9Ibxhn7QI1vqH8tx8k3cKEEBl0vnbxxYlUaZcgDRU=; b=FHJswNyFomWiGE3BaoOsZeUwTYi9fe0iQlETjseD0OC3CdRhW5NwQK9K Bl3LjR6KRp8b1Q/W4+IouOvXir/5CJIn69hYU8pW6rS8F2VkneiSwEMJp u3KNO15f/Kplu4pygjWzxaTYQJ5AmnM7jUvknxawq3kvgqyHuZ1DufIXk czQZ3oifhMkFCr1NH44eAa33rGguvezsm96bEOzisZaN1NQpU9KS18QbF QvAxDl6QkexkWpGtOOujMkv3XM/OMuDms8DdDA1dgIy/r8yZMtQjgcG19 KD8Ksf74cCRtGvU76znBSwoUqjdZo2nUI04HyXk/Zt+tQn0UWsSkeAoQE Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="336923252" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="336923252" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2023 22:11:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="833075953" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="833075953" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga004.jf.intel.com with ESMTP; 05 Jun 2023 22:11:09 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 8937734F; Tue, 6 Jun 2023 08:11:16 +0300 (EEST) Date: Tue, 6 Jun 2023 08:11:16 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Walleij Subject: Re: [PATCH v1 1/1] pinctrl: cherryview: Return correct value if pin in push-pull mode Message-ID: <20230606051116.GU45886@black.fi.intel.com> References: <20230605143734.73434-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230605143734.73434-1-andriy.shevchenko@linux.intel.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 05, 2023 at 05:37:34PM +0300, Andy Shevchenko wrote: > Currently the getter returns ENOTSUPP on pin configured in > the push-pull mode. Fix this by adding the missed switch case. > > Fixes: ccdf81d08dbe ("pinctrl: cherryview: add option to set open-drain pin config") > Fixes: 6e08d6bbebeb ("pinctrl: Add Intel Cherryview/Braswell pin controller support") > Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg