Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp6603903rwd; Mon, 5 Jun 2023 22:23:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6nC/0m7YUEL+OcOBc2jxb4SI6weNg0mS0tzZRAIImF6/4kxK0M/jx+JLDI6etL13gPnv8i X-Received: by 2002:a05:6a00:2403:b0:652:7b99:df30 with SMTP id z3-20020a056a00240300b006527b99df30mr940678pfh.25.1686028980056; Mon, 05 Jun 2023 22:23:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686028980; cv=none; d=google.com; s=arc-20160816; b=tn61cgkgk8BdRS0Je0UJMaYq5qRgQd2Thg8OKSRLm4JNWd4cw45blfWc1QDWVdx/vg XnmtPY6s80xhhGvpza0xg3qZSZirNdCCz5Z/w66wMq3pp+zPSJtV5tgRn6VKbffYZTre 4myVIaFrNfquqFothAMzUttBVO2xJ0MRQen2TrzmhtZULzIT5AHDb+f/UZ0vlL3L4kd5 FPYK7UajtNc5OKhjUKtMpX5xSros0Gtp/jctoKbsIxm0FXXO9GMaWv7RqFzSwKhCGNYl NJd2NXrlN/Gy1K1mrUvVeB1wTnQVjm4TTgOsdPu30zJBSLhO7WC+RC+3tqC7OlHCFHcG MjVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=k0UXAmGDtCgvZm/0RV/B2gZ6eOCvL6pLbTpYbMdbmOs=; b=VGCkqCImtTyRF/duUtewIqoRfIvMTtIXn8HD3BsWEz5o6XiVgl9Sllw2bn5jVbKYpg 1tzg9BWOxCcvmaIV+bNOhtdFsy7gDSrZeE/6rlis01zuX6tmMvSM8X3ERFV6xjqNQypd D8PX4L/Aq5flwZouE/w0L4EPxYHpBTCJHbGVf51JTS4zo+QM1/9Elg3c2VOCj/yuc0c0 m9q4CjhQb7FPKrK949lBK8Oq3G9mfoOxmAivG79ygcuVoxs+oTMq3LHQWzpnNrP8+Ql2 HlkMkTckvY1mUQL+oXdC/QK11g6Ph+CPLgx2/pLMW9V25xM/I3fN2oa0DfMgx8IF9Ns2 8VNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dsjGxcMQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 67-20020a621746000000b006600f3102cesi662084pfx.188.2023.06.05.22.22.48; Mon, 05 Jun 2023 22:23:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dsjGxcMQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234375AbjFFFMM (ORCPT + 99 others); Tue, 6 Jun 2023 01:12:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230499AbjFFFMH (ORCPT ); Tue, 6 Jun 2023 01:12:07 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D7CC19C; Mon, 5 Jun 2023 22:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686028325; x=1717564325; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TbfrnAGzn1jEvjRTj+1UlLHPxrWqY/OLvMihFNAckWo=; b=dsjGxcMQxdIwKwnfd2E6p+NxO/DwDxCIBPmUsTpc92QgmkgCv01XfO7u MuNTTvgHlI8CYtQUjBZJZ+F6g2aoahVtA1e9DmuUYsVZEbgHqVuOO53F/ yYur02s0BgOksfUkEVyNr3u0jNJSZ/bjGrEtQHQ/n76kAhqFzxUyWwcQu VLt0dcfGnw7tmB2gMLT71hem5e9ulG+g7lJi3UfrpwAeli+KxN6afHWi0 6JTlgG5aSE6Oui3/adu/0jhHaLDqt6v18E4YJwARm7UsOgLOWNDd+Lvot zwj2urmkC5QZ2Mrf6O79mdc8QAi58s6b8IdXBF4B3ukZcqPpq1NqHZIaH Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="336188264" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="336188264" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2023 22:12:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="1039036014" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="1039036014" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 05 Jun 2023 22:12:03 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id BE06C34F; Tue, 6 Jun 2023 08:12:10 +0300 (EEST) Date: Tue, 6 Jun 2023 08:12:10 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Walleij Subject: Re: [PATCH v1 1/2] pinctrl: merrifield: Fix open-drain pin mode configuration Message-ID: <20230606051210.GV45886@black.fi.intel.com> References: <20230605154509.11616-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230605154509.11616-1-andriy.shevchenko@linux.intel.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 05, 2023 at 06:45:08PM +0300, Andy Shevchenko wrote: > Currently the pin may not be configured as open-drain in some > cases because the argument may be 0 for the boolean types of > the pin configurations. Fix this by ignoring the argument. > > With that, allow to actually restore pin to the push-pull mode. > > Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg