Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "jiangshanlai@gmail.com" <jiangshanlai@gmail.com>,
        "Kang, Shan" <shan.kang@intel.com>
Subject: RE: [PATCH v8 04/33] x86/traps: add
 install_system_interrupt_handler()
Thread-Topic: [PATCH v8 04/33] x86/traps: add
 install_system_interrupt_handler()
Thread-Index: AQHZa4hMKbfML9J2EE2n9O+e9+6txa98QHyAgAFcNPA=
Date:   Tue, 6 Jun 2023 05:46:32 +0000
Message-ID: <SA1PR11MB6734F829654B94EA23FE0994A852A@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20230410081438.1750-1-xin3.li@intel.com>
 <20230410081438.1750-5-xin3.li@intel.com> <87y1ky70ce.ffs@tglx>
In-Reply-To: <87y1ky70ce.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vRrutTzHzMX2TzSTSyjad8Ck2WCfL0Y9pNKOfmKK3jsmdqWDKPO59Bqzm6Ro?=
 =?us-ascii?Q?/JcMbEqEFahHHJgckE/C2+fGz6yCwHkyBBMep5CAeweLkic7xW2Cf0bC4/CB?=
 =?us-ascii?Q?Wp196miyGVOd6n2CXnOLW5120fVRBABujYVuZ/f2Je7AH0f6wnn1aF9Tnjah?=
 =?us-ascii?Q?p0kJpDCHncvxMdRyG0a8TVnwzdcXbWJQIKUjK7T02JO8ECsV0/GM2+Ybdgvf?=
 =?us-ascii?Q?ZDjdEOA3Lsbu+cvoRkhvg+mRyjab+UN4ssAy5uD4i0QDk79EZJ4wWi8sYiGg?=
 =?us-ascii?Q?XAnsXrJA/ZDJ0Q8W3SuOJzGDqglats9j1CiJSy8LJW8NS3+f3lVD3A222UB0?=
 =?us-ascii?Q?sEwusMTt99dh7AFnLfRKb2u4sVl3M2l0/WoBWAQrsC4zHCDdhas3hmYhxjIU?=
 =?us-ascii?Q?tg1gDgiFMO+piA4I7nR3z9ooYpRd1WDxypyDSTWQCxVmiKB4Kjd6csoAcBrr?=
 =?us-ascii?Q?DkLyuwGrF3xvMQG6hCpatsOLJUhp9nUWfb/0zISIel3Jx60WrpLNUrGo59tW?=
 =?us-ascii?Q?JI5r/AQW9wDZLxiPNkLPgNoqM+GtLCpBKG2KHP6rLrZj6WKQnHDXuUXp6DBv?=
 =?us-ascii?Q?s7lwXl4RVrImkmy33G+q9hK5TtfbD1BriAxN9wvYggbSmNrNPWckC9/wXoYD?=
 =?us-ascii?Q?fRVSQPtQfbOqyHxUlptQs0bivAc+1tPOCnoY7dTMWLxY6zBxlNM1geXAFxaA?=
 =?us-ascii?Q?Arcc2rsy014TMdRLq47XTXqNXoDJFHSqvUvrgc4r8vRe+XfgvNebUpNVsh9E?=
 =?us-ascii?Q?puGtg7rJeCDE90BKzQZ7R+m7VKB6fJP2oN4qF1rNNKpKBHLunrSqp7OuXuEA?=
 =?us-ascii?Q?hDhlhYKnXt/FZeRhomXzAZv6dXZTGPtD2ZIiVRiz0RdYJjXYSS3ihfu0oWWM?=
 =?us-ascii?Q?h5cb0IWVWyuxLSOXFz2MZp6819dF4XkDMh7v5k6AYDiakmuwd1r8nAxRoGB8?=
 =?us-ascii?Q?ztyN462dYUUE1vGqeB4JuwlTjaoha8dTxmhzdC2zhCk6UeuOkHCcYBFO8dX6?=
 =?us-ascii?Q?cozPijcRvKVaR8Ti8Yr15aiZYA/09LSfCG96vxUflK2E5uSh6U5YgQQmEh7f?=
 =?us-ascii?Q?6lT3QSloOfSOo1suPXxl0U+SJLHgCun76CXG0/yTKnyEsv2MZ4D3kshiBzJJ?=
 =?us-ascii?Q?RPMsl4TR6GdlOeMVsmefLSJkEvdXM3si5SK0vPsny8DWOJ2AtVot3ZbLWgo8?=
 =?us-ascii?Q?QiN9N+9SCTAvPOhhzzs4Yqg9A+ms2aof5AGFJxGUqg5IFxmeXq9f7L1P56v7?=
 =?us-ascii?Q?/MfzYU5XPnlY1zwnenNwSPBEMJZxbeZM/JXgPfYQTk/vMkJTADajB/DdaHOU?=
 =?us-ascii?Q?25gG5BhCpEKneysZK7QKyC1Ry1TasFZ2y4W8GLBCpro8NQrS/luUlHjjSmLK?=
 =?us-ascii?Q?0+uM9Y5ijbqRDcq5YE8d7h9y8zqqH9f7tVnXqqGETed5gHnd5RI8sicJmsiw?=
 =?us-ascii?Q?xCx/myQXwEXWJFKqwD00uiiMbfzTWQsXLCArHtJcn4jhZ0giUpo1w2IQRibY?=
 =?us-ascii?Q?JsVvjUrgsp+xBvDoLU8+dHs2MBiVLg3vNJ3a+AY5f7uUX3d1IVQ6XhcFdNjT?=
 =?us-ascii?Q?WOJp+NjUhmfP0Yba32I=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20a5271b-a85a-4da0-9d44-08db6651623b
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2023 05:46:32.9404
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mwgsBRsW5sCU4YCWtWUcsGbG6vm9PlhbWh45dq9j5WX3gU9NTNI2SRAgwJ54a/QVAKvbr90BE1hSE2WPtd/ecg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5009
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> #ifdef CONFIG_X86_64
> static inline void sysvec_setup_fred(unsigned int vector, void (*func)(st=
ruct
> pt_regs*)) {
>         ...
> }
> #else
> static inline void sysvec_setup_fred(unsigned int vector, void (*func)(st=
ruct
> pt_regs*)) { } #endif
>=20
> #define sysvec_install(vector, func) {                                  \
>         sysvec_setup_fred(vector, func);                                \
>         alloc_intr_gate(vector, asm_##func);                            \
> }
>=20
> -	alloc_intr_gate(HYPERVISOR_CALLBACK_VECTOR,
> asm_sysvec_xen_hvm_callback);
> +	sysvec_install(HYPERVISOR_CALLBACK_VECTOR,
> sysvec_xen_hvm_callback);

This is a better way, and I will do so in the next iteration.

Thanks!
Xin