Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ea3548ae-de27-fb67-5b2a-34aca006005c@nvidia.com>
Date:   Mon, 5 Jun 2023 23:23:15 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v1 2/3] selftests/mm: gup_longterm: new functional test
 for FOLL_LONGTERM
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org
Cc:     linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Jens Axboe <axboe@kernel.dk>, Peter Xu <peterx@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>, Jan Kara <jack@suse.cz>
References: <20230519102723.185721-1-david@redhat.com>
 <20230519102723.185721-3-david@redhat.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20230519102723.185721-3-david@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1VUKzlqS3VVU0VDUnRWVVdvbXVjdGtYTHR3Q1ZTcEhxUVQvaHYrMnNYU0dx?=
 =?utf-8?B?aFBjdHdYNisvc3RIWGUxMFZMOFd6OHFjVXZ1ZDIyRGN1V3JBSDd2VG91cHVn?=
 =?utf-8?B?R2kxNldVN0JlcFMxZVppRGczUEhaTENFMVlmUDZGdEgxNGcwa2wzdngrMVNS?=
 =?utf-8?B?d3lwVnNJdmk1L1pPbktBY2RRVnpRR3RRTHhnTSsyNE4vV1RaMXFNcW5XVFN4?=
 =?utf-8?B?SWQ2TDh6TC9HRlB0OVd0eWZKWFFidGZVblpxMjNYQ3E2OEh1QzB2dHBTN2Ix?=
 =?utf-8?B?bGJIMFNMcVUzSmVKc1JCSXV4Yi9qRU9mVDY1KzArSVZtUUkxODZyNDNiWEFJ?=
 =?utf-8?B?a29YOCt4ZmRDUkpUaFRuMEdtR0pwWEJsUlhld1VKeit3bXRlRmRGUmlHUU90?=
 =?utf-8?B?cVE2SVkwb3U5S1ZaMVlBOTNSeEVzN1ExNWZ1dktQdFdXZGFBa2dhTHVwRUdZ?=
 =?utf-8?B?U3BRVFMyQklLR3BSNUZFUlVBbmRwNXQyUHd0UHBqbHVlSUR2dlQvSU5JcTRZ?=
 =?utf-8?B?ZFUwenQ3eDU4ZU1oVDFVWXZMWXZodVIxMGRER1BlZ2FMUGpmamdlMXlxVTdQ?=
 =?utf-8?B?NUhqdllET2dldFMyQ2hFQUJhbDhHNHhvcmE2WGN4VU1oZ3kwdVFTdEtHWVl0?=
 =?utf-8?B?WVhkVEVPWmtuRFdwKzcxR0FiYjNudU1PT2Vqa2Vsa2ZmRXJ2Q2RVYnl3MTFW?=
 =?utf-8?B?aEw1eGRJMG5FaFRNSHZNenYwODZHd3ZyYktmVlBKb2RhNndtMlFqcFVMb0xT?=
 =?utf-8?B?b2JzNFFUVFQwK3RBV3d4ODlKR1NsRTJVTm9qMHR3RW8rWFphOUZvNHRMZDgx?=
 =?utf-8?B?M3J6UkJYVjJVakJIQlR6V0l5RkhyNjB1eDFrMzVpYnI3eGNTbXg2aWtCYVNK?=
 =?utf-8?B?RSt4ZEM1bXY5NlMrTlBjT3BxZDQwbW9FUExXdUZnLzg0NGJrZGhzem1FNkQz?=
 =?utf-8?B?UXVBcGV2UGRTU3NUQUFTUDBOQnpJU0FnWktLMDU0dkVLM0wzYkcwVTVPNHdR?=
 =?utf-8?B?Ri8zMThIWUN4WUovbHZIVUsvcEhaN1FKL0g3NUM5Z0I0KzFNeEpyQ05NUm9n?=
 =?utf-8?B?RU5QRytEQzd1K3ZReE9HUzJmc09XYnZ4N2JwUFoyYTNqS2pUTnd5VnM1ZHNE?=
 =?utf-8?B?aEV1bnJQbW4zSitDTkZJUUFadHBNcVJyMTFoVGN0ZTBldlpyOFNoRDdqODNH?=
 =?utf-8?B?dWVLcnJuSjdYRTBReTQwYTRwUGdHUzN3ano0SXhZTCs3TEZ3dmZiNFE3NXJ2?=
 =?utf-8?B?T3QvMzVSem04bS8vbXdtWjNHVHY3YnlST214NUhDZnJ5QzV2Mk9MSnhJVld4?=
 =?utf-8?B?RTZZd2FrUFgrSDBGZkt3OFNDd2c0clZTSkZLdkc4dldjazJGd2xLM1hJbkhL?=
 =?utf-8?B?ekhlWjVvNHpYRDZRYTBteWJRMkZqTWIvTUlocmtNVDNEenNiNk5ZZmRtMTJl?=
 =?utf-8?B?bGlUeWsvaGI3MWRWd3k0bUVLd2w3VGRKS1JIUGprRzJ1aGplTWFxdG4wTjM2?=
 =?utf-8?B?NEJVSWppQk1QdFAyZnBMSzlxV21UTlFWYzM2Q014UFEyWXdybTFKUXZxYm9a?=
 =?utf-8?B?VlJNNTBBM0J1Y1orTHF1THBzcTc3QXZhQWNCalozWGFWdjVmZXczdjZ0empn?=
 =?utf-8?B?a0drc0RRdE4rd04zbVBtMitwMENZTSthYjhnMzhRZkFvcHZJRW53Tmw0MVJW?=
 =?utf-8?B?QUN5ZW9hSEU4K3lFYTBjeDA3TDdNMzFxL1R0dEo3Q0lmRVlpNHMxOWh1RkJl?=
 =?utf-8?B?a1JJVXBqRjM4eWt3emV3REVtWGZramY1VE92KzJtTTlpcmgvdXZzWEtUYnI3?=
 =?utf-8?B?T0E4Q25ndjFPbzIvaDFrN3lxWDRQZlBNV0k4a2N3N3E5dnM1eWhYLzNxeUpm?=
 =?utf-8?B?dm94S2w0QXc2cXJTdm1hcmE1WWxEUHB0SnZvMy9TcWpDZDdFZ3FSZWp1VWlF?=
 =?utf-8?B?eHdjc3E2dHpwbjBXSkZsWjN1akxKYWFpSHBLajFmc055SDVRM0NxN1pqbWow?=
 =?utf-8?B?OHIvdXF3SjA2UlM1RGlxVnRxTXppbTl5c2RGNnEwVGE2dFBXQ3RKUC9POU04?=
 =?utf-8?B?Y0NUWUVtSTZpTHk3MU15Q2FGbkVxNFZqYzdEbno0NWkvamlKL1puODdCdHAx?=
 =?utf-8?Q?F0wYjHrgXCvGv6Eb0rR4LnfLP?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa142a1b-0981-4b55-87e0-08db66568529
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 06:23:19.2729
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aPoT5gzM5XSgth2rlMR5P3Hvm3EOlpGOYPk1JDiy6CpAovrPHlIHN1eDPJOq+orrQXqHW3+/eA87+c3YbcCS8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4973
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/19/23 03:27, David Hildenbrand wrote:
...
> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
> index 23af4633f0f4..95acb099315e 100644
> --- a/tools/testing/selftests/mm/Makefile
> +++ b/tools/testing/selftests/mm/Makefile
> @@ -34,6 +34,7 @@ LDLIBS = -lrt -lpthread
>  
>  TEST_GEN_PROGS = cow
>  TEST_GEN_PROGS += compaction_test
> +TEST_GEN_PROGS += gup_longterm

Hi David,

Peter Xu just pointed out that we need a .gitignore entry for
gup_longterm [1]. That logically belongs in this patch, I think.


[1] https://lore.kernel.org/all/ZH4FFa4FV9KGwBZo@x1n

thanks,
-- 
John Hubbard
NVIDIA