Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4b2fdd36-0871-ecc7-5d64-e088d7f51987@gmail.com>
Date:   Tue, 6 Jun 2023 08:38:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH] arm64: dts: mediatek: mt8192: Fix CPUs capacity-dmips-mhz
Content-Language: en-US, ca-ES, es-ES
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= 
        <nfraprado@collabora.com>
Cc:     kernel@collabora.com, Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Seiya Wang <seiya.wang@mediatek.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
References: <20230602183515.3778780-1-nfraprado@collabora.com>
 <01c88a42-274c-f8cf-73a6-29741579d9db@collabora.com>
From:   Matthias Brugger <matthias.bgg@gmail.com>
In-Reply-To: <01c88a42-274c-f8cf-73a6-29741579d9db@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 05/06/2023 10:21, AngeloGioacchino Del Regno wrote:
> Il 02/06/23 20:35, Nícolas F. R. A. Prado ha scritto:
>> The capacity-dmips-mhz parameter was miscalculated: this SoC runs
>> the first (Cortex-A55) cluster at a maximum of 2000MHz and the
>> second (Cortex-A76) cluster at a maximum of 2200MHz.
>>
>> In order to calculate the right capacity-dmips-mhz, the following
>> test was performed:
>> 1. CPUFREQ governor was set to 'performance' on both clusters
>> 2. Ran dhrystone with 500000000 iterations for 10 times on each cluster
>> 3. Calculated the mean result for each cluster
>> 4. Calculated DMIPS/MHz: dmips_mhz = dmips_per_second / cpu_mhz
>> 5. Scaled results to 1024:
>>     result_c0 = dmips_mhz_c0 / dmips_mhz_c1 * 1024
>>
>> The mean results for this SoC are:
>> Cluster 0 (LITTLE): 12016411 Dhry/s
>> Cluster 1 (BIG): 31702034 Dhry/s
>>
>> The calculated scaled results are:
>> Cluster 0: 426.953226899238 (rounded to 427)
>> Cluster 1: 1024
>>
>> Fixes: 48489980e27e ("arm64: dts: Add Mediatek SoC MT8192 and evaluation board 
>> dts and Makefile")
>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>>
> 

Applied, thanks
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
>